Message ID | 20210121061141.23062-1-o.rempel@pengutronix.de |
---|---|
Headers | show |
Series | devicetree fixes for Protonic and Plymovent boards | expand |
Hi Oleksij, On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > At some point PWM cell count was changed, but it didn't triggered any It changed in this commit: commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Fri Jul 10 07:19:37 2020 +0200 ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files The imx-pwm driver supports 3 cells and this is the more flexible setting. So use it by default and overwrite it back to two for the files that reference the PWMs with just 2 cells to minimize changes. This allows to drop explicit setting to 3 cells for the boards that already depend on this. The boards that are now using 2 cells explicitly can be converted to 3 individually. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
On Thu, Jan 21, 2021 at 11:17:42AM -0300, Fabio Estevam wrote: > Hi Oleksij, > > On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > > > At some point PWM cell count was changed, but it didn't triggered any > > It changed in this commit: > > commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 > Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Date: Fri Jul 10 07:19:37 2020 +0200 > > ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files > > The imx-pwm driver supports 3 cells and this is the more flexible setting. > So use it by default and overwrite it back to two for the files that > reference the PWMs with just 2 cells to minimize changes. > > This allows to drop explicit setting to 3 cells for the boards that already > depend on this. The boards that are now using 2 cells explicitly can be > converted to 3 individually. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Shawn Guo <shawnguo@kernel.org> OK, nice. Thx! Should I resend this series without this patch? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |