From patchwork Mon Sep 13 18:25:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 511166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592AEC433EF for ; Mon, 13 Sep 2021 18:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BD90610F9 for ; Mon, 13 Sep 2021 18:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236173AbhIMS1T (ORCPT ); Mon, 13 Sep 2021 14:27:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233133AbhIMS1T (ORCPT ); Mon, 13 Sep 2021 14:27:19 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4CC4760F9F; Mon, 13 Sep 2021 18:26:03 +0000 (UTC) Received: from [198.52.44.129] (helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mPqeX-00AYPD-3J; Mon, 13 Sep 2021 19:26:01 +0100 From: Marc Zyngier To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Alyssa Rosenzweig , Stan Skowronek , Mark Kettenis , Sven Peter , Hector Martin , Robin Murphy , kernel-team@android.com Subject: [PATCH v3 00/10] PCI: Add support for Apple M1 Date: Mon, 13 Sep 2021 19:25:40 +0100 Message-Id: <20210913182550.264165-1-maz@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 198.52.44.129 X-SA-Exim-Rcpt-To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, lorenzo.pieralisi@arm.com, kw@linux.com, alyssa@rosenzweig.io, stan@corellium.com, kettenis@openbsd.org, sven@svenpeter.dev, marcan@marcan.st, Robin.Murphy@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org I have resumed my earlier effort to bring the Apple-M1 into the world of living by equipping it with a PCIe controller driver. Huge thanks to Alyssa Rosenzweig for kicking it into shape and providing the first two versions of this series. Much has changed since v2[2]. Mark Kettenis is doing a great job with the binding [0], so I have dropped that from the series, and strictly focused on the Linux side of thing. I am now using this binding as is, with the exception of a single line change, which I believe is a fix [1]. Supporting the per-port interrupt controller has brought in a couple of fixes for the core DT code. Also, some work has gone into dealing with excluding the MSI page from the IOVA range, as well as programming the RID-to-SID mapper. Overall, the driver is now much cleaner and most probably feature complete when it comes to supporting internal devices (although I haven't investigated things like power management). TB support is another story, and will require some more hacking. This of course still depends on the clock and pinctrl drivers that are otherwise in flight, and will affect this driver one way or another. I have pushed a branch with all the dependencies (and more) at [3]. * From v2 [2]: - Refactor DT parsing to match the new version of the binding - Add support for INTx and port-private interrupts - Signal link-up/down using interrupts - Export of_phandle_args_to_fwspec - Fix generic parsing of interrupt map - Rationalise port setup (data structure, self discovery) - Tell DART to exclude MSI doorbell from the IOVA mappings - Get rid of the setup bypass if the link was found up on boot - Prevent the module from being removed - Program the RID-to-SID mapper on device discovery - Rebased on 5.15-rc1 [0] https://lore.kernel.org/r/20210827171534.62380-1-mark.kettenis@xs4all.nl [1] https://lore.kernel.org/r/871r5tcwhp.wl-maz@kernel.org [2] https://lore.kernel.org/r/20210816031621.240268-1-alyssa@rosenzweig.io [3] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=hack/m1-pcie-v3 Alyssa Rosenzweig (2): PCI: apple: Add initial hardware bring-up PCI: apple: Set up reference clocks when probing Marc Zyngier (8): irqdomain: Make of_phandle_args_to_fwspec generally available of/irq: Allow matching of an interrupt-map local to an interrupt controller PCI: of: Allow matching of an interrupt-map local to a pci device PCI: apple: Add INTx and per-port interrupt support arm64: apple: t8103: Add root port interrupt routing PCI: apple: Implement MSI support iommu/dart: Exclude MSI doorbell from PCIe device IOVA range PCI: apple: Configure RID to SID mapper on device addition MAINTAINERS | 7 + arch/arm64/boot/dts/apple/t8103.dtsi | 33 +- drivers/iommu/apple-dart.c | 25 + drivers/of/irq.c | 17 +- drivers/pci/controller/Kconfig | 17 + drivers/pci/controller/Makefile | 1 + drivers/pci/controller/pcie-apple.c | 818 +++++++++++++++++++++++++++ drivers/pci/of.c | 10 +- include/linux/irqdomain.h | 4 + kernel/irq/irqdomain.c | 6 +- 10 files changed, 925 insertions(+), 13 deletions(-) create mode 100644 drivers/pci/controller/pcie-apple.c