From patchwork Tue Apr 19 21:48:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 563476 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC435C433EF for ; Tue, 19 Apr 2022 21:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344874AbiDSVvS (ORCPT ); Tue, 19 Apr 2022 17:51:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343747AbiDSVvR (ORCPT ); Tue, 19 Apr 2022 17:51:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B56513FD8F for ; Tue, 19 Apr 2022 14:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650404912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iUv2NTJ7gTBOf8GrxhIvtx/g2bgEnpVi/9pLqch7VAA=; b=eGu2cDi6gScF6rdlKqvKOtG7tkAv2Ttfiw3OT4PMFaJWad4UbtreZjP7FpoRYk8XyZHa2m GSQKgy4WNK52TsQh/hy56uwalPH8eCpKpoaeZSaPXUPoBD4qzBDFlQuwgBkpAnVTa3slfR ALoZtXdyaDJCkMcJ0MytuurAn4AOX9c= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-50-wvbBax4jMS20wJEWrlySXw-1; Tue, 19 Apr 2022 17:48:31 -0400 X-MC-Unique: wvbBax4jMS20wJEWrlySXw-1 Received: by mail-wm1-f71.google.com with SMTP id k66-20020a1ca145000000b003928959f8efso1220089wme.1 for ; Tue, 19 Apr 2022 14:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iUv2NTJ7gTBOf8GrxhIvtx/g2bgEnpVi/9pLqch7VAA=; b=EenJhZxdzuoIQJQcq7hXGWvdRCHsmUoj8zr6nLZC7h+Zd7xjLpBFz6vSo6/nTO3mmy 05iQeHwW6crbJaAYS7+VPfPWJorXqOP32aaRusLfymLmKTzdssoVQ9OOcD7PHLSthc8C 60gUi5sHGNRxYg8YvHmCkvSWA4rott8ovIsRdVBA05B7iUVQtG28ZiZN/T3wAvON6oGd 0v5aXRpAGjstTZpkUALBAPsfbDne6hDElD3/UT7I3vl4G2MG7KaryG1DZjMYS+rZZ9Ei XqJR0SZhUgLGKsjk2lPIRON0csL5ohrWZtXXzC3i2N1I8L+wcNdLGT7IAXeTuMnRh7YZ LUyA== X-Gm-Message-State: AOAM533eTwhspkbwBU18qBBowDGJb+M4xLgIiHsS5LvN4SrDpRenpj4V 3LqNDiTaLKjZ4AcRNTSYjAFiLhNzTcxK1lCHi9ho6e2NgTzKCrbEyJl0znxHFBFRUximjBuuBn+ YV1axVW3qzUU+7yjH2V1/bA== X-Received: by 2002:a05:6000:156e:b0:20a:9665:ca9d with SMTP id 14-20020a056000156e00b0020a9665ca9dmr9055406wrz.172.1650404910372; Tue, 19 Apr 2022 14:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzTCCp+DmpxwaENdM0BASbGg3Ig10/xv8vgQpwOiaUtPU5pBeDOUif9F+KNHopbNeaYjdzPw== X-Received: by 2002:a05:6000:156e:b0:20a:9665:ca9d with SMTP id 14-20020a056000156e00b0020a9665ca9dmr9055390wrz.172.1650404910137; Tue, 19 Apr 2022 14:48:30 -0700 (PDT) Received: from minerva.home ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id i7-20020a5d5587000000b00207a8cde900sm13333699wrv.19.2022.04.19.14.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 14:48:29 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Mark Brown , Rob Herring , Geert Uytterhoeven , Chen-Yu Tsai , Andy Shevchenko , Neil Armstrong , Javier Martinez Canillas , Chen-Yu Tsai , Daniel Vetter , David Airlie , Geert Uytterhoeven , Krzysztof Kozlowski , Maxime Ripard , Maxime Ripard , Rob Herring , YueHaibing , devicetree@vger.kernel.org Subject: [PATCH v5 0/5] drm/solomon: Add SSD130x OLED displays SPI support Date: Tue, 19 Apr 2022 23:48:18 +0200 Message-Id: <20220419214824.335075-1-javierm@redhat.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, This series adds a ssd130x-spi driver that provides a 4-wire SPI transport support for SSD130x OLED controllers that can be accessed over a SPI bus. The driver is quite similar to existing ssd130x-i2c driver that is used by I2C controllers, but there is a difference in the protocol used by SSD130x depending on the transport used. The details are in patch #4 description. Patch #1 just makes the current ssd130x-i2c compatible strings in the DT binding to be deprecated, and add new ones that don't have an "fb-i2c". Patch #2 extends the DT binding with the properties needed to support SPI. Patch #3 adds the new compatible strings to the OF device ID table in the ssd130x-i2c DRM driver and deprecate the old ones. Patch #4 moves the device info for the different SSD130x variants from the ssd130x-i2c transport driver to the ssd130x core driver. Finally patch #5 adds the ssd130x-spi DRM driver for the OLED controllers that come with a 4-wire SPI interface, instead of an I2C interface. This is a v5 that addresses the issues pointed out in v4. Best regards, Javier Changes in v5: - Remove unnecessary blank line added by mistake in v4 (Andy Shevchenko). - Remove cast by just using u8 *reg instead of void *data (Geert Uytterhoeven). - Add Geert Uytterhoeven's Reviewed-by tag to patch 5/5. Changes in v4: - Add a description for the dc-gpios property for SPI (Geert Uytterhoeven) - Export ssd13x_variants array using EXPORT_SYMBOL_NS_GPL() (Andy Shevchenko) - Use MODULE_IMPORT_NS(DRM_SSD130X) in the ssd130x-i2c driver (Andy Shevchenko) - Use MODULE_IMPORT_NS(DRM_SSD130X) in the ssd130x-spi driver (Andy Shevchenko) Changes in v3: - Drop the "sinowealth,sh1106-i2c", wasn't in a released version (Chen-Yu Tsai) - Continue enforcing required properties for deprecated strings (Maxime Ripard) - Add a comment to the properties required for SPI (Geert Uytterhoeven) - Drop the "sinowealth,sh1106-i2c", wasn't in a released version (Chen-Yu Tsai) - s/it/they in the commit description (Geert Uytterhoeven) - Drop unnecessary blank line (Geert Uytterhoeven) - Export variants array and use &info[ID] in device table (Andy Shevchenko) - Drop ssd130x_spi_get_dc() helper and open code it (Geert Uytterhoeven) - Export variants array and use &info[ID] in device table (Andy Shevchenko) - Add Geert Uytterhoeven's Reviewed-by tag to patches. Changes in v2: - Drop the -i2c suffixes from the compatible strings too (Geert Uytterhoeven) - Don't add compatible strings with an "-spi" suffix (Geert Uytterhoeven) - Use the compatible strings that don't have "fb-i2c" (Geert Uytterhoeven). - Drop ssd13x_variant_to_info() and just use the array index (Neil Armstrong). - Add the same compatible strings than I2C (Geert Uytterhoeven) - Add Mark Brown's Acked-by tag to all patches. Javier Martinez Canillas (5): dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings dt-bindings: display: ssd1307fb: Extend schema for SPI controllers drm/solomon: Add ssd130x new compatible strings and deprecate old ones. drm/solomon: Move device info from ssd130x-i2c to the core driver drm/solomon: Add SSD130x OLED displays SPI support .../bindings/display/solomon,ssd1307fb.yaml | 86 +++++++-- drivers/gpu/drm/solomon/Kconfig | 9 + drivers/gpu/drm/solomon/Makefile | 1 + drivers/gpu/drm/solomon/ssd130x-i2c.c | 63 +++---- drivers/gpu/drm/solomon/ssd130x-spi.c | 178 ++++++++++++++++++ drivers/gpu/drm/solomon/ssd130x.c | 35 +++- drivers/gpu/drm/solomon/ssd130x.h | 14 ++ 7 files changed, 329 insertions(+), 57 deletions(-) create mode 100644 drivers/gpu/drm/solomon/ssd130x-spi.c