mbox series

[v1,0/2] MT8192 pinctrl properties adjustments

Message ID 20220525155714.1837360-1-nfraprado@collabora.com
Headers show
Series MT8192 pinctrl properties adjustments | expand

Message

Nícolas F. R. A. Prado May 25, 2022, 3:57 p.m. UTC 
The two patches in this series substitute properties in the mt8192
pinctrl dt-binding for ones which have a clearer meaning and are more
standardized. At this point there's no DT using the mt8192 pinctrl
binding, so if such changes are to be made, they need to happen now.


Nícolas F. R. A. Prado (2):
  dt-bindings: pinctrl: mt8192: Add drive-strength-microamp
  dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv

 .../bindings/pinctrl/pinctrl-mt8192.yaml      | 58 ++++++-------------
 1 file changed, 18 insertions(+), 40 deletions(-)

Comments

AngeloGioacchino Del Regno May 30, 2022, 8:36 a.m. UTC | #1 
Il 25/05/22 17:57, Nícolas F. R. A. Prado ha scritto:
> Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> drive-strength-microamp instead of mediatek,drive-strength-adv.
> 
> Since there aren't any users of mediatek,drive-strength-adv on mt8192
> yet, remove this property and add drive-strength-microamp in its place,
> which has a clearer meaning.
> 
> Fixes: 4ac68333ff6d ("dt-bindings: pinctrl: mt8192: Add mediatek,drive-strength-adv property")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogiocchino.delregno@collabora.com>
Chen-Yu Tsai May 30, 2022, 8:48 a.m. UTC | #2 
On Wed, May 25, 2022 at 11:58 PM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> Commit e5fabbe43f3f ("pinctrl: mediatek: paris: Support generic
> PIN_CONFIG_DRIVE_STRENGTH_UA") added support for using
> drive-strength-microamp instead of mediatek,drive-strength-adv.
>
> Since there aren't any users of mediatek,drive-strength-adv on mt8192
> yet, remove this property and add drive-strength-microamp in its place,
> which has a clearer meaning.

Cool! Thanks for taking care of this~ I was looking at this and tried
to make drive-strength and drive-strength-microamp mutually exclusive,
but since they are optional, it didn't really work, and I put it on the
back burner.


ChenYu