| Message ID | 20220828084341.112146-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | arm64/dt-bindings: mfd: qcom: SPMI PMIC fixes | expand |
On 28-08-22, 11:43, Krzysztof Kozlowski wrote: > Hi, > > The Qualcomm SPMI PMIC DT schema conversion was not really tested and several > issues in the bindings and DTS should be corrected. > > 1. The DTS patches can go independently. > 2. The binding change continuous work of PWM reg fix and depends on it in > context (diff hunk): > https://lore.kernel.org/all/20220827145640.3530878-1-bryan.odonoghue@linaro.org/ > Binidings changes and above, can be taken via MFD tree (fixed commit was > merged in v6.0-rc1). Reviewed-by: Vinod Koul <vkoul@kernel.org>
Quoting Krzysztof Kozlowski (2022-08-28 01:43:27) > Hi, > > The Qualcomm SPMI PMIC DT schema conversion was not really tested and several > issues in the bindings and DTS should be corrected. > > 1. The DTS patches can go independently. > 2. The binding change continuous work of PWM reg fix and depends on it in > context (diff hunk): > https://lore.kernel.org/all/20220827145640.3530878-1-bryan.odonoghue@linaro.org/ > Binidings changes and above, can be taken via MFD tree (fixed commit was > merged in v6.0-rc1). > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Mon, Aug 29, 2022 at 10:26:43PM -0500, Bjorn Andersson wrote: > On Sun, 28 Aug 2022 11:43:27 +0300, Krzysztof Kozlowski wrote: > > The Qualcomm SPMI PMIC DT schema conversion was not really tested and several > > issues in the bindings and DTS should be corrected. > > > > 1. The DTS patches can go independently. > > 2. The binding change continuous work of PWM reg fix and depends on it in > > context (diff hunk): > > https://lore.kernel.org/all/20220827145640.3530878-1-bryan.odonoghue@linaro.org/ > > Binidings changes and above, can be taken via MFD tree (fixed commit was > > merged in v6.0-rc1). > > > > [...] > > Applied, thanks! > > [01/14] ARM: dts: qcom: align SPMI PMIC ADC node name with dtschema > commit: 662e305dfc29b96913a03dde1e89e8968da65238 > [02/14] ARM: dts: qcom: pm8941: align SPMI PMIC LPG node name with dtschema > commit: 7b357d3126226b7ec4810e26f4ded44b2286d197 > [03/14] ARM: dts: qcom: pmx55: align SPMI PMIC Power-on node name with dtschema > commit: 4bdfd92cb14d97ef58600926ea6b2788b31c719f Not sure what I did to trick b4 here, but I also merged 4-12. Regards, Bjorn
On Sun, 28 Aug 2022 11:43:41 +0300, Krzysztof Kozlowski wrote: > There are two bindings for Qualcomm SPMI PMIC Thermal Monitoring ADC: > one for ADC HC and one for ADC TM5 and TM7. PM8998 uses the former one, > so fix matching of child schema: > > qcom/msm8998-asus-novago-tp370ql.dtb: pmic@0: adc-tm@3400:compatible:0: 'qcom,spmi-adc-tm-hc' is not one of ['qcom,spmi-adc-tm5', 'qcom,spmi-adc-tm5-gen2', 'qcom,adc-tm7'] > > Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/mfd/qcom,spmi-pmic.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi, The Qualcomm SPMI PMIC DT schema conversion was not really tested and several issues in the bindings and DTS should be corrected. 1. The DTS patches can go independently. 2. The binding change continuous work of PWM reg fix and depends on it in context (diff hunk): https://lore.kernel.org/all/20220827145640.3530878-1-bryan.odonoghue@linaro.org/ Binidings changes and above, can be taken via MFD tree (fixed commit was merged in v6.0-rc1). Best regards, Krzysztof Krzysztof Kozlowski (14): ARM: dts: qcom: align SPMI PMIC ADC node name with dtschema ARM: dts: qcom: pm8941: align SPMI PMIC LPG node name with dtschema ARM: dts: qcom: pmx55: align SPMI PMIC Power-on node name with dtschema arm64: dts: qcom: pmk8350: drop incorrect io-channel-ranges arm64: dts: qcom: pmk8350: drop interrupt-names from ADC arm64: dts: qcom: align SPMI PMIC ADC node name with dtschema arm64: dts: qcom: align SPMI PMIC regulators node name with dtschema arm64: dts: qcom: align SPMI PMIC LPG node name with dtschema arm64: dts: qcom: align SPMI PMIC Power-on node name with dtschema arm64: dts: qcom: align PMIC GPIO pin configuration with DT schema arm64: dts: qcom: sc7280-idp: correct ADC channel node name and unit address arm64: dts: qcom: sdm845-mtp: correct ADC settle time dt-bindings: mfd: qcom,spmi-pmic: fix regulator node schema dt-bindings: mfd: qcom,spmi-pmic: fix TM ADC node schema on PM8998 .../bindings/mfd/qcom,spmi-pmic.yaml | 20 +++++++++++++++++-- arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++-- arch/arm/boot/dts/qcom-pma8084.dtsi | 2 +- arch/arm/boot/dts/qcom-pmx55.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm660.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm660l.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/pm8150.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8150b.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/pm8150l.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/pm8953.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8994.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmi8998.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmk8350.dtsi | 3 --- arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 2 +- .../boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 12 +++++------ .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +- 21 files changed, 46 insertions(+), 33 deletions(-)