| Message ID | 20220909204207.15820-1-quic_amelende@quicinc.com |
|---|---|
| Headers | show |
| Series | add support for PON GEN3 device | expand |
On 09/09/2022 22:42, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@quicinc.com> > > Add a new compatible string "qcom,pmk8350-pon" for GEN3 PMIC PON > peripherals and update "reg" property. > Also, Add an optional "reg-names" property to differentiate between > GEN1/GEN2 and GEN3 peripherals. GEN1/GEN2 peripherals only need one > register address to be specified (e.g. "pon") whereas GEN3 peripherals > can have two register addresses specified ("hlos", "pbs"). > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On Fri, Sep 09, 2022 at 01:42:07PM -0700, Anjelique Melendez wrote: > Resent with fixed path for dt-bindings. > > Changes from v4: > - Updated commit message for patch 1/2 > > Changes from v3: > - Addressed Krysztof's comments on patch 1/2 > - Added missing minItems/maxItems > - Merged if statments with same constraints together > - Removed description from "reg-names" > > Changes from v2: > - Added new "qcom,pmk8350-pon" compatible string as per Krysztof's > advice > - Updated dt logic to use comptaible strings to decide constraints > as per Krysztof's comment > - Added new patch (v3 2/2) to support new compatible string > > Changes from v1: > - Updated path which was missing Documentation/devicetree prefix > - Updated CC list > > New patch series to separate this patch from applied patches. > Comments from original patch can be found > https://lore.kernel.org/linux-arm-msm/27515993-18f3-8891-4835-9b6a8d7f86b0@quicinc.com/ > > David Collins (1): > dt-bindings: power: reset: qcom-pon: Add new compatible > "qcom,pmk8350-pon" > > Anjelique Melendez (1): > power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string > > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++--- > drivers/power/reset/qcom-pon.c | 1 + > 2 file changed, 47 insertions(+), 4 deletions(-) Thanks, I queued both patches. -- Sebastian
On 09-09-22, 13:42, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@quicinc.com> > > Add a new compatible string "qcom,pmk8350-pon" for GEN3 PMIC PON > peripherals and update "reg" property. > Also, Add an optional "reg-names" property to differentiate between > GEN1/GEN2 and GEN3 peripherals. GEN1/GEN2 peripherals only need one > register address to be specified (e.g. "pon") whereas GEN3 peripherals > can have two register addresses specified ("hlos", "pbs"). Reviewed-by: Vinod Koul <vkoul@kernel.org>
Resent with fixed path for dt-bindings. Changes from v4: - Updated commit message for patch 1/2 Changes from v3: - Addressed Krysztof's comments on patch 1/2 - Added missing minItems/maxItems - Merged if statments with same constraints together - Removed description from "reg-names" Changes from v2: - Added new "qcom,pmk8350-pon" compatible string as per Krysztof's advice - Updated dt logic to use comptaible strings to decide constraints as per Krysztof's comment - Added new patch (v3 2/2) to support new compatible string Changes from v1: - Updated path which was missing Documentation/devicetree prefix - Updated CC list New patch series to separate this patch from applied patches. Comments from original patch can be found https://lore.kernel.org/linux-arm-msm/27515993-18f3-8891-4835-9b6a8d7f86b0@quicinc.com/ David Collins (1): dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon" Anjelique Melendez (1): power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++--- drivers/power/reset/qcom-pon.c | 1 + 2 file changed, 47 insertions(+), 4 deletions(-)