| Message ID | 20221210033033.662553-1-colin.foster@in-advantage.com |
|---|---|
| Headers | show |
| Series | dt-binding preparation for ocelot switches | expand |
On Sat, Dec 10, 2022 at 11:18:29AM +0100, Kurt Kanzenbach wrote: > You can update the hellcreek binding as well. Thanks. > > diff --git a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml > index 73b774eadd0b..1d7dab31457d 100644 > --- a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml > @@ -12,7 +12,7 @@ allOf: > maintainers: > - Andrew Lunn <andrew@lunn.ch> > - Florian Fainelli <f.fainelli@gmail.com> > - - Vivien Didelot <vivien.didelot@gmail.com> > + - Vladimir Oltean <olteanv@gmail.com> > - Kurt Kanzenbach <kurt@linutronix.de> > > description: Good observation. If there are no other comments on this patch series (which otherwise looks reasonable to me), I suppose that could be accomplished via a parallel patch as well? The diff you're proposing does not seem to conflict with something else that Colin is touching in this patch set.
On Mon Dec 12 2022, Vladimir Oltean wrote: > On Sat, Dec 10, 2022 at 11:18:29AM +0100, Kurt Kanzenbach wrote: >> You can update the hellcreek binding as well. Thanks. >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml >> index 73b774eadd0b..1d7dab31457d 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml >> @@ -12,7 +12,7 @@ allOf: >> maintainers: >> - Andrew Lunn <andrew@lunn.ch> >> - Florian Fainelli <f.fainelli@gmail.com> >> - - Vivien Didelot <vivien.didelot@gmail.com> >> + - Vladimir Oltean <olteanv@gmail.com> >> - Kurt Kanzenbach <kurt@linutronix.de> >> >> description: > > Good observation. If there are no other comments on this patch series > (which otherwise looks reasonable to me), I suppose that could be > accomplished via a parallel patch as well? The diff you're proposing > does not seem to conflict with something else that Colin is touching in > this patch set. Sure, it shouldn't conflict. I'll send a patch to update this separately. Thanks, Kurt
On Fri, 09 Dec 2022 19:30:24 -0800, Colin Foster wrote: > The MAINTAINERS file has Andrew Lunn, Florian Fainelli, and Vladimir Oltean > listed as the maintainers for generic dsa bindings. Update dsa.yaml and > dsa-port.yaml accordingly. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > > --- > > v5 > * New patch > > --- > Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 2 +- > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Fri, 9 Dec 2022 19:30:23 -0800 Colin Foster wrote: > Ocelot switches have the abilitiy to be used internally via > memory-mapped IO or externally via SPI or PCIe. This brings up issues > for documentation, where the same chip might be accessed internally in a > switchdev manner, or externally in a DSA configuration. This patch set > is perparation to bring DSA functionality to the VSC7512, utilizing as > much as possible with an almost identical VSC7514 chip. > > This patch set changed quite a bit from v2, so I'll omit the background > of how those sets came to be. Rob offered a lot of very useful guidance. > My thanks. > > At the end of the day, with this patch set, there should be a framework > to document Ocelot switches (and any switch) in scenarios where they can > be controlled internally (ethernet-switch) or externally (dsa-switch). A lot of carried over review tags here, so please let me know if there's anything that needs to be reviewed here, otherwise I'd like to merge the series for 6.2 by the end of the day.
On Fri, Dec 09, 2022 at 07:30:26PM -0800, Colin Foster wrote: > The children of the switch node don't have a unit address, and therefore > should not need the #address-cells or #size-cells entries. Fix the example > schemas accordingly. > > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On Fri, Dec 09, 2022 at 07:30:28PM -0800, Colin Foster wrote: > Explicitly allow additional properties for both the ethernet-port and > ethernet-ports properties. This specifically will allow the qca8k.yaml > binding to use shared properties. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On Fri, Dec 09, 2022 at 07:30:30PM -0800, Colin Foster wrote: > dsa.yaml contains a reference to dsa-port.yaml, so a duplicate reference to > the binding isn't necessary. Remove this unnecessary reference. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On Mon, Dec 12, 2022 at 10:29:58AM -0800, Jakub Kicinski wrote: > On Fri, 9 Dec 2022 19:30:23 -0800 Colin Foster wrote: > > Ocelot switches have the abilitiy to be used internally via > > memory-mapped IO or externally via SPI or PCIe. This brings up issues > > for documentation, where the same chip might be accessed internally in a > > switchdev manner, or externally in a DSA configuration. This patch set > > is perparation to bring DSA functionality to the VSC7512, utilizing as > > much as possible with an almost identical VSC7514 chip. > > > > This patch set changed quite a bit from v2, so I'll omit the background > > of how those sets came to be. Rob offered a lot of very useful guidance. > > My thanks. > > > > At the end of the day, with this patch set, there should be a framework > > to document Ocelot switches (and any switch) in scenarios where they can > > be controlled internally (ethernet-switch) or externally (dsa-switch). > > A lot of carried over review tags here, so please let me know if > there's anything that needs to be reviewed here, otherwise I'd like > to merge the series for 6.2 by the end of the day. I just responded to patch 4, which has a small (?) outstanding issue / discussion. I asked Rob and Arınç's opinions as to whether it should hold up this series. Everything else is good to go, as far as I understand.
On Mon, 12 Dec 2022 11:03:09 -0800 Colin Foster wrote: > > A lot of carried over review tags here, so please let me know if > > there's anything that needs to be reviewed here, otherwise I'd like > > to merge the series for 6.2 by the end of the day. > > I just responded to patch 4, which has a small (?) outstanding issue / > discussion. I asked Rob and Arınç's opinions as to whether it should > hold up this series. Everything else is good to go, as far as I > understand. No reply :( Since this is "just" DT bindings (as in shouldn't functionally break anything) - if Rob gives us a green light we can still pull it into the mid-merge window follow up. But I'll drop it from pw for now so it doesn't distract us.
Ocelot switches have the abilitiy to be used internally via memory-mapped IO or externally via SPI or PCIe. This brings up issues for documentation, where the same chip might be accessed internally in a switchdev manner, or externally in a DSA configuration. This patch set is perparation to bring DSA functionality to the VSC7512, utilizing as much as possible with an almost identical VSC7514 chip. This patch set changed quite a bit from v2, so I'll omit the background of how those sets came to be. Rob offered a lot of very useful guidance. My thanks. At the end of the day, with this patch set, there should be a framework to document Ocelot switches (and any switch) in scenarios where they can be controlled internally (ethernet-switch) or externally (dsa-switch). --- v4 -> v5 * Sync DSA maintainers with MAINTAINERS file (new patch 1) * Undo move of port description of mediatek,mt7530.yaml (patch 4) * Move removal of "^(ethernet-)?switch(@.*)?$" in dsa.yaml from patch 4 to patch 8 * Add more consistent capitalization in title lines and better Ethernet switch port description. (patch 8) v3 -> v4 * Renamed "base" to "ethernet-ports" to avoid confusion with the concept of a base class. * Squash ("dt-bindings: net: dsa: mediatek,mt7530: fix port description location") patch into ("dt-bindings: net: dsa: utilize base definitions for standard dsa switches") * Corrections to fix confusion about additonalProperties vs unevaluatedProperties. See specific patches for details. v2 -> v3 * Restructured everything to use a "base" iref for devices that don't have additional properties, and simply a "ref" for devices that do. * New patches to fix up brcm,sf2, qca8k, and mt7530 * Fix unevaluatedProperties errors from previous sets (see specific patches for more detail) * Removed redundant "Device Tree Binding" from titles, where applicable. v1 -> v2 * Two MFD patches were brought into the MFD tree, so are dropped * Add first patch 1/6 to allow DSA devices to add ports and port properties * Test qca8k against new dt-bindings and fix warnings. (patch 2/6) * Add tags (patch 3/6) * Fix vsc7514 refs and properties --- Colin Foster (10): dt-bindings: dsa: sync with maintainers dt-bindings: net: dsa: sf2: fix brcm,use-bcm-hdr documentation dt-bindings: net: dsa: qca8k: remove address-cells and size-cells from switch node dt-bindings: net: dsa: utilize base definitions for standard dsa switches dt-bindings: net: dsa: allow additional ethernet-port properties dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port reference dt-bindings: net: add generic ethernet-switch dt-bindings: net: add generic ethernet-switch-port binding dt-bindings: net: mscc,vsc7514-switch: utilize generic ethernet-switch.yaml .../bindings/net/dsa/arrow,xrs700x.yaml | 2 +- .../devicetree/bindings/net/dsa/brcm,b53.yaml | 2 +- .../devicetree/bindings/net/dsa/brcm,sf2.yaml | 15 +++-- .../devicetree/bindings/net/dsa/dsa-port.yaml | 29 ++------- .../devicetree/bindings/net/dsa/dsa.yaml | 49 +++++++-------- .../net/dsa/hirschmann,hellcreek.yaml | 2 +- .../bindings/net/dsa/mediatek,mt7530.yaml | 6 +- .../bindings/net/dsa/microchip,ksz.yaml | 2 +- .../bindings/net/dsa/microchip,lan937x.yaml | 2 +- .../bindings/net/dsa/mscc,ocelot.yaml | 2 +- .../bindings/net/dsa/nxp,sja1105.yaml | 2 +- .../devicetree/bindings/net/dsa/qca8k.yaml | 14 +---- .../devicetree/bindings/net/dsa/realtek.yaml | 2 +- .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 2 +- .../bindings/net/ethernet-switch-port.yaml | 25 ++++++++ .../bindings/net/ethernet-switch.yaml | 62 +++++++++++++++++++ .../bindings/net/mscc,vsc7514-switch.yaml | 31 +--------- MAINTAINERS | 2 + 18 files changed, 143 insertions(+), 108 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch-port.yaml create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch.yaml