| Message ID | 20230103182229.37169-1-bmasney@redhat.com |
|---|---|
| Headers | show |
| Series | dts: qcom: sc8280xp: add i2c, spi, and rng nodes | expand |
On Tue, 03 Jan 2023 13:22:20 -0500, Brian Masney wrote: > Move the #address-cells and #size-cells properties on the existing > i2c/spi example nodes below the reg property so that all of the > address-related properties are grouped together. > > Signed-off-by: Brian Masney <bmasney@redhat.com> > Link: https://lore.kernel.org/lkml/Y6Wnh+tXPhF6aC1b@hovoldconsulting.com/ > --- > New patch introduced in v4 > > .../devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++-- > .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 4 ++-- > .../devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 8 ++++---- > 3 files changed, 8 insertions(+), 8 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On 03/01/2023 19:22, Brian Masney wrote: > Move the #address-cells and #size-cells properties on the existing > i2c/spi example nodes below the reg property so that all of the > address-related properties are grouped together. > > Signed-off-by: Brian Masney <bmasney@redhat.com> > Link: https://lore.kernel.org/lkml/Y6Wnh+tXPhF6aC1b@hovoldconsulting.com/ We do not have conclusion where these should be, so don't make any changes. https://github.com/konradybcio-work/dt_review Best regards, Krzysztof
On Tue, 3 Jan 2023 13:22:19 -0500, Brian Masney wrote: > This patch series adds the i2c and spi nodes that are missing on the > sc8280xp platform and cleans up the existing nodes. Since I am already > making changes to sc8280xp.dtsi in this series, I also included a change > to enable the rng node for this platform as well. > > Note that this series needs to be applied on top of: > [PATCH v5] arm64: dts: qcom: sa8540p-ride: enable pcie2a node > https://lore.kernel.org/lkml/20221213095922.11649-1-quic_shazhuss@quicinc.com/ > > [...] Applied, thanks! [03/10] arm64: dts: qcom: sc8280xp: rename qup2_uart17 to uart17 commit: 71bc1b42844fc0f596da28441c45ab67c5664fb2 [04/10] arm64: dts: qcom: sc8280xp: rename qup2_i2c5 to i2c21 commit: 6e1569ddfa64be0a6d6bd16aa85568a6175384a2 [05/10] arm64: dts: qcom: sc8280xp: rename qup0_i2c4 to i2c4 commit: 31e62e862a1ed8711fc973675c74848595422180 [06/10] arm64: dts: qcom: sc8280xp: add missing i2c nodes commit: 645aaf0a3826ba18a6f31993e721189666525cfc [07/10] arm64: dts: qcom: sc8280xp: add missing spi nodes commit: 3d256a90b3bf596d2fe318bba15339aa902d406e [08/10] arm64: dts: qcom: sa8540p-ride: add i2c nodes commit: e073899ec3e14d3a9fe7ac62469c1768f4bb7fe0 [09/10] arm64: dts: qcom: sc8280xp: add aliases for i2c4 and i2c21 commit: 1db9c1d1273904b13cef0e76690395a416e41dd4 [10/10] arm64: dts: qcom: sc8280xp: add rng device tree node commit: fa5573edd01e6dcf5aa2b2298be2a35d04917148 Best regards,
This patch series adds the i2c and spi nodes that are missing on the sc8280xp platform and cleans up the existing nodes. Since I am already making changes to sc8280xp.dtsi in this series, I also included a change to enable the rng node for this platform as well. Note that this series needs to be applied on top of: [PATCH v5] arm64: dts: qcom: sa8540p-ride: enable pcie2a node https://lore.kernel.org/lkml/20221213095922.11649-1-quic_shazhuss@quicinc.com/ Changes from v3 to v4: - Move the #address-cells and #size-cells properties below the reg properties. I also updated the DTS binding examples. (Johan) - Add missing power-domains property to spi nodes (Johan) - Collected R-b and T-b tags. Steev: You added your T-b to the cover letter of the v3 series. I only applied your T-b tag to two of the patches in this version that were appicable to your x13s i2c test. - Introduce patch 9 that adds aliases for i2c4 and i2c21 to x13s and crd DTS files Changes from v2 to v3: - Reordered rng node in patch 7 so that it's sorted correctly by address - Since I respun the series, I made Konrad's sort order suggestion to the state nodes since I'm making changes here. - Collected R-b and T-b tags. Brian Masney (10): dt-bindings: qcom,*-geni: move #{address,size}-cells on i2c/spi nodes arm64: dts: qcom: sc8280xp: move #{address,size}-cells on i2c nodes arm64: dts: qcom: sc8280xp: rename qup2_uart17 to uart17 arm64: dts: qcom: sc8280xp: rename qup2_i2c5 to i2c21 arm64: dts: qcom: sc8280xp: rename qup0_i2c4 to i2c4 arm64: dts: qcom: sc8280xp: add missing i2c nodes arm64: dts: qcom: sc8280xp: add missing spi nodes arm64: dts: qcom: sa8540p-ride: add i2c nodes arm64: dts: qcom: sc8280xp: add aliases for i2c4 and i2c21 arm64: dts: qcom: sc8280xp: add rng device tree node .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 +- .../bindings/soc/qcom/qcom,geni-se.yaml | 4 +- .../bindings/spi/qcom,spi-geni-qcom.yaml | 8 +- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 12 +- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 91 ++- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 162 ++-- .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 183 ++--- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 749 +++++++++++++++++- 8 files changed, 1022 insertions(+), 191 deletions(-)