mbox series

[v4,0/2] Driver support for RZ/V2M PWC

Message ID 20230105201242.189195-1-fabrizio.castro.jz@renesas.com
Headers show
Series Driver support for RZ/V2M PWC | expand

Message

Fabrizio Castro Jan. 5, 2023, 8:12 p.m. UTC
The PWC IP found in the RZ/V2M family of chips fits the Multi-Function
Device (MFD) model quite well, and comes with the below capabilities:
* external power supply on/off sequence generation
* on/off signal generation for the LPDDR4 core power supply (LPVDD)
* key input signals processing
* general-purpose output pins

Version 4 of this series basically just moves the dt-bindings
file under Documentation/devicetree/bindings/soc/renesas.

Thanks,
Fab
Fabrizio Castro (2):
  dt-bindings: mfd: Add RZ/V2M PWC
  soc: renesas: Add PWC support for RZ/V2M

 .../soc/renesas/renesas,rzv2m-pwc.yaml        |  56 +++++++
 drivers/soc/renesas/Kconfig                   |   4 +
 drivers/soc/renesas/Makefile                  |   1 +
 drivers/soc/renesas/pwc-rzv2m.c               | 141 ++++++++++++++++++
 4 files changed, 202 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-pwc.yaml
 create mode 100644 drivers/soc/renesas/pwc-rzv2m.c

Comments

Lee Jones Jan. 6, 2023, 9:14 a.m. UTC | #1
On Thu, 05 Jan 2023, Fabrizio Castro wrote:

> The Renesas RZ/V2M External Power Sequence Controller (PWC)
> IP is a multi-function device, and it's capable of:
> * external power supply on/off sequence generation
> * on/off signal generation for the LPDDR4 core power supply (LPVDD)
> * key input signals processing
> * general-purpose output pins

The subject line now needs changing.

This patch doesn't have anything to do with MFD.

> Add the corresponding dt-bindings.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> 
> v1->v2: I have dropped syscon, simple-mfd, regmap, offset, and the child nodes.
> v2->v3: No change.
> v3->v4: Moved file under Documentation/devicetree/bindings/soc/renesas,
>         and changed $id accordingly. Rob, I have kept your Reviewed-by
>         tag assuming you are still happy, please do jump in if you think
>         that's not appropriate anymore.
> 
>  .../soc/renesas/renesas,rzv2m-pwc.yaml        | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-pwc.yaml
Fabrizio Castro Jan. 6, 2023, 9:32 a.m. UTC | #2
Hi Lee,

Thanks for your feedback!

> 
> On Thu, 05 Jan 2023, Fabrizio Castro wrote:
> 
> > The Renesas RZ/V2M External Power Sequence Controller (PWC)
> > IP is a multi-function device, and it's capable of:
> > * external power supply on/off sequence generation
> > * on/off signal generation for the LPDDR4 core power supply (LPVDD)
> > * key input signals processing
> > * general-purpose output pins
> 
> The subject line now needs changing.
> 
> This patch doesn't have anything to do with MFD.

Doh, you are absolutely right, I'll send a v5 to address that.

Thanks,
Fab

> 
> > Add the corresponding dt-bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >
> > v1->v2: I have dropped syscon, simple-mfd, regmap, offset, and the child
> nodes.
> > v2->v3: No change.
> > v3->v4: Moved file under Documentation/devicetree/bindings/soc/renesas,
> >         and changed $id accordingly. Rob, I have kept your Reviewed-by
> >         tag assuming you are still happy, please do jump in if you think
> >         that's not appropriate anymore.
> >
> >  .../soc/renesas/renesas,rzv2m-pwc.yaml        | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/soc/renesas/renesas,rzv2m-pwc.yaml
> 
> --
> Lee Jones [李琼斯]