| Message ID | 20230216013230.22978-1-ansuelsmth@gmail.com |
|---|---|
| Headers | show |
| Series | Adds support for PHY LEDs with offload triggers | expand |
On Fri, Feb 17, 2023 at 03:30:13PM +0100, Andrew Lunn wrote: > On Thu, Feb 16, 2023 at 02:32:17AM +0100, Christian Marangi wrote: > > This is another attempt on adding this feature on LEDs, hoping this is > > the right time and someone finally notice this. > > Hi Christian > > Thanks for keeping working on this. > > I want to review it, and maybe implement LED support in a PHY > driver. But i'm busy with reworking EEE at the moment. > > The merge window is about to open, so patches are not going to be > accepted for the next two weeks. So i will take a look within that > time and give you feedback. > Sure take your time happy to discuss any improvement to this.
On Fri, Feb 17, 2023 at 05:03:46PM -0600, Rob Herring wrote: > On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > > Document the netdev trigger that makes the LED blink or turn on based on > > switch/phy events or an attached network interface. > > NAK. What is netdev? But netdev is a trigger, nothing new. Actually it was never documented. Is the linux,default-trigger getting deprecated? > > Don't add new linux,default-trigger entries either. We have better ways > to define trigger sources, namely 'trigger-sources'. > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > > index d34bb58c0037..6e016415a4d8 100644 > > --- a/Documentation/devicetree/bindings/leds/common.yaml > > +++ b/Documentation/devicetree/bindings/leds/common.yaml > > @@ -98,6 +98,8 @@ properties: > > # LED alters the brightness for the specified duration with one software > > # timer (requires "led-pattern" property) > > - pattern > > + # LED blink and turns on based on netdev events > > + - netdev > > - pattern: "^cpu[0-9]*$" > > - pattern: "^hci[0-9]+-power$" > > # LED is triggered by Bluetooth activity > > -- > > 2.38.1 > >
On Wed, Feb 22, 2023 at 03:02:04PM +0000, Lee Jones wrote: > On Fri, 17 Feb 2023, Andrew Lunn wrote: > > > On Thu, Feb 16, 2023 at 02:32:17AM +0100, Christian Marangi wrote: > > > This is another attempt on adding this feature on LEDs, hoping this is > > > the right time and someone finally notice this. > > > > Hi Christian > > > > Thanks for keeping working on this. > > > > I want to review it, and maybe implement LED support in a PHY > > driver. But i'm busy with reworking EEE at the moment. > > > > The merge window is about to open, so patches are not going to be > > accepted for the next two weeks. So i will take a look within that > > time and give you feedback. > > Thanks Andrew. If Pavel is still unavailable to conduct reviews, I'm > going to need all the help I can get with complex submissions such as > these. > Hi Lee, thanks for stepping in. Just wanted to tell you I got some message with Andrew to make this thing less problematic and to dry/make it more review friendly. We decided on pushing this in 3 step: 1. Propose most basic things for some switch and some PHY. (brightness and blink_set support only, already supported by LED core) 2. A small series that should be just a cleanup for the netdev trigger 3. Support for hw_control in the most possible clean and way with small patch to they are not hard to track and understand the concept of this feature. I'm starting with the step 1 and sending some of my patch and Andrew patch to add basic support and I will add you and LED mailing list in Cc. Again thanks for starting checking this and feel free to ask any question about this to me also privately, I'm very open to any help.