| Message ID | 20230801070019.219660-1-j-choudhary@ti.com |
|---|---|
| Headers | show |
| Series | Enable Display for J784S4 and AM69-SK platform | expand |
Hello Roger, On 01/08/23 22:28, Roger Quadros wrote: > +Tomi (fixed email) > > Need to fix this in > Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > > On 01/08/2023 19:48, Roger Quadros wrote: >> >> >> On 01/08/2023 10:00, Jayesh Choudhary wrote: >>> From: Dasnavis Sabiya <sabiya.d@ti.com> >>> >>> AM69 starter kit features an HDMI port and an eDP port. >>> >>> Add assigned clocks for DSS, DT node for DisplayPort PHY, >>> pinmux for HDMI hotplug and power down, mcu_i2c1 and dss_vout >>> for HDMI. >>> Also enable Serdes4 settings for DP display. >>> >>> Add the endpoint nodes to describe connection from: >>> DSS => MHDP => DisplayPort connector >>> DSS => TI TFP410 DPI-to-DVI Bridge => HDMI connector >>> >>> Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com> >>> [j-choudhary@ti.com: Fix dvi-bridge, dss, mhdp and serdes-refclk] >>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> >>> --- >>> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 237 ++++++++++++++++++++++++++ >>> 1 file changed, 237 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts >>> index d282c2c633c1..d9a0794bcf6e 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts >>> @@ -107,6 +107,83 @@ vdd_sd_dv: regulator-tlv71033 { >>> states = <1800000 0x0>, >>> <3300000 0x1>; >>> }; >>> + >>> + dp0_pwr_3v3: regulator { >> >> To be consistent with the rest of the file please >> use regulator-dp0-pwr Sure. >> >>> + compatible = "regulator-fixed"; >>> + regulator-name = "dp0-pwr"; >>> + regulator-min-microvolt = <3300000>; >>> + regulator-max-microvolt = <3300000>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&dp_pwr_en_pins_default>; >>> + gpio = <&main_gpio0 4 0>; /* DP0_3V3 _EN */ >>> + enable-active-high; >>> + }; >>> + >>> + dp0: connector { >> >> connector-dp0 Ok >> >>> + compatible = "dp-connector"; >>> + label = "DP0"; >>> + type = "full-size"; >>> + dp-pwr-supply = <&dp0_pwr_3v3>; >>> + >>> + port { >>> + dp0_connector_in: endpoint { >>> + remote-endpoint = <&dp0_out>; >>> + }; >>> + }; >>> + }; >>> + >>> + hdmi-connector { >> >> connector-hdmi Ok. >> >>> + compatible = "hdmi-connector"; >>> + label = "hdmi"; >>> + type = "a"; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&hdmi_hpd_pins_default>; >>> + >>> + ddc-i2c-bus = <&mcu_i2c1>; >>> + >>> + /* HDMI_HPD */ >>> + hpd-gpios = <&main_gpio0 0 GPIO_ACTIVE_HIGH>; >>> + >>> + port { >>> + hdmi_connector_in: endpoint { >>> + remote-endpoint = <&tfp410_out>; >>> + }; >>> + }; >>> + }; >>> + >>> + dvi-bridge { >> >> Although DT binding doc for ti,tfp410 says encoder >> a name starting with bridge maybe more appropriate. Will keep it as bridge-dvi. Will edit the node names in suggested in 3/5 and 4/5 as well. I will address the new-line comments too. Thanks -Jayesh >> [...]
This series adds support for: - DisplayPort for J784S4-EVM - Displayport and HDMI for AM69-SK platform Changelog v7->v8: - rebase on tag next-20230731 - add AM69 display support - fix commit heading for patch [2/5] Changelog v6->v7: - change compatible for scm_conf to 'simple-bus' - drop main_cpsw node due to driver dependency on [2] Changelog v5->v6: - Change header file according to [1]. - Add idle-state property in serdes_ln_ctrl node. - Fix dtbs_check warning due to clock-frequency property in serdes_refclk node by disabling the node in main.dtsi and enabling it in board file when the clock-frequency node is actually added. Changelog v4->v5: - rebased the patches on linux-next tip. Changelog v3->v4: - add reg property to serdes_ln_ctrl and fix the node name again to get rid of dtbs_check error. - reorder reg, reg-names and ranges property for main_cpsw1. - correct the order for clocks in serdes_wiz nodes to fix dtbs_check warnings. - fix indentation in reg, reg-names and clock property for dss node. - add comments for the reg type in dss registers. Changelog v3->v2: - fix dtc warnings for 'scm_conf' and 'serdes_ln_ctrl' nodes (Checked all the changes of the series with W=12 option during build) - added clock-frequency for serdes_refclk along with other EVM changes This refclk is being used by all the instances of serdes_wiz which are disabled by default. So configuring refclk when the serdes nodes are used for the first time is okay. Changelog v1->v2: - Moved J784S4 EVM changes together to the last patch (Suggested by Andrew) v7 patch link: <https://lore.kernel.org/all/20230728050859.7370-1-j-choudhary@ti.com/> [1]: <https://lore.kernel.org/all/20230721125732.122421-1-j-choudhary@ti.com/> [2]: <https://lore.kernel.org/all/20230605154153.24025-1-afd@ti.com/> Dasnavis Sabiya (1): arm64: dts: ti: k3-am69-sk: Add DP and HDMI support Rahul T R (2): arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node arm64: dts: ti: k3-j784s4-evm: Enable DisplayPort-0 Siddharth Vadapalli (2): arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux arm64: dts: ti: k3-j784s4-main: Add WIZ and SERDES PHY nodes arch/arm64/boot/dts/ti/k3-am69-sk.dts | 237 +++++++++++++++++ arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 117 +++++++++ arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 285 +++++++++++++++++++++ 3 files changed, 639 insertions(+)