| Message ID | 20231018215809.3477437-1-Frank.Li@nxp.com |
|---|---|
| Headers | show |
| Series | I3C slave mode support | expand |
On 18/10/2023 23:58, Frank Li wrote: > Introduce a new slave core layer in order to support slave functions in > linux kernel. This comprises the controller library and function library. > Controller library implements functions specific to an slave controller > and function library implements functions specific to an slave function. > > Introduce a new configfs entry to configure the slave function configuring > and bind the slave function with slave controller. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > drivers/i3c/Kconfig | 26 ++ > drivers/i3c/Makefile | 2 + > drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++ > drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++ > include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++ > 5 files changed, 1373 insertions(+) > create mode 100644 drivers/i3c/i3c-cfs.c > create mode 100644 drivers/i3c/slave.c > create mode 100644 include/linux/i3c/slave.h > > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig > index 30a441506f61c..d5f5ca7cd6a56 100644 > --- a/drivers/i3c/Kconfig > +++ b/drivers/i3c/Kconfig > @@ -22,3 +22,29 @@ menuconfig I3C > if I3C > source "drivers/i3c/master/Kconfig" > endif # I3C > + > +config I3C_SLAVE It doesn't look like you follow Kernel naming convention (see coding style). > + bool "I3C Slave Support" > + help > + Support I3C Slave Mode. > + Best regards, Krzysztof
On Thu, Oct 19, 2023 at 09:00:05AM +0200, Krzysztof Kozlowski wrote: > On 18/10/2023 23:58, Frank Li wrote: > > Introduce a new slave core layer in order to support slave functions in > > linux kernel. This comprises the controller library and function library. > > Controller library implements functions specific to an slave controller > > and function library implements functions specific to an slave function. > > > > Introduce a new configfs entry to configure the slave function configuring > > and bind the slave function with slave controller. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > drivers/i3c/Kconfig | 26 ++ > > drivers/i3c/Makefile | 2 + > > drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++ > > drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++ > > include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++ > > 5 files changed, 1373 insertions(+) > > create mode 100644 drivers/i3c/i3c-cfs.c > > create mode 100644 drivers/i3c/slave.c > > create mode 100644 include/linux/i3c/slave.h > > > > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig > > index 30a441506f61c..d5f5ca7cd6a56 100644 > > --- a/drivers/i3c/Kconfig > > +++ b/drivers/i3c/Kconfig > > @@ -22,3 +22,29 @@ menuconfig I3C > > if I3C > > source "drivers/i3c/master/Kconfig" > > endif # I3C > > + > > +config I3C_SLAVE > > It doesn't look like you follow Kernel naming convention (see coding style). I checked I3C spec. It use words 'target'. Is it okay using I3C_TARGET? > > > + bool "I3C Slave Support" > > + help > > + Support I3C Slave Mode. > > + > > > > Best regards, > Krzysztof >
On Thu, Oct 19, 2023 at 11:02:10AM -0400, Frank Li wrote: > On Thu, Oct 19, 2023 at 09:00:05AM +0200, Krzysztof Kozlowski wrote: > > On 18/10/2023 23:58, Frank Li wrote: > > > Introduce a new slave core layer in order to support slave functions in > > > linux kernel. This comprises the controller library and function library. > > > Controller library implements functions specific to an slave controller > > > and function library implements functions specific to an slave function. > > > > > > Introduce a new configfs entry to configure the slave function configuring > > > and bind the slave function with slave controller. > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > drivers/i3c/Kconfig | 26 ++ > > > drivers/i3c/Makefile | 2 + > > > drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++ > > > drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++ > > > include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++ > > > 5 files changed, 1373 insertions(+) > > > create mode 100644 drivers/i3c/i3c-cfs.c > > > create mode 100644 drivers/i3c/slave.c > > > create mode 100644 include/linux/i3c/slave.h > > > > > > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig > > > index 30a441506f61c..d5f5ca7cd6a56 100644 > > > --- a/drivers/i3c/Kconfig > > > +++ b/drivers/i3c/Kconfig > > > @@ -22,3 +22,29 @@ menuconfig I3C > > > if I3C > > > source "drivers/i3c/master/Kconfig" > > > endif # I3C > > > + > > > +config I3C_SLAVE > > > > It doesn't look like you follow Kernel naming convention (see coding style). > > I checked I3C spec. It use words 'target'. > Is it okay using I3C_TARGET? Why wouldn't it be?
On Thu, Oct 19, 2023 at 05:46:42PM +0200, Greg KH wrote: > On Thu, Oct 19, 2023 at 11:02:10AM -0400, Frank Li wrote: > > On Thu, Oct 19, 2023 at 09:00:05AM +0200, Krzysztof Kozlowski wrote: > > > On 18/10/2023 23:58, Frank Li wrote: > > > > Introduce a new slave core layer in order to support slave functions in > > > > linux kernel. This comprises the controller library and function library. > > > > Controller library implements functions specific to an slave controller > > > > and function library implements functions specific to an slave function. > > > > > > > > Introduce a new configfs entry to configure the slave function configuring > > > > and bind the slave function with slave controller. > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > drivers/i3c/Kconfig | 26 ++ > > > > drivers/i3c/Makefile | 2 + > > > > drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++ > > > > drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++ > > > > include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++ > > > > 5 files changed, 1373 insertions(+) > > > > create mode 100644 drivers/i3c/i3c-cfs.c > > > > create mode 100644 drivers/i3c/slave.c > > > > create mode 100644 include/linux/i3c/slave.h > > > > > > > > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig > > > > index 30a441506f61c..d5f5ca7cd6a56 100644 > > > > --- a/drivers/i3c/Kconfig > > > > +++ b/drivers/i3c/Kconfig > > > > @@ -22,3 +22,29 @@ menuconfig I3C > > > > if I3C > > > > source "drivers/i3c/master/Kconfig" > > > > endif # I3C > > > > + > > > > +config I3C_SLAVE > > > > > > It doesn't look like you follow Kernel naming convention (see coding style). > > > > I checked I3C spec. It use words 'target'. > > Is it okay using I3C_TARGET? > > Why wouldn't it be? Sorry, that was snotty of me, long day of driving, my apologies. Yes, please use "target" and the other terminology to reflect this, and not the ones you used in your driver as it is against the current kernel coding style rules. thanks, greg k-h
This patch introduces support for I3C slave mode, which is referenced with a PCIe Endpoint system. It also establishes a configuration framework (configfs) for the I3C slave controller driver and the I3C slave function driver Typic usage as The user can configure the i3c-slave-tty device using configfs entry. In order to change the vendorid, the following commands can be used # echo 0x011b > functions/tty/func1/vendor_id # echo 0x1000 > functions/tty/func1/part_id # echo 0x6 > functions/tty/t/bcr Binding i3c-slave-tty Device to slave Controller ------------------------------------------------ In order for the slave function device to be useful, it has to be bound to a I3C slave controller driver. Use the configfs to bind the function device to one of the controller driver present in the system:: # ln -s functions/pci_epf_test/func1 controllers/44330000.i3c-slave/ Host side: cat /dev/ttyI3C0 Slave side: echo abc >/dev/ttyI3C0 Master side patch: https://lore.kernel.org/imx/20231018211111.3437929-1-Frank.Li@nxp.com/T/#u Frank Li (5): i3c: add slave mode support dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-slave i3c: slave: add svc slave controller support i3c: slave: func: add tty driver Documentation: i3c: Add I3C slave mode controller and function .../bindings/i3c/silvaco,i3c-master.yaml | 8 +- Documentation/driver-api/i3c/index.rst | 1 + .../driver-api/i3c/slave/i3c-slave-cfs.rst | 109 +++ .../driver-api/i3c/slave/i3c-slave.rst | 189 +++++ .../driver-api/i3c/slave/i3c-tty-function.rst | 103 +++ .../driver-api/i3c/slave/i3c-tty-howto.rst | 109 +++ Documentation/driver-api/i3c/slave/index.rst | 13 + drivers/i3c/Kconfig | 30 + drivers/i3c/Makefile | 4 + drivers/i3c/func/Kconfig | 9 + drivers/i3c/func/Makefile | 3 + drivers/i3c/func/tty.c | 548 ++++++++++++ drivers/i3c/i3c-cfs.c | 389 +++++++++ drivers/i3c/slave.c | 453 ++++++++++ drivers/i3c/slave/Kconfig | 9 + drivers/i3c/slave/Makefile | 4 + drivers/i3c/slave/svc-i3c-slave.c | 795 ++++++++++++++++++ include/linux/i3c/slave.h | 503 +++++++++++ 18 files changed, 3276 insertions(+), 3 deletions(-) create mode 100644 Documentation/driver-api/i3c/slave/i3c-slave-cfs.rst create mode 100644 Documentation/driver-api/i3c/slave/i3c-slave.rst create mode 100644 Documentation/driver-api/i3c/slave/i3c-tty-function.rst create mode 100644 Documentation/driver-api/i3c/slave/i3c-tty-howto.rst create mode 100644 Documentation/driver-api/i3c/slave/index.rst create mode 100644 drivers/i3c/func/Kconfig create mode 100644 drivers/i3c/func/Makefile create mode 100644 drivers/i3c/func/tty.c create mode 100644 drivers/i3c/i3c-cfs.c create mode 100644 drivers/i3c/slave.c create mode 100644 drivers/i3c/slave/Kconfig create mode 100644 drivers/i3c/slave/Makefile create mode 100644 drivers/i3c/slave/svc-i3c-slave.c create mode 100644 include/linux/i3c/slave.h