From patchwork Tue May 20 12:52:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 30428 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f71.google.com (mail-yh0-f71.google.com [209.85.213.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1707120671 for ; Tue, 20 May 2014 12:53:43 +0000 (UTC) Received: by mail-yh0-f71.google.com with SMTP id 29sf1360170yhl.10 for ; Tue, 20 May 2014 05:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=EdfdjXHRNW5Oed3DllitMvqfvl3RVFpWGekwZIxSMPs=; b=LJeDWY19Uh+NvW0Efqkv+c70L8KVUV2Aq3ofe9XUpRNHIQPho0rsErdmMjDydh2MD3 EM/1Lrk0r7JkTU+7Z2LLzXKu4HqScO7AYNLjbhWcEWcBG06USRxQizZJqZwpUxDFwVFc LNUqoaxixYerikhM03JLYVcHFtgP9nfiPRIKpfU3vZ+dHaoDL/eNfRdpb7NdcxvXzdBj G4bZ2l0P4AvD6DGLjqgY+/ZfXVe9vwoN154NshX62QbJO0lyR4wXnE/Z/ng40cwn4l2c QaVLiX4NsbQXm8AVeIv6HgnKJ9eUQFpM4NKWxEx8SC/0Q9Qfo7ZZz1YVd08qN3Q24elQ jcYQ== X-Gm-Message-State: ALoCoQnTR33dqWKAbiNamMEZn+g9hGPKNilz20T3nU7UzWAmfDSL4Zi3ionQ2yPUpYWUhr0cyaiU X-Received: by 10.58.69.78 with SMTP id c14mr448803veu.41.1400590423797; Tue, 20 May 2014 05:53:43 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.29.225 with SMTP id b88ls263286qgb.32.gmail; Tue, 20 May 2014 05:53:43 -0700 (PDT) X-Received: by 10.58.219.166 with SMTP id pp6mr36699587vec.1.1400590423679; Tue, 20 May 2014 05:53:43 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id c8si4139661veh.85.2014.05.20.05.53.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 20 May 2014 05:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.169 as permitted sender) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id jx11so517952veb.14 for ; Tue, 20 May 2014 05:53:43 -0700 (PDT) X-Received: by 10.220.92.135 with SMTP id r7mr3476668vcm.11.1400590423343; Tue, 20 May 2014 05:53:43 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp28066vcb; Tue, 20 May 2014 05:53:42 -0700 (PDT) X-Received: by 10.66.240.130 with SMTP id wa2mr50735881pac.73.1400590422479; Tue, 20 May 2014 05:53:42 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ui2si24516248pac.86.2014.05.20.05.53.41; Tue, 20 May 2014 05:53:41 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464AbaETMxe (ORCPT + 27 others); Tue, 20 May 2014 08:53:34 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:48636 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbaETMwo (ORCPT ); Tue, 20 May 2014 08:52:44 -0400 Received: by mail-ie0-f177.google.com with SMTP id y20so372965ier.36 for ; Tue, 20 May 2014 05:52:44 -0700 (PDT) X-Received: by 10.42.84.211 with SMTP id n19mr1261505icl.30.1400590364178; Tue, 20 May 2014 05:52:44 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id kw1sm28775309igb.4.2014.05.20.05.52.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 May 2014 05:52:43 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] clk: bcm281xx: add bus clock support Date: Tue, 20 May 2014 07:52:40 -0500 Message-Id: <1400590362-11177-4-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1400590362-11177-1-git-send-email-elder@linaro.org> References: <1400590362-11177-1-git-send-email-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: elder@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add bus clock support. A bus clock has a subset of the components present in a peripheral clock (again, all optional): a gate; CCU policy management bits; and if needed, bits to control hysteresis. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona-setup.c | 96 ++++++++++++++++++++++++++++++++++++++-- drivers/clk/bcm/clk-kona.c | 58 ++++++++++++++++++++++++ drivers/clk/bcm/clk-kona.h | 8 ++++ 3 files changed, 159 insertions(+), 3 deletions(-) diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c index fcce22c..60d18f0 100644 --- a/drivers/clk/bcm/clk-kona-setup.c +++ b/drivers/clk/bcm/clk-kona-setup.c @@ -76,6 +76,56 @@ static bool clk_requires_trigger(struct kona_clk *bcm_clk) return divider_exists(div) && !divider_is_fixed(div); } +static bool bus_clk_data_offsets_valid(struct kona_clk *bcm_clk) +{ + struct bus_clk_data *bus; + struct bcm_clk_policy *policy; + struct bcm_clk_gate *gate; + struct bcm_clk_hyst *hyst; + const char *name; + u32 limit; + + BUG_ON(bcm_clk->type != bcm_clk_bus); + bus = bcm_clk->u.bus; + name = bcm_clk->init_data.name; + + limit = bcm_clk->ccu->range - sizeof(u32); + limit = round_down(limit, sizeof(u32)); + + policy = &bus->policy; + if (policy_exists(policy)) { + if (policy->offset > limit) { + pr_err("%s: bad policy offset for %s (%u > %u)\n", + __func__, name, policy->offset, limit); + return false; + } + } + + gate = &bus->gate; + hyst = &bus->hyst; + if (gate_exists(gate)) { + if (gate->offset > limit) { + pr_err("%s: bad gate offset for %s (%u > %u)\n", + __func__, name, gate->offset, limit); + return false; + } + if (hyst_exists(hyst)) { + if (hyst->offset > limit) { + pr_err("%s: bad hysteresis offset for %s " + "(%u > %u)\n", __func__, + name, hyst->offset, limit); + return false; + } + } + } else if (hyst_exists(hyst)) { + pr_err("%s: hysteresis but no gate for %s\n", __func__, name); + return false; + } + + + return true; +} + static bool peri_clk_data_offsets_valid(struct kona_clk *bcm_clk) { struct peri_clk_data *peri; @@ -86,15 +136,13 @@ static bool peri_clk_data_offsets_valid(struct kona_clk *bcm_clk) struct bcm_clk_sel *sel; struct bcm_clk_trig *trig; const char *name; - u32 range; u32 limit; BUG_ON(bcm_clk->type != bcm_clk_peri); peri = bcm_clk->u.peri; name = bcm_clk->init_data.name; - range = bcm_clk->ccu->range; - limit = range - sizeof(u32); + limit = bcm_clk->ccu->range - sizeof(u32); limit = round_down(limit, sizeof(u32)); policy = &peri->policy; @@ -397,6 +445,23 @@ static bool trig_valid(struct bcm_clk_trig *trig, const char *field_name, return bit_posn_valid(trig->bit, field_name, clock_name); } +/* Determine whether the set of bus clock registers are valid. */ +static bool +bus_clk_data_valid(struct kona_clk *bcm_clk) +{ + struct bcm_clk_gate *gate; + + BUG_ON(bcm_clk->type != bcm_clk_bus); + if (!bus_clk_data_offsets_valid(bcm_clk)) + return false; + + gate = &bcm_clk->u.bus->gate; + if (!gate_exists(gate)) + return true; + + return gate_valid(gate, "gate", bcm_clk->init_data.name); +} + /* Determine whether the set of peripheral clock registers are valid. */ static bool peri_clk_data_valid(struct kona_clk *bcm_clk) @@ -494,6 +559,10 @@ peri_clk_data_valid(struct kona_clk *bcm_clk) static bool kona_clk_valid(struct kona_clk *bcm_clk) { switch (bcm_clk->type) { + case bcm_clk_bus: + if (!bus_clk_data_valid(bcm_clk)) + return false; + break; case bcm_clk_peri: if (!peri_clk_data_valid(bcm_clk)) return false; @@ -664,6 +733,20 @@ static void clk_sel_teardown(struct bcm_clk_sel *sel, init_data->parent_names = NULL; } +static void bus_clk_teardown(struct bus_clk_data *data, + struct clk_init_data *init_data) +{ + /* Nothing to do */ +} + +static int +bus_clk_setup(struct bus_clk_data *data, struct clk_init_data *init_data) +{ + init_data->flags = CLK_IGNORE_UNUSED; + + return 0; +} + static void peri_clk_teardown(struct peri_clk_data *data, struct clk_init_data *init_data) { @@ -690,6 +773,9 @@ static void bcm_clk_teardown(struct kona_clk *bcm_clk) /* clkdev_remove(&bcm_clk->cl); */ switch (bcm_clk->type) { + case bcm_clk_bus: + bus_clk_teardown(bcm_clk->u.data, &bcm_clk->init_data); + break; case bcm_clk_peri: peri_clk_teardown(bcm_clk->u.data, &bcm_clk->init_data); break; @@ -726,6 +812,10 @@ struct clk *kona_clk_setup(struct kona_clk *bcm_clk) struct clk *clk = NULL; switch (bcm_clk->type) { + case bcm_clk_bus: + if (bus_clk_setup(bcm_clk->u.data, init_data)) + return NULL; + break; case bcm_clk_peri: if (peri_clk_setup(bcm_clk->u.data, init_data)) return NULL; diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index fd070d6..b3d556c 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -986,6 +986,36 @@ static int selector_write(struct ccu_data *ccu, struct bcm_clk_gate *gate, /* Clock operations */ +static int kona_bus_clk_enable(struct clk_hw *hw) +{ + struct kona_clk *bcm_clk = to_kona_clk(hw); + struct bcm_clk_gate *gate = &bcm_clk->u.bus->gate; + + return clk_gate(bcm_clk->ccu, bcm_clk->init_data.name, gate, true); +} + +static void kona_bus_clk_disable(struct clk_hw *hw) +{ + struct kona_clk *bcm_clk = to_kona_clk(hw); + struct bcm_clk_gate *gate = &bcm_clk->u.bus->gate; + + (void)clk_gate(bcm_clk->ccu, bcm_clk->init_data.name, gate, false); +} + +static int kona_bus_clk_is_enabled(struct clk_hw *hw) +{ + struct kona_clk *bcm_clk = to_kona_clk(hw); + struct bcm_clk_gate *gate = &bcm_clk->u.bus->gate; + + return is_clk_gate_enabled(bcm_clk->ccu, gate) ? 1 : 0; +} + +struct clk_ops kona_bus_clk_ops = { + .enable = kona_bus_clk_enable, + .disable = kona_bus_clk_disable, + .is_enabled = kona_bus_clk_is_enabled, +}; + static int kona_peri_clk_enable(struct clk_hw *hw) { struct kona_clk *bcm_clk = to_kona_clk(hw); @@ -1144,6 +1174,31 @@ struct clk_ops kona_peri_clk_ops = { .set_rate = kona_peri_clk_set_rate, }; +/* Put a bus clock into its initial state */ +static bool __bus_clk_init(struct kona_clk *bcm_clk) +{ + struct ccu_data *ccu = bcm_clk->ccu; + struct bus_clk_data *bus = bcm_clk->u.bus; + const char *name = bcm_clk->init_data.name; + + BUG_ON(bcm_clk->type != bcm_clk_bus); + + if (!policy_init(ccu, &bus->policy)) { + pr_err("%s: error initializing policy for %s\n", + __func__, name); + return false; + } + if (!gate_init(ccu, &bus->gate)) { + pr_err("%s: error initializing gate for %s\n", __func__, name); + return false; + } + if (!hyst_init(ccu, &bus->hyst)) { + pr_err("%s: error initializing hyst for %s\n", __func__, name); + return false; + } + return true; +} + /* Put a peripheral clock into its initial state */ static bool __peri_clk_init(struct kona_clk *bcm_clk) { @@ -1248,6 +1303,9 @@ static bool __kona_clk_init(struct kona_clk *bcm_clk) return false; switch (bcm_clk->type) { + case bcm_clk_bus: + ret = __bus_clk_init(bcm_clk); + break; case bcm_clk_peri: ret = __peri_clk_init(bcm_clk); break; diff --git a/drivers/clk/bcm/clk-kona.h b/drivers/clk/bcm/clk-kona.h index a5b61e0..345d15f 100644 --- a/drivers/clk/bcm/clk-kona.h +++ b/drivers/clk/bcm/clk-kona.h @@ -389,6 +389,12 @@ struct bcm_clk_trig { .flags = FLAG(TRIG, EXISTS), \ } +struct bus_clk_data { + struct bcm_clk_policy policy; + struct bcm_clk_gate gate; + struct bcm_clk_hyst hyst; +}; + struct peri_clk_data { struct bcm_clk_policy policy; struct bcm_clk_gate gate; @@ -416,6 +422,7 @@ struct kona_clk { } p; union { void *data; + struct bus_clk_data *bus; struct peri_clk_data *peri; } u; }; @@ -520,6 +527,7 @@ struct ccu_data { /* Exported globals */ +extern struct clk_ops kona_bus_clk_ops; extern struct clk_ops kona_peri_clk_ops; /* Externally visible functions */