From patchwork Mon Jan 30 10:02:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 92803 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1358076qgi; Mon, 30 Jan 2017 02:03:21 -0800 (PST) X-Received: by 10.84.231.205 with SMTP id g13mr30754044pln.118.1485770601557; Mon, 30 Jan 2017 02:03:21 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w72si12181049pfa.220.2017.01.30.02.03.21; Mon, 30 Jan 2017 02:03:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbdA3KDJ (ORCPT + 7 others); Mon, 30 Jan 2017 05:03:09 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38873 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdA3KCb (ORCPT ); Mon, 30 Jan 2017 05:02:31 -0500 Received: by mail-wm0-f45.google.com with SMTP id r141so25580144wmg.1 for ; Mon, 30 Jan 2017 02:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bgb7yRqFaON2/iF5n/N2FPgGiMoQcpejrt+SCmnNAx0=; b=hflWpBpd0/hNkglhfQexSClwYanNcMWuPwnplEdEhqWphbL9xlSxj+6UydK6oJQ9lE FUm4l+64rPPbIGxpIRmlvREEyNq/AM1QJLOxXtr1HbINhyfRIu2gldizybYbzgBQ/Z4J B2WGWvN40z5eXNyg1jnrAY8Nn2DHA/8mJjdeYoqx5P4V0jmlxTldq/g+YPQ06WKQ8FOu q6N1L3pTGpsl/av3rM2Oddzkq5OfUHRS4PHXhgweljH1uGdWwB27dBfD4mp/at+8pimH NKRCqrQoKB7S/TuMAZfw8jSJ92CGBdJj4um2p38UsKhVk7eonGwDIFS02b+br5R6Y+WU JcIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bgb7yRqFaON2/iF5n/N2FPgGiMoQcpejrt+SCmnNAx0=; b=d/olSPzlSDg7WB9KM8XJztIbxEX4gQT37jqCMWDCVDyyirSidHZCA1Wmh7NoThUh/p 1cvvgUcAB6ox6E4do1U/s9L3vYG5JLdjkEOxUpB/D1hK+ymgF3wd2k4xLNl4K2/jqln9 jhUIEhR1X7u9mIWF8iSffdFZs88iddeaeP1dkTUx8cNVyMsM1ptc91XodOyFYIULFvkf 1CV5Cz8kySDC3GjE/dafUz68KnkjrzyFCTL+eCazuD3mEEuxhjgeOqI0u8J/bdIJTKHY h4V0yTv1IJnnsTHBPMI4CYblss8+IZSFZipEXWm2L0Z+3WUcEo3KUYXQedGHK6JtZv3/ 0oPw== X-Gm-Message-State: AIkVDXJyAyX1HBHMAiKdz0M/4iRHgfqN9NOloBxU/y5EBGXMxU7pmqNe2AK0y3oWHTLY8VWy X-Received: by 10.28.61.136 with SMTP id k130mr12407958wma.128.1485770544937; Mon, 30 Jan 2017 02:02:24 -0800 (PST) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id j18sm21939536wrb.33.2017.01.30.02.02.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Jan 2017 02:02:24 -0800 (PST) From: Bartosz Golaszewski To: Kevin Hilman , Sekhar Nori , Patrick Titiano , Michael Turquette , Tejun Heo , Rob Herring , Mark Rutland , Russell King , David Lechner Cc: linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski Subject: [PATCH v7 09/14] sata: ahci: export ahci_do_hardreset() locally Date: Mon, 30 Jan 2017 11:02:06 +0100 Message-Id: <1485770531-6772-10-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1485770531-6772-1-git-send-email-bgolaszewski@baylibre.com> References: <1485770531-6772-1-git-send-email-bgolaszewski@baylibre.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org We need a way to retrieve the information about the online state of the link in the ahci-da850 driver. Create a new function: ahci_do_hardreset() which is called from ahci_hardreset() for backwards compatibility, but has an additional argument: 'online' - which can be used to check if the link is online after this function returns. The new routine will be used in the ahci-da850 driver to avoid code duplication when implementing a workaround for tha da850 SATA controller quirk/instability. Signed-off-by: Bartosz Golaszewski Acked-by: Tejun Heo --- drivers/ata/ahci.h | 3 +++ drivers/ata/libahci.c | 18 +++++++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-) -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h index 0cc08f8..5db6ab2 100644 --- a/drivers/ata/ahci.h +++ b/drivers/ata/ahci.h @@ -398,6 +398,9 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, int pmp, unsigned long deadline, int (*check_ready)(struct ata_link *link)); +int ahci_do_hardreset(struct ata_link *link, unsigned int *class, + unsigned long deadline, bool *online); + unsigned int ahci_qc_issue(struct ata_queued_cmd *qc); int ahci_stop_engine(struct ata_port *ap); void ahci_start_fis_rx(struct ata_port *ap); diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index ee7db31..3159f9e 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1519,8 +1519,8 @@ static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class, return rc; } -static int ahci_hardreset(struct ata_link *link, unsigned int *class, - unsigned long deadline) +int ahci_do_hardreset(struct ata_link *link, unsigned int *class, + unsigned long deadline, bool *online) { const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); struct ata_port *ap = link->ap; @@ -1528,7 +1528,6 @@ static int ahci_hardreset(struct ata_link *link, unsigned int *class, struct ahci_host_priv *hpriv = ap->host->private_data; u8 *d2h_fis = pp->rx_fis + RX_FIS_D2H_REG; struct ata_taskfile tf; - bool online; int rc; DPRINTK("ENTER\n"); @@ -1540,17 +1539,26 @@ static int ahci_hardreset(struct ata_link *link, unsigned int *class, tf.command = ATA_BUSY; ata_tf_to_fis(&tf, 0, 0, d2h_fis); - rc = sata_link_hardreset(link, timing, deadline, &online, + rc = sata_link_hardreset(link, timing, deadline, online, ahci_check_ready); hpriv->start_engine(ap); - if (online) + if (*online) *class = ahci_dev_classify(ap); DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); return rc; } +EXPORT_SYMBOL_GPL(ahci_do_hardreset); + +static int ahci_hardreset(struct ata_link *link, unsigned int *class, + unsigned long deadline) +{ + bool online; + + return ahci_do_hardreset(link, class, deadline, &online); +} static void ahci_postreset(struct ata_link *link, unsigned int *class) {