From patchwork Thu Apr 6 15:01:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 96991 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp773544qgd; Thu, 6 Apr 2017 08:02:47 -0700 (PDT) X-Received: by 10.84.218.138 with SMTP id r10mr43776816pli.165.1491490967460; Thu, 06 Apr 2017 08:02:47 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k5si2110660pln.108.2017.04.06.08.02.47; Thu, 06 Apr 2017 08:02:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935429AbdDFPCq (ORCPT + 7 others); Thu, 6 Apr 2017 11:02:46 -0400 Received: from mail.kernel.org ([198.145.29.136]:48510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935259AbdDFPCq (ORCPT ); Thu, 6 Apr 2017 11:02:46 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A68E6202F2; Thu, 6 Apr 2017 15:02:44 +0000 (UTC) Received: from localhost.localdomain (li411-102.members.linode.com [106.187.91.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70586200E7; Thu, 6 Apr 2017 15:02:36 +0000 (UTC) From: Shawn Guo To: dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org, Rob Herring , Sean Paul , Daniel Vetter , Baoyou Xie , Xin Zhou , Jun Nie , Shawn Guo Subject: [PATCH v2 1/4] drm: zte: do not enable clock auto-gating by default Date: Thu, 6 Apr 2017 23:01:07 +0800 Message-Id: <1491490870-6330-2-git-send-email-shawnguo@kernel.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1491490870-6330-1-git-send-email-shawnguo@kernel.org> References: <1491490870-6330-1-git-send-email-shawnguo@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Shawn Guo Some VOU modules do not work well with clock auto-gating. For example, VGA I2C bus will fail to read EDID data from monitor. Let's not enable this feature by default, and leave it to the possible future low-power optimization. Signed-off-by: Shawn Guo Reviewed-by: Sean Paul Acked-by: Daniel Vetter --- drivers/gpu/drm/zte/zx_vou.c | 3 --- 1 file changed, 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c index cf92d675feaa..2a2d90bd9425 100644 --- a/drivers/gpu/drm/zte/zx_vou.c +++ b/drivers/gpu/drm/zte/zx_vou.c @@ -720,9 +720,6 @@ static void vou_hw_init(struct zx_vou_hw *vou) /* Release reset for all VOU modules */ zx_writel(vou->vouctl + VOU_SOFT_RST, ~0); - /* Enable clock auto-gating for all VOU modules */ - zx_writel(vou->vouctl + VOU_CLK_REQEN, ~0); - /* Enable all VOU module clocks */ zx_writel(vou->vouctl + VOU_CLK_EN, ~0);