| Message ID | 1523956215-28154-7-git-send-email-t-kristo@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: DT overlay support infra + some data | expand |
On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@ti.com> wrote: > The AM57xx-evm is an overlay on top of beagle-x15 board. This contains > a display extension macro, and a few extra peripherals. Two versions > of the evm are supported, the base evm and the latest rev A3 evm. A > common overlay file is used for both boards. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- > arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ > arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ > arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ > 3 files changed, 197 insertions(+) > create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-common.dtso > create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso > create mode 100644 arch/arm/boot/dts/ti/am57xx-evm.dtso > > diff --git a/arch/arm/boot/dts/ti/am57xx-evm-common.dtso b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso > new file mode 100644 > index 0000000..68c3937 > --- /dev/null > +++ b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso > @@ -0,0 +1,175 @@ > +/dts-v1/; > +/plugin/; > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > + > +/ { > + fragment@101 { > + target-path = "/"; > + > + __overlay__ { It would be good to have "scripts/dtc: Correct overlay syntactic sugar for generating target-path fragments" in the kernel's copy of dtc, so this section can be converted to sugar syntax, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18/04/18 17:36, Geert Uytterhoeven wrote: > On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@ti.com> wrote: >> The AM57xx-evm is an overlay on top of beagle-x15 board. This contains >> a display extension macro, and a few extra peripherals. Two versions >> of the evm are supported, the base evm and the latest rev A3 evm. A >> common overlay file is used for both boards. >> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ >> arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ >> arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ >> 3 files changed, 197 insertions(+) >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm.dtso >> >> diff --git a/arch/arm/boot/dts/ti/am57xx-evm-common.dtso b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> new file mode 100644 >> index 0000000..68c3937 >> --- /dev/null >> +++ b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> @@ -0,0 +1,175 @@ >> +/dts-v1/; >> +/plugin/; >> +#include <dt-bindings/interrupt-controller/irq.h> >> +#include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/input/input.h> >> + >> +/ { >> + fragment@101 { >> + target-path = "/"; >> + >> + __overlay__ { > > It would be good to have "scripts/dtc: Correct overlay syntactic sugar for > generating target-path fragments" in the kernel's copy of dtc, so this > section can be converted to sugar syntax, too. Ah yea, that seems to be a recent patch I've missed, but yes, if that fixes this limitation, it would be a great addition. -Tero > > > Gr{oetje,eeting}s, > > Geert > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
As already requested, can you *all* please use my linux@armlinux.org.uk address for this stuff please, and not rmk@armlinux.org.uk - it's screwing up my mailboxes. Thanks. On Wed, Apr 18, 2018 at 10:12:08PM +0300, Tero Kristo wrote: > On 18/04/18 17:36, Geert Uytterhoeven wrote: > >On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@ti.com> wrote: > >>The AM57xx-evm is an overlay on top of beagle-x15 board. This contains > >>a display extension macro, and a few extra peripherals. Two versions > >>of the evm are supported, the base evm and the latest rev A3 evm. A > >>common overlay file is used for both boards. > >> > >>Signed-off-by: Tero Kristo <t-kristo@ti.com> > >>--- > >> arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ > >> arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ > >> arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ > >> 3 files changed, 197 insertions(+) > >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-common.dtso > >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso > >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm.dtso > >> > >>diff --git a/arch/arm/boot/dts/ti/am57xx-evm-common.dtso b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso > >>new file mode 100644 > >>index 0000000..68c3937 > >>--- /dev/null > >>+++ b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso > >>@@ -0,0 +1,175 @@ > >>+/dts-v1/; > >>+/plugin/; > >>+#include <dt-bindings/interrupt-controller/irq.h> > >>+#include <dt-bindings/gpio/gpio.h> > >>+#include <dt-bindings/input/input.h> > >>+ > >>+/ { > >>+ fragment@101 { > >>+ target-path = "/"; > >>+ > >>+ __overlay__ { > > > >It would be good to have "scripts/dtc: Correct overlay syntactic sugar for > >generating target-path fragments" in the kernel's copy of dtc, so this > >section can be converted to sugar syntax, too. > > Ah yea, that seems to be a recent patch I've missed, but yes, if that fixes > this limitation, it would be a great addition. > > -Tero > > > > > > >Gr{oetje,eeting}s, > > > > Geert > > > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- Russell King ARM architecture Linux Kernel maintainer -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 18, 2018 at 9:36 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@ti.com> wrote: >> The AM57xx-evm is an overlay on top of beagle-x15 board. This contains >> a display extension macro, and a few extra peripherals. Two versions >> of the evm are supported, the base evm and the latest rev A3 evm. A >> common overlay file is used for both boards. >> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ >> arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ >> arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ >> 3 files changed, 197 insertions(+) >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso >> create mode 100644 arch/arm/boot/dts/ti/am57xx-evm.dtso >> >> diff --git a/arch/arm/boot/dts/ti/am57xx-evm-common.dtso b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> new file mode 100644 >> index 0000000..68c3937 >> --- /dev/null >> +++ b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso >> @@ -0,0 +1,175 @@ >> +/dts-v1/; >> +/plugin/; >> +#include <dt-bindings/interrupt-controller/irq.h> >> +#include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/input/input.h> >> + >> +/ { >> + fragment@101 { >> + target-path = "/"; >> + >> + __overlay__ { > > It would be good to have "scripts/dtc: Correct overlay syntactic sugar for > generating target-path fragments" in the kernel's copy of dtc, so this > section can be converted to sugar syntax, too. I'm planning to do a dtc update for 4.18 too. New warnings coming too. :) Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 17, 2018 at 4:10 AM, Tero Kristo <t-kristo@ti.com> wrote: > The AM57xx-evm is an overlay on top of beagle-x15 board. This contains > a display extension macro, and a few extra peripherals. Two versions > of the evm are supported, the base evm and the latest rev A3 evm. A > common overlay file is used for both boards. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > --- > arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ Why do this as an overlay? To what level is an AM57xx-evm functional using a beagle-x15 dtb? > arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ > arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ I think I'd structure this as just the A3 is an overlay. Applying it will override everything in am57xx-evm.dtso, so what's the point to making users of both board variations apply an overlay. Plus, you could have only known the differences in the board revisions after you had both boards. That wouldn't work if you developed this as new boards appear. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19/04/18 03:19, Rob Herring wrote: > On Tue, Apr 17, 2018 at 4:10 AM, Tero Kristo <t-kristo@ti.com> wrote: >> The AM57xx-evm is an overlay on top of beagle-x15 board. This contains >> a display extension macro, and a few extra peripherals. Two versions >> of the evm are supported, the base evm and the latest rev A3 evm. A >> common overlay file is used for both boards. >> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ > > Why do this as an overlay? To what level is an AM57xx-evm functional > using a beagle-x15 dtb? Basically, am57xx-evm is just a beagle-x15 with an extension board physically plugged into it. If you don't add the am57xx-evm overlay, display (+ WLAN + some gpios) obviously don't work, but rest of the functionality does. If you have an am57xx-evm, you can also unplug the extension board to get a plain beagle-x15 board as I did, I don't typically care about things like display / WLAN in my work. > >> arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ >> arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ > > I think I'd structure this as just the A3 is an overlay. Applying it > will override everything in am57xx-evm.dtso, so what's the point to > making users of both board variations apply an overlay. Plus, you > could have only known the differences in the board revisions after you > had both boards. That wouldn't work if you developed this as new > boards appear. Well, beagle-x15 is still the base board for both, and different revisions of those also. The changes are relatively minor, but they are there. But yes, different hierarchies for these could be applied. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 19, 2018 at 1:49 AM, Tero Kristo <t-kristo@ti.com> wrote: > On 19/04/18 03:19, Rob Herring wrote: >> >> On Tue, Apr 17, 2018 at 4:10 AM, Tero Kristo <t-kristo@ti.com> wrote: >>> >>> The AM57xx-evm is an overlay on top of beagle-x15 board. This contains >>> a display extension macro, and a few extra peripherals. Two versions >>> of the evm are supported, the base evm and the latest rev A3 evm. A >>> common overlay file is used for both boards. >>> >>> Signed-off-by: Tero Kristo <t-kristo@ti.com> >>> --- >>> arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 >>> ++++++++++++++++++++++++++++ >> >> >> Why do this as an overlay? To what level is an AM57xx-evm functional >> using a beagle-x15 dtb? > > > Basically, am57xx-evm is just a beagle-x15 with an extension board > physically plugged into it. If you don't add the am57xx-evm overlay, display > (+ WLAN + some gpios) obviously don't work, but rest of the functionality > does. > > If you have an am57xx-evm, you can also unplug the extension board to get a > plain beagle-x15 board as I did, I don't typically care about things like > display / WLAN in my work. Okay, makes sense, but the naming convention doesn't really convey these details. I guess users of the boards would understand this. >>> arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ >>> arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ >> >> >> I think I'd structure this as just the A3 is an overlay. Applying it >> will override everything in am57xx-evm.dtso, so what's the point to >> making users of both board variations apply an overlay. Plus, you >> could have only known the differences in the board revisions after you >> had both boards. That wouldn't work if you developed this as new >> boards appear. > > > Well, beagle-x15 is still the base board for both, and different revisions > of those also. The changes are relatively minor, but they are there. But > yes, different hierarchies for these could be applied. My point is that if you have 2 revisions of a given board, at some point in time there was only 1 revision of that board. So you have a dtb for that revision. Then a new revision comes out. You should not be refactoring the existing dtbs based on what changed in the new revision such that you have the common bits, rev 1 overlay and rev 2 overlay. Instead, make a rev 1 to rev 2 overlay. Now if you have 2 different revisions in parallel that's a different story. For example, if the beagle-x15 is stuffed differently for use with the EVM vs. standalone. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Russell, On Wed, Apr 18, 2018 at 9:15 PM, Russell King <rmk@armlinux.org.uk> wrote: > As already requested, can you *all* please use my linux@armlinux.org.uk > address for this stuff please, and not rmk@armlinux.org.uk - it's > screwing up my mailboxes. Thanks. I have no idea when you request that (sorry if I missed it), but your rmk address is all over the Linux kernel sources. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/ti/am57xx-evm-common.dtso b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso new file mode 100644 index 0000000..68c3937 --- /dev/null +++ b/arch/arm/boot/dts/ti/am57xx-evm-common.dtso @@ -0,0 +1,175 @@ +/dts-v1/; +/plugin/; +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> + +/ { + fragment@101 { + target-path = "/"; + + __overlay__ { + compatible = "ti,am5728-evm", "ti,am572x-beagle-x15", "ti,am5728", "ti,dra742", "ti,dra74", "ti,dra7"; + model = "TI AM5728 EVM"; + + aliases { + display0 = "/display"; + display1 = "/connector"; + }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>; + autorepeat; + + USER1 { + gpios = <&gpio2 23 GPIO_ACTIVE_LOW>; + label = "Up"; + linux,code = <KEY_UP>; + }; + + USER2 { + gpios = <&gpio2 25 GPIO_ACTIVE_LOW>; + label = "Down"; + linux,code = <KEY_DOWN>; + }; + + USER3 { + gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; + label = "Left"; + linux,code = <KEY_LEFT>; + }; + + USER4 { + gpios = <&gpio2 24 GPIO_ACTIVE_LOW>; + label = "Right"; + linux,code = <KEY_RIGHT>; + }; + + USER5 { + gpios = <&gpio2 20 GPIO_ACTIVE_LOW>; + label = "Home"; + linux,code = <KEY_HOME>; + }; + }; + + lcd0: display { + compatible = "osddisplays,osd070t1718-19ts", "panel-dpi"; + backlight = <&lcd_bl>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; + label = "lcd"; + + panel-timing { + clock-frequency = <33000000>; + de-active = <1>; + hactive = <800>; + hback-porch = <16>; + hfront-porch = <210>; + hsync-active = <0>; + hsync-len = <30>; + pixelclk-active = <1>; + vactive = <480>; + vback-porch = <10>; + vfront-porch = <22>; + vsync-active = <0>; + vsync-len = <13>; + }; + + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; + + lcd_bl: backlight { + compatible = "pwm-backlight"; + brightness-levels = <0 243 245 247 249 251 252 253 255>; + default-brightness-level = <8>; + pwms = <&ehrpwm1 0 50000 0>; + }; + + com_3v6: fixedregulator-com_3v6 { + compatible = "regulator-fixed"; + regulator-name = "com_3v6"; + regulator-min-microvolt = <3600000>; + regulator-max-microvolt = <3600000>; + vin-supply = <&evm_5v0>; + regulator-always-on; + regulator-boot-on; + }; + + vmmcwl_fixed: fixedregulator-mmcwl { + compatible = "regulator-fixed"; + regulator-name = "vmmcwl_fixed"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + }; + }; +}; + +&ehrpwm1 { + status = "okay"; +}; + +&epwmss1 { + status = "okay"; +}; + +&i2c5 { + clock-frequency = <400000>; + status = "okay"; + + pixcir_ts@5c { + compatible = "pixcir,pixcir_tangoc"; + attb-gpio = <&gpio2 4 GPIO_ACTIVE_HIGH>; + interrupt-parent = <&gpio2>; + interrupts = <4 0>; + reg = <0x5c>; + reset-gpio = <&gpio2 6 GPIO_ACTIVE_HIGH>; + touchscreen-size-x = <1024>; + touchscreen-size-y = <600>; + }; +}; + +&uart8 { + status = "okay"; +}; + +&dss { + ports { + #address-cells = <1>; + #size-cells = <0>; + + port { + reg = <0>; + + dpi_out: endpoint { + data-lines = <24>; + remote-endpoint = <&lcd_in>; + }; + }; + }; +}; + +&mmc3 { + status = "okay"; + vmmc-supply = <&com_3v6>; + vqmmc-supply = <&vmmcwl_fixed>; + bus-width = <4>; + cap-power-off-card; + keep-power-in-suspend; + non-removable; + #address-cells = <1>; + #size-cells = <0>; + wlcore: wlcore@2 { + compatible = "ti,wl1835"; + reg = <2>; + interrupt-parent = <&gpio5>; + interrupts = <7 IRQ_TYPE_EDGE_RISING>; + }; +}; diff --git a/arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso b/arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso new file mode 100644 index 0000000..17e778f --- /dev/null +++ b/arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso @@ -0,0 +1,11 @@ +/dts-v1/; +/plugin/; + +&mmc3 { + pinctrl-names = "default", "hs", "sdr12", "sdr25", "sdr50"; + pinctrl-0 = <&mmc3_pins_default>; + pinctrl-1 = <&mmc3_pins_hs>; + pinctrl-2 = <&mmc3_pins_sdr12>; + pinctrl-3 = <&mmc3_pins_sdr25>; + pinctrl-4 = <&mmc3_pins_sdr50 &mmc3_iodelay_manual1_rev20_conf>; +}; diff --git a/arch/arm/boot/dts/ti/am57xx-evm.dtso b/arch/arm/boot/dts/ti/am57xx-evm.dtso new file mode 100644 index 0000000..91a57e9 --- /dev/null +++ b/arch/arm/boot/dts/ti/am57xx-evm.dtso @@ -0,0 +1,11 @@ +/dts-v1/; +/plugin/; + +&mmc3 { + pinctrl-names = "default", "hs", "sdr12", "sdr25", "sdr50"; + pinctrl-0 = <&mmc3_pins_default>; + pinctrl-1 = <&mmc3_pins_hs>; + pinctrl-2 = <&mmc3_pins_sdr12>; + pinctrl-3 = <&mmc3_pins_sdr25>; + pinctrl-4 = <&mmc3_pins_sdr50 &mmc3_iodelay_manual1_rev11_conf>; +};
The AM57xx-evm is an overlay on top of beagle-x15 board. This contains a display extension macro, and a few extra peripherals. Two versions of the evm are supported, the base evm and the latest rev A3 evm. A common overlay file is used for both boards. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/boot/dts/ti/am57xx-evm-common.dtso | 175 ++++++++++++++++++++++++++++ arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso | 11 ++ arch/arm/boot/dts/ti/am57xx-evm.dtso | 11 ++ 3 files changed, 197 insertions(+) create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-common.dtso create mode 100644 arch/arm/boot/dts/ti/am57xx-evm-reva3.dtso create mode 100644 arch/arm/boot/dts/ti/am57xx-evm.dtso -- 1.9.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html