From patchwork Mon Feb 15 12:34:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 382948 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp1047359jao; Mon, 15 Feb 2021 04:49:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWNwywRTx/yTnbaXFWIc7vu9MBgv1CRThRVtjLhhkfkTFKQxDnRJRSUuhO6gmPvl6g7GwI X-Received: by 2002:aa7:dd08:: with SMTP id i8mr1235800edv.1.1613393368097; Mon, 15 Feb 2021 04:49:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1613393368; cv=pass; d=google.com; s=arc-20160816; b=o88YRhQTYg+NuM0zF6k1DFShFj9DCcgB8qrqNG0NWlkbbzYU5Fkvns1Q7AsZjko1Xa zLT9CpQXXYcdZQCFtNdkiDd55NorXu0HcEfQGXIBmg+6KemHNgdIk3RI8hmrKNdxH3FV 7ahWtPdbsTIiWocajs68b78msf15sJ5zsHcwatbj1qA0y0z2bF2vWBnRSl0RkU6Wr1x8 5voE1IeUA3+AnhTE/GiHf7v8fpqT8uXpgoKuWVAfyZGCdKr7VLr2hdAYDLJq8BlaCfID WG1PJSihAZU8XmbHFsoxO5mibz5q6jh+YEsTGbYwnqpJkd/vxaWheoQGfuwSjF/+0/Qx /W1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=EM9JIC+yeL3C9WIVZhyYz0R6U9vBvka5aiesdeAvSbw=; b=ZA6XIAhYRi20pWuuQIwEu3kKVdKm4lD/o41JczEVOlfBrg4PqlZtT3NbvD2rmdRFR+ 32CBaoMubtLSKEwV61Qt0ZH3S+3LYaMI8qW19D2PqRsC0l/xpTaaCmflosbubQkBE3t8 7EmMqo3mbcP6/tbX0KAZ9gYxF9CUVOYUQNAMmjvPf/AEiqChis6jo9GeqtyBkCMle3F1 /5eH304FudCPMkP7KlRNlCLq2ONs39KlAmLuNvVgrQGjF385efgSu+vst79yXMgx7s9i Opwm+DBLa+sv5p7LBaHTkp0Ir5H9iROafpFQhup+cIWJRTWVP8KmBx28txfoFzA5esqw WVRg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=VmNEkzfS; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si12572576edu.40.2021.02.15.04.49.27; Mon, 15 Feb 2021 04:49:28 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=VmNEkzfS; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbhBOMtN (ORCPT + 6 others); Mon, 15 Feb 2021 07:49:13 -0500 Received: from mail-eopbgr30043.outbound.protection.outlook.com ([40.107.3.43]:4416 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229913AbhBOMso (ORCPT ); Mon, 15 Feb 2021 07:48:44 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icR3NYMRVn6fRhl36xLXUaSJiNkMbNER7BKJuThPZpKbLfABpaPrqMsYQ4x9wRnSk4YgdQ99TTiLRkuOLEQuSVcPTMv4pNlhbRSO7q36x+SHaTgs9TbjzhTLLNuE0gFeX4QIbkV/+qQKMiEVKYB7YX1M0EKeq7WYneZuqogxnx47hoXhVPlZ47EIbIgd1bqUFlesATfxC7rqKJViqbI3faTzbk/9ce+CZ79qLTgbfAoGISY/RuPb+7uIbT42pJ5bPWQdmh4MZODStDcFqT5zJJCZp0GJT5pJWAKfLUeXetPvBFc9oHNhcZsci+d6QixXHWhBwk7+DqtEZra0keV7VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EM9JIC+yeL3C9WIVZhyYz0R6U9vBvka5aiesdeAvSbw=; b=Lh1ieTqHFgxcztTTSbOQ93NvE4b1MFpkOvoAPU2Ja4aMfR5EOGgeBzgiGn+y9jiottWFRcAU55o3dEwVXm+3oiifdFBAN8kuQYJN9oTCWwepMojD9mThNIt9Ne8SCrrS7e+oSqi8Xt/oGhDMKeOT9zkqqcyHlORwgbjkxJNyNj71YcHMgYKpYy5vOPfJhaCdW1b6C77UCBfJiqaEhFCob9QgM9jpjtsZm6QHFfrqi/2FUq1lD9xqmV/M5pt7cquPYS327NYpjni/rLZTnxdCwNXXyG+FouOM5KMIWCJGBmqeCS/g6nitUsVsvt28Hadgy7D/9K/qG4apRFZ3mLWXEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EM9JIC+yeL3C9WIVZhyYz0R6U9vBvka5aiesdeAvSbw=; b=VmNEkzfSog2jIJXYcHF8u8HFfHwdNROidYfNMQoWnPhtmmSQKlc3GMA9H05EBtMxxfADixcI6007inw2PzvBFVui3XJDQIAcv3uT+ui3LpWg5JE2DjLIuHj5KzfJSH8QKofyJkn1Nu+Bz3gflo0hPx1JeeCfgDouKJcq8xuJFvc= Authentication-Results: wizery.com; dkim=none (message not signed) header.d=none; wizery.com; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB7PR04MB4091.eurprd04.prod.outlook.com (2603:10a6:5:1e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27; Mon, 15 Feb 2021 12:46:49 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::d58c:d479:d094:43d0]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::d58c:d479:d094:43d0%9]) with mapi id 15.20.3846.027; Mon, 15 Feb 2021 12:46:49 +0000 From: peng.fan@oss.nxp.com To: ohad@wizery.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, paul@crapouillou.net, matthias.bgg@gmail.com, agross@kernel.org, patrice.chotard@st.com, Peng Fan Subject: [PATCH V10 05/10] remoteproc: imx_rproc: correct err message Date: Mon, 15 Feb 2021 20:34:18 +0800 Message-Id: <1613392463-9676-6-git-send-email-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1613392463-9676-1-git-send-email-peng.fan@oss.nxp.com> References: <1613392463-9676-1-git-send-email-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: SG2PR0302CA0019.apcprd03.prod.outlook.com (2603:1096:3:2::29) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2PR0302CA0019.apcprd03.prod.outlook.com (2603:1096:3:2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3868.12 via Frontend Transport; Mon, 15 Feb 2021 12:46:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7389bac4-83e4-4fe0-e6ea-08d8d1afc30f X-MS-TrafficTypeDiagnostic: DB7PR04MB4091: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:989; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dpKtsm65esLP+/NsU5zhJQo2hEevZdJbBz8Nqnh1PryIzxXT/z38s2dLXA00IRfTcQqbPqsQXiON21VYeXiLxr5YemUUKVcRECcAGHxzJxaUQlscODTRyHSqHl6A8k6epevxbN6sjnJZnse3HZget5I5xiuCi47gzmXmNUt9BVZtZyoB6NF1jgwPG8Mqaq4qxbVLMdHKkdP3DHamO2ijmiWNkTBoLipP/+8HF33pcSTQRiwakJbm6/crKi3RbaoVWyP+IO9Q/76erM1zWfAuP9WpYhTJ7X/jAyDdQzlvVp2crXs9UHi5hcaRtloj/6vvHHPtWdXXP0BqEWnVWuZ+KQfPEpmBsHzCBbflLlhzuR6t0WZ0kkbeflrD/m3s+7EppCfH+tTYiUJfgRuzEENlgnFeXqdM4HtsOjrYmCX7EHrM5+robussv1zBUYnj/OBjK5qMFE2V0uzxN+Q8B33fOsFdfVFf32zmKcTBrJS1Ys9K6TdSuXvbQ3Z++OZn5WcBuM8rRNDBDZ5tTo/SM8Ct9qz0qceXSqm0iWbaEFLu8GorTygTrRHlopF8YZdEFY8zEefUe+0MFqJ/1h3MMdZQ8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(26005)(6486002)(9686003)(478600001)(316002)(186003)(52116002)(6512007)(2906002)(16526019)(15650500001)(4326008)(6506007)(8936002)(2616005)(956004)(7416002)(86362001)(66476007)(66946007)(66556008)(69590400012)(5660300002)(6666004)(8676002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: T85DrJf+pR9AAi03ctyL0akzLzTp7m1YSbNF44FNnRzyw4BCxdPwuqrgjednoLsS0xDtqpkX3ZQSLZ2EQNsM/Wgni75X6I82Xm2HykU1ccjWMFdvd/GibaSTmEWNmG9FvdEiQbhRmq4oT3H3TK/r+p04BXRkmBqknRy8Y3LHrSf+FscDt6h1GWZotbhRaGJhsIkK+b9pGsg/Wp2WhVtPItHnKYpnzsN8s6uYvVaFZ7FhUngieWLoP2jWDOMp03V61MDt7yG09ihCJnO8FMLFEEKO/SuN4Z1O9HtABx+ci6x5PVa/VXD3+86MJn81VB4XyO9QoxOLa22V4u8Wpte/3Ti8/zJklHwM5BKiCZm3aQpAFF5EW103Jdtt0uyyHckxXvEKk5e+9cjj4yn7gbFVnZsE12st1mMr9cGKX10AvahVACj/Ln5d3ZEBg1CQD79Y2AD4o7/q3yP+QoC4YD80Ub9BBsHFgbuhyB4qEUwFzG7jD6GCBuP42qYUsunqf6EUo4cfiyy6eP2KPeUX+hfe7E1PfqtaORKgHJytMrwmPt4CqSKdTlG6ZqU7jdkh8j/Zf9e0hY5BVoH0E70Vqce6m9SpWcungECi/NPvdX9daPhrMMbq/6atkOgYZJsjOZuWlfuL1xCtKJpW9KCax9ocbZrjW6sKKcBGfV4UVH3XgDT0uFH7lEevtnmwF2o0+HhVce9JRWQER1S+NruNxuELhylkjbGo9IBym8Ee7we33U3xTp44zYyU3z86pFilG1RkSfPCTuRT4gHXZUUUKDW6fmFW95o+licIQgsAQJtrSJzISPiqkBdIJzzVJ+kECrMoJ7B5+bA3pffSRC4mbvaItRfBC/o6eJ3AgqlShyq5eFshX9/rma+2PipUZar0E0xuBclEcw/UFDYucdnn4U3bGASHAWzdFcEuxI2mWxWyrFiAUQs9VslPLPUGd9d8cDQoZddjDYk7JD7QyxAw5JEzQIThYN3hQbl6/CFZB9uAmYMbENskmIwiMmlICC1EE/MPh1cjTYEeXO18o+aVH6+WwDj3oCId6xq8Izj0qaeiQ00SbNd/AOpMbOnvceeNYy2V8owHXoGW6id7TAVLFVWGlHxB4nxZf2O8LoxYnCTvt5vcqJCeTTyG446Fp4gxpcGz3FbHh8QZBOW/VKEAdJxW/yA3sTEejyHS9kBbDkDxmuJo62EVw/HJ3FKppIg8sXYupsWz2xB2FQCgFJUVmKok74RRfTMLegDP+eKHKw7vJ7WR1IYcHV5WOXSiR5NeR3uJSDyhGV44eU0EW5ZUZSnZkxFivI6P1lrcy1GeYK1sfK7xDmSrtcfh+Mrzvs89YoUa X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7389bac4-83e4-4fe0-e6ea-08d8d1afc30f X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2021 12:46:49.9194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1GvwxalZg9PNnKIVDTwrW/NJdOgxlkBwrmg3gjDDpxBc+ODwbvgBXW6XVGmYfPUI8SB/T/nXydbbZDG+DT/a7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4091 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Peng Fan It is using devm_ioremap, so not devm_ioremap_resource. Correct the error message and print out sa/size. Reviewed-by: Bjorn Andersson Reviewed-by: Mathieu Poirier Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.0 diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c index 6603e00bb6f4..2a093cea4997 100644 --- a/drivers/remoteproc/imx_rproc.c +++ b/drivers/remoteproc/imx_rproc.c @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, att->sa, att->size); if (!priv->mem[b].cpu_addr) { - dev_err(dev, "devm_ioremap_resource failed\n"); + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); return -ENOMEM; } priv->mem[b].sys_addr = att->sa; @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); if (IS_ERR(priv->mem[b].cpu_addr)) { - dev_err(dev, "devm_ioremap_resource failed\n"); + dev_err(dev, "failed to remap %pr\n", &res); err = PTR_ERR(priv->mem[b].cpu_addr); return err; }