From patchwork Tue Feb 6 12:58:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 127000 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2894344ljc; Tue, 6 Feb 2018 05:00:02 -0800 (PST) X-Google-Smtp-Source: AH8x227+LRFP/jmop8XzKzEm9BX1CH/UGxO/rACT3lquMKF3Bfu+L1jFVqZ2mQm3pcvX4fsjILQn X-Received: by 10.101.98.5 with SMTP id d5mr1899436pgv.108.1517922002764; Tue, 06 Feb 2018 05:00:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517922002; cv=none; d=google.com; s=arc-20160816; b=Jc+Y2qHCIAB9UOBqhO/KTu54s16DlH2ckIL3KwyQ9W97Se8bNFjSBpiKbNyo7w5anz hqwOVc/jX8XRr01a5CV788f7pOBgqKdAoDDmqornhIrE4eZ05sjxWYBuZxWgactY2mUR a9W1OnBOckPbYVURPgyTixBlGIomZPl8SsCeMSrOleYlfubD+SjfEm3MmBA4M54RzMf6 i5/R2Yx5oldmFhT9vUp1D/oBfWUP6M2cyXyzNXJbGTELgv5UtrPcPyxlKKvF93o3ZxVi Gdg4l9cJBHXtJ+wMnh/odhe8R4qgfhbPsyhtwTfa45XAoab16ayzUR5cJwsAwt+RZEls E0mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=ciLeOBKGQJFPgYRwEMkvaTeo3tmq3uXC25jo2y/7UPk=; b=xETLIla5hCfA3EVlidjmEXj3DIOu5DEosvzkVtMVZSN+y0vEUnhyyWsBqNSe6COQ8u iUwZJMJ1cBz48AwBpiKhcCNd1nSMO0FBeWoO2vsDINF//0QApz9OG5xplehMU8GpcIhW UVBIbzthhYwToAxTxC2Q9AMfdt704uKCROr7OhAU0lXWNoRG1xDCfO9clcyrCb2FflCL lfb0W3MRwh6H5s8PZRGR7kzICWUnyn0NtN//HGLqMypfZIXI5S+9jM4Pa0u7ddJcuL3v kRawXO/4UHQBq0FFTOcDw8SxuvkgNYm+JKVuFZxnrGS1LYgkmDkMQxdGr8B/X5NHbdMP VdVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=nufg6pad; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si3252874pfj.20.2018.02.06.05.00.02; Tue, 06 Feb 2018 05:00:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=nufg6pad; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbeBFNAA (ORCPT + 6 others); Tue, 6 Feb 2018 08:00:00 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:15749 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbeBFM7g (ORCPT ); Tue, 6 Feb 2018 07:59:36 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id w16Cx4AB013014; Tue, 6 Feb 2018 06:59:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1517921944; bh=o0g9u0uPxz92YWAz45A+6p1Ey4LMEOnmdzYZ2E+8DDY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=nufg6padsn0uvmyU3++pqXSwnDkYpF090rKtAAZOwTuyZGrqIGwyVqPvUPlGbnRBo LJ2XqUYdKplsu4F0Vc6Dvhpj8wjtM3dgxiLlOygJj7nKaTowZyRXd7e+g6vlIODgPh mRU+G1M0ZuhLNBQXnau5jz0EN8EM3HgAu7k1KGFs= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w16Cx4Um006780; Tue, 6 Feb 2018 06:59:04 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Tue, 6 Feb 2018 06:59:03 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Tue, 6 Feb 2018 06:59:03 -0600 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w16CwHXh007055; Tue, 6 Feb 2018 06:59:01 -0600 From: Kishon Vijay Abraham I To: =?utf-8?q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring CC: Mark Rutland , Russell King , , , , , Kishon Vijay Abraham I Subject: [PATCH v2 13/15] ARM: dts: am57xx-idk: Select pull down for mmc1_clk line in default mode Date: Tue, 6 Feb 2018 18:28:04 +0530 Message-ID: <20180206125806.19350-14-kishon@ti.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180206125806.19350-1-kishon@ti.com> References: <20180206125806.19350-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org During a short period when the bus voltage is switched from 3.3v to 1.8v, (to enumerate UHS mode), the mmc module is disabled and the mmc IO lines are kept in a state according to the programmed pad mux pull type. According to 4.2.4.2 Timing to Switch Signal Voltage in "SD Specifications Part 1 Physical Layer Specification Version 5.00 February 22, 2016", the host should hold CLK low for at least 5ms. In order to keep the card line low during voltage switch, the pad mux of mmc1_clk line should be configured to pull down. This is specific to am57xx-idk (and not all dra72/dra74 based boards) since mmc1_clk line in am57xx-idk is not connected to an external pullup. While at that change the order of header files in am571x-idk.dts and am572x-idk.dts so that the modified pinctrl values in am57xx-idk-common could take effect. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/am571x-idk.dts | 2 +- arch/arm/boot/dts/am572x-idk.dts | 3 +-- arch/arm/boot/dts/am57xx-idk-common.dtsi | 11 +++++++++++ 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/am571x-idk.dts b/arch/arm/boot/dts/am571x-idk.dts index 6d3c83743156..a2555140babc 100644 --- a/arch/arm/boot/dts/am571x-idk.dts +++ b/arch/arm/boot/dts/am571x-idk.dts @@ -10,8 +10,8 @@ #include "dra72x.dtsi" #include #include -#include "am57xx-idk-common.dtsi" #include "dra72x-mmc-iodelay.dtsi" +#include "am57xx-idk-common.dtsi" / { model = "TI AM5718 IDK"; diff --git a/arch/arm/boot/dts/am572x-idk.dts b/arch/arm/boot/dts/am572x-idk.dts index 9ab0af5017df..3a02ed720957 100644 --- a/arch/arm/boot/dts/am572x-idk.dts +++ b/arch/arm/boot/dts/am572x-idk.dts @@ -9,9 +9,8 @@ /dts-v1/; #include "dra74x.dtsi" -#include "am572x-idk-common.dtsi" -#include "am57xx-idk-common.dtsi" #include "dra74x-mmc-iodelay.dtsi" +#include "am572x-idk-common.dtsi" / { model = "TI AM5728 IDK"; diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b/arch/arm/boot/dts/am57xx-idk-common.dtsi index 43a6d0590f7c..43cdf523a8a0 100644 --- a/arch/arm/boot/dts/am57xx-idk-common.dtsi +++ b/arch/arm/boot/dts/am57xx-idk-common.dtsi @@ -115,6 +115,17 @@ DRA7XX_CORE_IOPAD(0x37d4, MUX_MODE15 | PULL_UP) /* dcan1_rx.off */ >; }; + + mmc1_pins_default: mmc1_pins_default { + pinctrl-single,pins = < + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */ + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */ + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */ + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */ + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */ + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */ + >; + }; }; &i2c1 {