From patchwork Wed Nov 20 13:17:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 179848 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp2092186ilf; Wed, 20 Nov 2019 05:18:14 -0800 (PST) X-Google-Smtp-Source: APXvYqxiR1wWZ/p9ukOj493ul88bjsCmXkRBgOBKeyun8yQebU3+1RwSiIvirF13+gR1bucOM/TE X-Received: by 2002:a17:906:8319:: with SMTP id j25mr5186997ejx.170.1574255893957; Wed, 20 Nov 2019 05:18:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574255893; cv=none; d=google.com; s=arc-20160816; b=KRvcNyBZj22HA43Eg2g4oc7lziF8iTbUtYsJN0Ygpp8XJWMH8Ws3ZPeI4vggSH2LXH KMwX2TQrgLNvwXjo0g/XjChkTWd2azmJ0hRjCy7qI5TUxZmA96Wgxr5tRDKENAH0G0th EGaae9ZY1rai6rVXe3f8ml1kiczxhRa+PBHfaEQIYT5mggRkCDb89ADZhP7y1hMJFiMY RHFgXsiswADT97xhT0v0HZ54h76a0JPkXZxe715u9KFCSHIzRZa7yr/okH+zg4m9qPsc UmgVcBxJ4/kkmx5z3p2bb8zKZIRI+iOSGJ2Lmc2iv7s78pLcFJy2LjiIJXuFuzYN8Fte ey7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D7ZpGl2GOQVl1LRPY+tj5e7FhNzsNfXiSHrb52YKorU=; b=i4T3O9W6IT5+NpIchJ23gFSSeqLGN+FKPThroaxcWfWCDeiOrDIsqeCwxbosWit8/U u8V1S56dc8gzQte3e8wHvfkyLjc8qZef2ixel29m+pdkTM5+OTMcwwOes/eJ11PDBw0w kaNr+w0H+skm1uJyjnlK2rhfQ/VsJyoxYR3LVUCriGk0HhZvz5IIP7SHScBoiTFZmtU3 WYj/XicXas336A+NISMO8gvTNbDf8HRcdzh1F3SGh1OenU2in4sIH8jS6Hm6+PaKoiMG cMQh/HMnUWiaZq9++89Um72C/pAWDvZH0dLFLWDEMmPNaTlG+SSjPosBoitTNmFtjt0G 1g5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="idf7kk/S"; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si16106976ejc.331.2019.11.20.05.18.13; Wed, 20 Nov 2019 05:18:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="idf7kk/S"; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730067AbfKTNSM (ORCPT + 8 others); Wed, 20 Nov 2019 08:18:12 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:32916 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730053AbfKTNSM (ORCPT ); Wed, 20 Nov 2019 08:18:12 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAKDI4AL033449; Wed, 20 Nov 2019 07:18:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1574255884; bh=D7ZpGl2GOQVl1LRPY+tj5e7FhNzsNfXiSHrb52YKorU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=idf7kk/SKW+n+VPi6VHNfUmXqbu9DunvBJm74dYACuYsioLK7uY7gjc0QrJTTvGQV 6awdD6aj6/IarAZvQTEXJmushWd5CIxh7TH5nklx43Q20QnZcvwMVUXCVAFpTmwSar mqhEZNWAqWqKLE8iYTa/VvjaUBhlx3LIhpN7NTkU= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAKDI4OI092105 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 Nov 2019 07:18:04 -0600 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 20 Nov 2019 07:18:02 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 20 Nov 2019 07:18:02 -0600 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAKDHru7067880; Wed, 20 Nov 2019 07:17:59 -0600 From: Peter Ujfalusi To: , CC: , , , , , Subject: [PATCH 2/2] ASoC: pcm3168a: Update the RST gpio handling to align with documentation Date: Wed, 20 Nov 2019 15:17:53 +0200 Message-ID: <20191120131753.6831-3-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191120131753.6831-1-peter.ujfalusi@ti.com> References: <20191120131753.6831-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The RST (reset-gpios) is low active so the driver must handle it accordingly. Add comments to explain clearly how the line is used. Signed-off-by: Peter Ujfalusi --- sound/soc/codecs/pcm3168a.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index f3475134b519..9711fab296eb 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -707,11 +707,15 @@ int pcm3168a_probe(struct device *dev, struct regmap *regmap) dev_set_drvdata(dev, pcm3168a); /* - * Request the RST gpio line as non exclusive as the same reset line - * might be connected to multiple pcm3168a codec + * Request the reset (connected to RST pin) gpio line as non exclusive + * as the same reset line might be connected to multiple pcm3168a codec + * + * The RST is low active, we want the GPIO line to be high initially, so + * request the initial level to LOW which in practice means DEASSERTED: + * The deasserted level of GPIO_ACTIVE_LOW is HIGH. */ - pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "rst", - GPIOD_OUT_HIGH | + pcm3168a->gpio_rst = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE); if (IS_ERR(pcm3168a->gpio_rst)) { ret = PTR_ERR(pcm3168a->gpio_rst); @@ -814,7 +818,13 @@ void pcm3168a_remove(struct device *dev) { struct pcm3168a_priv *pcm3168a = dev_get_drvdata(dev); - gpiod_set_value_cansleep(pcm3168a->gpio_rst, 0); + /* + * The RST is low active, we want the GPIO line to be low when the + * driver is removed, so set level to 1 which in practice means + * ASSERTED: + * The asserted level of GPIO_ACTIVE_LOW is LOW. + */ + gpiod_set_value_cansleep(pcm3168a->gpio_rst, 1); pm_runtime_disable(dev); #ifndef CONFIG_PM pcm3168a_disable(dev);