From patchwork Thu Dec 19 18:22:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 182149 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp835665iln; Thu, 19 Dec 2019 10:23:02 -0800 (PST) X-Google-Smtp-Source: APXvYqzw3NmLjoISOQO8UnDP1mph+OUOmHUHkJFbCGMU9aoSZGtqXdIA7lBj4UrWGqyFlUJwAME6 X-Received: by 2002:a9d:5616:: with SMTP id e22mr9855867oti.366.1576779782410; Thu, 19 Dec 2019 10:23:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576779782; cv=none; d=google.com; s=arc-20160816; b=dyL+eHCLLoQt1G0kBgMpPD0AvqUkOlovfGzQ4Lf2590QSvqREPk7XCx9xC1zHzDCNw SI+5jGUdmGWDRNvJjPt9/sigeAQNZLlYjDyDmd+66uIEjbdYjKa18xmuSrXpV6HZVMcq 1nI8FI3Mz13Bb57DL9EEF/TyAiOyyA1WQdbPiTuFEPXRXidMIv1rk1SLRq2IB+bhHZEV ddh4Hw71TDkX93jwq48e49jbzc0YUOYlzcmC4ejOaXyzTE+4nLkIiiWudwHPVSJoLfkY +hrAsJXK9To+jCCZLEszU0S9HnZenv7leYHVRZSGIvXaKyhzIfYT//CZsvZybzEgKYDI vg8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=AFvgHo+YGqFoje0Tn82GYQJ1a/RGDe/xy+Kyh3iTfBI=; b=QMtZM4EOBdGUD8Wu7RliyLFozk93UYx5abWglK+xZWkunj9b+x+Dx18EzHKJ5atBhq uP2c+nSMKFpaNDS1vbEpFOt6Ze7mwua+/VKU/usyLaSoEPlL+nsY/Ntus4u7ilHmfwk1 G5W0FdSemJrvLIRwUhkhzn9LODKoyzWlsUTQOnCzEC45kvXG+Bcf2DBsmBf9K60KE7dl 1JJklBJ7IMuOQVRGn9PLE34F3HULgCqw2LcWI+gEcBvwG1UlYbjkR9AMdHsx1AcjhOs3 lwds96DgX55rZjROz+Mv8x+z0aBj3rvAuS1dQMHMjuQnBb+eFH7PAcdyOzVwcO9lGawZ I6bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kmDLD54W; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e25si638225oie.146.2019.12.19.10.23.02; Thu, 19 Dec 2019 10:23:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kmDLD54W; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbfLSSXB (ORCPT + 8 others); Thu, 19 Dec 2019 13:23:01 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:46423 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726998AbfLSSXB (ORCPT ); Thu, 19 Dec 2019 13:23:01 -0500 Received: by mail-pl1-f195.google.com with SMTP id y8so2914158pll.13 for ; Thu, 19 Dec 2019 10:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AFvgHo+YGqFoje0Tn82GYQJ1a/RGDe/xy+Kyh3iTfBI=; b=kmDLD54Wg3ujI/AZ5o82fQsFYrDiuccUSsctI4Y7S7mXX6MyEfNbDjjW9+s6zcVUKS nygmXBu+d+VM9XCAAmQ3nbV9d3I72uZUIsjZ2SF8TFVUHPw9QRjNM6Jw+1BRPLeBXvp1 cBNCRZIY/A1kpYJfHUDMOI8ai1nkGnezL24ODwAzUUPH7TiHct5j6i/A08jdpjRE3R5J pQvdnIciCIRAL3pDWcp2YfwuPzLAraQHzAVxWEuuc2oUYwHjmUQ7vD7F4aLl++6gwKFt mqL2MxBLFXllu3VhBGuTZzEB+Xzt4jE5lsgOpSSCUES1bflOqdaIw4CudFV4w25Q/kpG sIbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AFvgHo+YGqFoje0Tn82GYQJ1a/RGDe/xy+Kyh3iTfBI=; b=V94PEePSc48/n3vWvuoGdYe5uGgZzECAJz9z11tW7qRulXWD/cMhPIc8nhgRPQoeVN 7TAAca61+HJb0KeFKI7CVnmhPrKCkXbB2TpplrTcEfikQ29w4M8uMWvBdkTdesOGZFPF +ce8nuUJO7UjmdVG4ISOCQ0glIoz96EsgwdVV0WZcQMbdXiBYQWPIZAvSbnJkMRSzPL+ ty2kDFUUdZphvlE7jwzRuY/XwPt1cmg8TgGj2uJFmASdACcKAD52lzGeD95rEkPxe9eG nw7Uw2Kwh5EDA0OHViBz9wBJOeM58gcL6AILX9ZQBgybTQXNRRxJunsTgHhRGM55h4SZ xbDA== X-Gm-Message-State: APjAAAWaZkUN2R2dJ8qHuZ1wYPH9vWMwE3/rTDePUvnCUv3jH/+AwQX9 coHQ8ISLGxS6Kuoul+dTxgxb X-Received: by 2002:a17:902:bd93:: with SMTP id q19mr8338103pls.134.1576779780558; Thu, 19 Dec 2019 10:23:00 -0800 (PST) Received: from localhost.localdomain ([2409:4072:6010:65a5:a416:e9bd:178a:9286]) by smtp.gmail.com with ESMTPSA id i3sm9085735pfg.94.2019.12.19.10.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 10:23:00 -0800 (PST) From: Manivannan Sadhasivam To: mchehab@kernel.org, sakari.ailus@iki.fi Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org, Manivannan Sadhasivam Subject: [PATCH v2 3/6] media: i2c: imx290: Add RAW12 mode support Date: Thu, 19 Dec 2019 23:52:19 +0530 Message-Id: <20191219182222.18961-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191219182222.18961-1-manivannan.sadhasivam@linaro.org> References: <20191219182222.18961-1-manivannan.sadhasivam@linaro.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org IMX290 is capable of outputting frames in both Raw Bayer (packed) 10 and 12 bit formats. Since the driver already supports RAW10 mode, let's add the missing RAW12 mode as well. Signed-off-by: Manivannan Sadhasivam --- drivers/media/i2c/imx290.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) -- 2.17.1 diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 96eea0aafd3e..b6eeca56d3c9 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -75,6 +75,7 @@ struct imx290 { struct clk *xclk; struct regmap *regmap; u8 nlanes; + u8 bpp; struct v4l2_subdev sd; struct v4l2_fwnode_endpoint ep; @@ -98,6 +99,7 @@ struct imx290_pixfmt { static const struct imx290_pixfmt imx290_formats[] = { { MEDIA_BUS_FMT_SRGGB10_1X10 }, + { MEDIA_BUS_FMT_SRGGB12_1X12 }, }; static const struct regmap_config imx290_regmap_config = { @@ -265,6 +267,18 @@ static const struct imx290_regval imx290_10bit_settings[] = { { 0x300b, 0x00}, }; +static const struct imx290_regval imx290_12bit_settings[] = { + { 0x3005, 0x01 }, + { 0x3046, 0x01 }, + { 0x3129, 0x00 }, + { 0x317c, 0x00 }, + { 0x31ec, 0x0e }, + { 0x3441, 0x0c }, + { 0x3442, 0x0c }, + { 0x300a, 0xf0 }, + { 0x300b, 0x00 }, +}; + /* supported link frequencies */ static const s64 imx290_link_freq[] = { IMX290_DEFAULT_LINK_FREQ, @@ -550,6 +564,21 @@ static int imx290_write_current_format(struct imx290 *imx290, dev_err(imx290->dev, "Could not set format registers\n"); return ret; } + + imx290->bpp = 10; + + break; + case MEDIA_BUS_FMT_SRGGB12_1X12: + ret = imx290_set_register_array(imx290, imx290_12bit_settings, + ARRAY_SIZE( + imx290_12bit_settings)); + if (ret < 0) { + dev_err(imx290->dev, "Could not set format registers\n"); + return ret; + } + + imx290->bpp = 12; + break; default: dev_err(imx290->dev, "Unknown pixel format\n"); @@ -913,6 +942,9 @@ static int imx290_probe(struct i2c_client *client) goto free_err; } + /* Default bits per pixel value */ + imx290->bpp = 10; + mutex_init(&imx290->lock); v4l2_ctrl_handler_init(&imx290->ctrls, 4);