diff mbox series

[v2,14/22] dt-bindings: media: camss: Add qcom,msm8996-camss binding

Message ID 20210120134357.1522254-14-robert.foss@linaro.org
State New
Headers show
Series [v2,01/22] media: camss: Fix vfe_isr_comp_done() documentation | expand

Commit Message

Robert Foss Jan. 20, 2021, 1:43 p.m. UTC 
Add bindings for qcom,msm8996-camss in order to support the camera
subsystem on MSM8996.

Signed-off-by: Robert Foss <robert.foss@linaro.org>

---

Changes since v1:
 - Laurent: Reworked driver to use dtschema


 .../bindings/media/qcom,msm8996-camss.yaml    | 418 ++++++++++++++++++
 1 file changed, 418 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml

-- 
2.27.0

Comments

Rob Herring (Arm) Jan. 21, 2021, 4:01 p.m. UTC | #1 
On Wed, 20 Jan 2021 14:43:49 +0100, Robert Foss wrote:
> Add bindings for qcom,msm8996-camss in order to support the camera

> subsystem on MSM8996.

> 

> Signed-off-by: Robert Foss <robert.foss@linaro.org>

> ---

> 

> Changes since v1:

>  - Laurent: Reworked driver to use dtschema

> 

> 

>  .../bindings/media/qcom,msm8996-camss.yaml    | 418 ++++++++++++++++++

>  1 file changed, 418 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml

> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml:418:7: [error] no new line character at the end of file (new-line-at-end-of-file)

dtschema/dtc warnings/errors:

See https://patchwork.ozlabs.org/patch/1429444

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Rob Herring (Arm) Jan. 22, 2021, 4:33 p.m. UTC | #2 
On Wed, Jan 20, 2021 at 02:43:49PM +0100, Robert Foss wrote:
> Add bindings for qcom,msm8996-camss in order to support the camera

> subsystem on MSM8996.

> 

> Signed-off-by: Robert Foss <robert.foss@linaro.org>

> ---

> 

> Changes since v1:

>  - Laurent: Reworked driver to use dtschema

> 

> 

>  .../bindings/media/qcom,msm8996-camss.yaml    | 418 ++++++++++++++++++

>  1 file changed, 418 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml

> 

> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml

> new file mode 100644

> index 000000000000..5ca0be8892ab

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml

> @@ -0,0 +1,418 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +

> +%YAML 1.2

> +---

> +$id: "http://devicetree.org/schemas/media/qcom,msm8996-camss.yaml#"

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

> +

> +title: Qualcomm CAMSS ISP

> +

> +maintainers:

> +  - Robert Foss <robert.foss@linaro.org>

> +  - Todor Tomov <todor.too@gmail.com>

> +

> +description: |

> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms

> +

> +properties:

> +  compatible:

> +    const: qcom,msm8996-camss

> +

> +  clocks:

> +    description:

> +      Input clocks for the hardware block.


That's every 'clocks' entry. Drop.

> +    minItems: 36

> +    maxItems: 36

> +

> +  clock-names:

> +    description:

> +      Names of input clocks for the hardware block.


ditto.

> +    items:

> +      - const: top_ahb

> +      - const: ispif_ahb

> +      - const: csiphy0_timer

> +      - const: csiphy1_timer

> +      - const: csiphy2_timer

> +      - const: csi0_ahb

> +      - const: csi0

> +      - const: csi0_phy

> +      - const: csi0_pix

> +      - const: csi0_rdi

> +      - const: csi1_ahb

> +      - const: csi1

> +      - const: csi1_phy

> +      - const: csi1_pix

> +      - const: csi1_rdi

> +      - const: csi2_ahb

> +      - const: csi2

> +      - const: csi2_phy

> +      - const: csi2_pix

> +      - const: csi2_rdi

> +      - const: csi3_ahb

> +      - const: csi3

> +      - const: csi3_phy

> +      - const: csi3_pix

> +      - const: csi3_rdi

> +      - const: ahb

> +      - const: vfe0

> +      - const: csi_vfe0

> +      - const: vfe0_ahb

> +      - const: vfe0_stream

> +      - const: vfe1

> +      - const: csi_vfe1

> +      - const: vfe1_ahb

> +      - const: vfe1_stream

> +      - const: vfe_ahb

> +      - const: vfe_axi

> +

> +  interrupts:

> +    description:

> +      IRQs for the hardware block.


ditto

> +    minItems: 10

> +    maxItems: 10

> +

> +  interrupt-names:

> +    description:

> +      Names of IRQs for the hardware block.

> +    items:

> +      - const: csiphy0

> +      - const: csiphy1

> +      - const: csiphy2

> +      - const: csid0

> +      - const: csid1

> +      - const: csid2

> +      - const: csid3

> +      - const: ispif

> +      - const: vfe0

> +      - const: vfe1

> +

> +  iommus:

> +    maxItems: 4

> +

> +  power-domains:

> +    maxItems: 2


Need to define what each one is.

items:
  - description: ...
  - description: ...

> +

> +  ports:


This needs to reference graph.yaml#/properties/ports

See recent additions in -next.

> +    description:

> +      The CSI data input ports.

> +

> +    type: object

> +

> +    properties:

> +      port@0:


There's a pending video-interfaces.yaml conversion which this is going 
to need to use[1].

> +        type: object

> +        description: Input node for receiving CSI data.

> +        properties:

> +          endpoint:

> +            type: object

> +

> +            properties:

> +              clock-lanes:

> +                description: |-

> +                  The physical clock lane index. The value must

> +                  always be <7> as the hardware supports D-PHY

> +                  and C-PHY, indexes are in a common set and

> +                  D-PHY physical clock lane is labeled as 7.


You don't need this in DT if it can only be 1 value.

> +

> +              data-lanes:

> +                description: |-

> +                  An array of physical data lanes indexes.

> +                  Position of an entry determines the logical

> +                  lane number, while the value of an entry

> +                  indicates physical lane index. Lane swapping

> +                  is supported. Physical lane indexes are:

> +                  0, 1, 2, 3


No need to redescribe this here. Just any additional constraints. 
'maxItems: 4' at least since the base allows 8.

Rob

[1] https://lore.kernel.org/linux-devicetree/20210104165808.2166686-1-robh@kernel.org/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
new file mode 100644
index 000000000000..5ca0be8892ab
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
@@ -0,0 +1,418 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/media/qcom,msm8996-camss.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm CAMSS ISP
+
+maintainers:
+  - Robert Foss <robert.foss@linaro.org>
+  - Todor Tomov <todor.too@gmail.com>
+
+description: |
+  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms
+
+properties:
+  compatible:
+    const: qcom,msm8996-camss
+
+  clocks:
+    description:
+      Input clocks for the hardware block.
+    minItems: 36
+    maxItems: 36
+
+  clock-names:
+    description:
+      Names of input clocks for the hardware block.
+    items:
+      - const: top_ahb
+      - const: ispif_ahb
+      - const: csiphy0_timer
+      - const: csiphy1_timer
+      - const: csiphy2_timer
+      - const: csi0_ahb
+      - const: csi0
+      - const: csi0_phy
+      - const: csi0_pix
+      - const: csi0_rdi
+      - const: csi1_ahb
+      - const: csi1
+      - const: csi1_phy
+      - const: csi1_pix
+      - const: csi1_rdi
+      - const: csi2_ahb
+      - const: csi2
+      - const: csi2_phy
+      - const: csi2_pix
+      - const: csi2_rdi
+      - const: csi3_ahb
+      - const: csi3
+      - const: csi3_phy
+      - const: csi3_pix
+      - const: csi3_rdi
+      - const: ahb
+      - const: vfe0
+      - const: csi_vfe0
+      - const: vfe0_ahb
+      - const: vfe0_stream
+      - const: vfe1
+      - const: csi_vfe1
+      - const: vfe1_ahb
+      - const: vfe1_stream
+      - const: vfe_ahb
+      - const: vfe_axi
+
+  interrupts:
+    description:
+      IRQs for the hardware block.
+    minItems: 10
+    maxItems: 10
+
+  interrupt-names:
+    description:
+      Names of IRQs for the hardware block.
+    items:
+      - const: csiphy0
+      - const: csiphy1
+      - const: csiphy2
+      - const: csid0
+      - const: csid1
+      - const: csid2
+      - const: csid3
+      - const: ispif
+      - const: vfe0
+      - const: vfe1
+
+  iommus:
+    maxItems: 4
+
+  power-domains:
+    maxItems: 2
+
+  ports:
+    description:
+      The CSI data input ports.
+
+    type: object
+
+    properties:
+      port@0:
+        type: object
+        description: Input node for receiving CSI data.
+        properties:
+          endpoint:
+            type: object
+
+            properties:
+              clock-lanes:
+                description: |-
+                  The physical clock lane index. The value must
+                  always be <7> as the hardware supports D-PHY
+                  and C-PHY, indexes are in a common set and
+                  D-PHY physical clock lane is labeled as 7.
+
+              data-lanes:
+                description: |-
+                  An array of physical data lanes indexes.
+                  Position of an entry determines the logical
+                  lane number, while the value of an entry
+                  indicates physical lane index. Lane swapping
+                  is supported. Physical lane indexes are:
+                  0, 1, 2, 3
+
+            required:
+              - clock-lanes
+              - data-lanes
+
+        required:
+          - endpoint
+          - reg
+
+      port@1:
+        type: object
+        description: Input node for receiving CSI data.
+        properties:
+          endpoint:
+            type: object
+
+            properties:
+              clock-lanes:
+                description: |-
+                  The physical clock lane index. The value must
+                  always be <7> as the hardware supports D-PHY
+                  and C-PHY, indexes are in a common set and
+                  D-PHY physical clock lane is labeled as 7.
+
+              data-lanes:
+                description: |-
+                  An array of physical data lanes indexes.
+                  Position of an entry determines the logical
+                  lane number, while the value of an entry
+                  indicates physical lane index. Lane swapping
+                  is supported. Physical lane indexes are:
+                  0, 1, 2, 3
+
+            required:
+              - clock-lanes
+              - data-lanes
+
+        required:
+          - endpoint
+          - reg
+
+      port@2:
+        type: object
+        description: Input node for receiving CSI data.
+        properties:
+          endpoint:
+            type: object
+
+            properties:
+              clock-lanes:
+                description: |-
+                  The physical clock lane index. The value must
+                  always be <7> as the hardware supports D-PHY
+                  and C-PHY, indexes are in a common set and
+                  D-PHY physical clock lane is labeled as 7.
+
+              data-lanes:
+                description: |-
+                  An array of physical data lanes indexes.
+                  Position of an entry determines the logical
+                  lane number, while the value of an entry
+                  indicates physical lane index. Lane swapping
+                  is supported. Physical lane indexes are:
+                  0, 1, 2, 3
+
+            required:
+              - clock-lanes
+              - data-lanes
+
+        required:
+          - endpoint
+          - reg
+
+      port@3:
+        type: object
+        description: Input node for receiving CSI data.
+        properties:
+          endpoint:
+            type: object
+
+            properties:
+              clock-lanes:
+                description: |-
+                  The physical clock lane index. The value must
+                  always be <7> as the hardware supports D-PHY
+                  and C-PHY, indexes are in a common set and
+                  D-PHY physical clock lane is labeled as 7.
+
+              data-lanes:
+                description: |-
+                  An array of physical data lanes indexes.
+                  Position of an entry determines the logical
+                  lane number, while the value of an entry
+                  indicates physical lane index. Lane swapping
+                  is supported. Physical lane indexes are:
+                  0, 1, 2, 3
+
+            required:
+              - clock-lanes
+              - data-lanes
+
+        required:
+          - endpoint
+          - reg
+
+  reg:
+    minItems: 14
+    maxItems: 14
+
+  reg-names:
+    items:
+      - const: csiphy0
+      - const: csiphy0_clk_mux
+      - const: csiphy1
+      - const: csiphy1_clk_mux
+      - const: csiphy2
+      - const: csiphy2_clk_mux
+      - const: csid0
+      - const: csid1
+      - const: csid2
+      - const: csid3
+      - const: ispif
+      - const: csi_clk_mux
+      - const: vfe0
+      - const: vfe1
+
+  vdda-supply:
+    description:
+      Definition of the regulator used as analog power supply.
+
+required:
+  - clock-names
+  - clocks
+  - compatible
+  - interrupt-names
+  - interrupts
+  - iommus
+  - power-domains
+  - reg
+  - reg-names
+  - vdda-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/qcom,gcc-msm8996.h>
+    #include <dt-bindings/clock/qcom,mmcc-msm8996.h>
+
+    camss: camss@a00000 {
+      compatible = "qcom,msm8996-camss";
+
+      clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
+        <&mmcc CAMSS_ISPIF_AHB_CLK>,
+        <&mmcc CAMSS_CSI0PHYTIMER_CLK>,
+        <&mmcc CAMSS_CSI1PHYTIMER_CLK>,
+        <&mmcc CAMSS_CSI2PHYTIMER_CLK>,
+        <&mmcc CAMSS_CSI0_AHB_CLK>,
+        <&mmcc CAMSS_CSI0_CLK>,
+        <&mmcc CAMSS_CSI0PHY_CLK>,
+        <&mmcc CAMSS_CSI0PIX_CLK>,
+        <&mmcc CAMSS_CSI0RDI_CLK>,
+        <&mmcc CAMSS_CSI1_AHB_CLK>,
+        <&mmcc CAMSS_CSI1_CLK>,
+        <&mmcc CAMSS_CSI1PHY_CLK>,
+        <&mmcc CAMSS_CSI1PIX_CLK>,
+        <&mmcc CAMSS_CSI1RDI_CLK>,
+        <&mmcc CAMSS_CSI2_AHB_CLK>,
+        <&mmcc CAMSS_CSI2_CLK>,
+        <&mmcc CAMSS_CSI2PHY_CLK>,
+        <&mmcc CAMSS_CSI2PIX_CLK>,
+        <&mmcc CAMSS_CSI2RDI_CLK>,
+        <&mmcc CAMSS_CSI3_AHB_CLK>,
+        <&mmcc CAMSS_CSI3_CLK>,
+        <&mmcc CAMSS_CSI3PHY_CLK>,
+        <&mmcc CAMSS_CSI3PIX_CLK>,
+        <&mmcc CAMSS_CSI3RDI_CLK>,
+        <&mmcc CAMSS_AHB_CLK>,
+        <&mmcc CAMSS_VFE0_CLK>,
+        <&mmcc CAMSS_CSI_VFE0_CLK>,
+        <&mmcc CAMSS_VFE0_AHB_CLK>,
+        <&mmcc CAMSS_VFE0_STREAM_CLK>,
+        <&mmcc CAMSS_VFE1_CLK>,
+        <&mmcc CAMSS_CSI_VFE1_CLK>,
+        <&mmcc CAMSS_VFE1_AHB_CLK>,
+        <&mmcc CAMSS_VFE1_STREAM_CLK>,
+        <&mmcc CAMSS_VFE_AHB_CLK>,
+        <&mmcc CAMSS_VFE_AXI_CLK>;
+
+      clock-names = "top_ahb",
+        "ispif_ahb",
+        "csiphy0_timer",
+        "csiphy1_timer",
+        "csiphy2_timer",
+        "csi0_ahb",
+        "csi0",
+        "csi0_phy",
+        "csi0_pix",
+        "csi0_rdi",
+        "csi1_ahb",
+        "csi1",
+        "csi1_phy",
+        "csi1_pix",
+        "csi1_rdi",
+        "csi2_ahb",
+        "csi2",
+        "csi2_phy",
+        "csi2_pix",
+        "csi2_rdi",
+        "csi3_ahb",
+        "csi3",
+        "csi3_phy",
+        "csi3_pix",
+        "csi3_rdi",
+        "ahb",
+        "vfe0",
+        "csi_vfe0",
+        "vfe0_ahb",
+        "vfe0_stream",
+        "vfe1",
+        "csi_vfe1",
+        "vfe1_ahb",
+        "vfe1_stream",
+        "vfe_ahb",
+        "vfe_axi";
+
+      interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 79 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 80 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 296 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 297 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 298 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 299 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 309 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 314 IRQ_TYPE_EDGE_RISING>,
+        <GIC_SPI 315 IRQ_TYPE_EDGE_RISING>;
+
+      interrupt-names = "csiphy0",
+        "csiphy1",
+        "csiphy2",
+        "csid0",
+        "csid1",
+        "csid2",
+        "csid3",
+        "ispif",
+        "vfe0",
+        "vfe1";
+
+      iommus = <&vfe_smmu 0>,
+         <&vfe_smmu 1>,
+         <&vfe_smmu 2>,
+         <&vfe_smmu 3>;
+
+      power-domains = <&mmcc VFE0_GDSC>,
+        <&mmcc VFE1_GDSC>;
+
+      reg = <0x00a34000 0x1000>,
+        <0x00a00030 0x4>,
+        <0x00a35000 0x1000>,
+        <0x00a00038 0x4>,
+        <0x00a36000 0x1000>,
+        <0x00a00040 0x4>,
+        <0x00a30000 0x100>,
+        <0x00a30400 0x100>,
+        <0x00a30800 0x100>,
+        <0x00a30c00 0x100>,
+        <0x00a31000 0x500>,
+        <0x00a00020 0x10>,
+        <0x00a10000 0x1000>,
+        <0x00a14000 0x1000>;
+
+      reg-names = "csiphy0",
+        "csiphy0_clk_mux",
+        "csiphy1",
+        "csiphy1_clk_mux",
+        "csiphy2",
+        "csiphy2_clk_mux",
+        "csid0",
+        "csid1",
+        "csid2",
+        "csid3",
+        "ispif",
+        "csi_clk_mux",
+        "vfe0",
+        "vfe1";
+
+      vdda-supply = <&reg_2v8>;
+
+      ports {
+        #address-cells = <1>;
+        #size-cells = <0>;
+      };
+    };
\ No newline at end of file