diff mbox series

[08/16] dt-bindings: imx: gpcv2: add support for optional resets

Message ID 20210429073050.21039-9-peng.fan@oss.nxp.com
State Superseded
Headers show
Series soc: imx: gpcv2: support i.MX8MM | expand

Commit Message

Peng Fan (OSS) April 29, 2021, 7:30 a.m. UTC
From: Lucas Stach <l.stach@pengutronix.de>

For some domains the resets of the devices in the domain are not
automatically triggered. Add an optional resets property to allow
the GPC driver to trigger those resets explicitly.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Frieder Schrempf May 3, 2021, 2:27 p.m. UTC | #1
On 29.04.21 09:30, Peng Fan (OSS) wrote:
> From: Lucas Stach <l.stach@pengutronix.de>

> 

> For some domains the resets of the devices in the domain are not

> automatically triggered. Add an optional resets property to allow

> the GPC driver to trigger those resets explicitly.

> 

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>


Rob has approved this if it includes a proper explanation on why the 
resets are not defined. See: 
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201105174434.1817539-9-l.stach@pengutronix.de/#24147743.

Can you add an explanation to the bindings in the next version?

> ---

>   Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++

>   1 file changed, 7 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml

> index a96e6dbf1858..4330c73a2c30 100644

> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml

> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml

> @@ -66,6 +66,13 @@ properties:

>   

>             power-supply: true

>   

> +          resets:

> +            description: |

> +              A number of phandles to resets that need to be asserted during

> +              power-up sequencing of the domain.

> +            minItems: 1

> +            maxItems: 4

> +

>           required:

>             - '#power-domain-cells'

>             - reg

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
index a96e6dbf1858..4330c73a2c30 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml
@@ -66,6 +66,13 @@  properties:
 
           power-supply: true
 
+          resets:
+            description: |
+              A number of phandles to resets that need to be asserted during
+              power-up sequencing of the domain.
+            minItems: 1
+            maxItems: 4
+
         required:
           - '#power-domain-cells'
           - reg