diff mbox series

[1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power supplies

Message ID 20210721200832.916644-2-jernej.skrabec@gmail.com
State Superseded
Headers show
Series arm64: dts: allwinner: h6: tanix-tx6: Enable eMMC | expand

Commit Message

Jernej Škrabec July 21, 2021, 8:08 p.m. UTC
While there is no publicly available schematic of this board, it's not
hard to determine voltage of GPIO port C, D and G (only ones which can
be set).

Port C and G are used for MMC/SDIO communication, so they use 1.8 V
power supply. It's not clear if port D is even used, but if it is, it's
pretty safe to assume it uses 3.3 V power supply. Value read from PIO
Group Withstand Voltage Mode Select register from within pre-installed
Android agrees with that assesment.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts      | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Maxime Ripard July 22, 2021, 8:21 a.m. UTC | #1
Hi,

On Wed, Jul 21, 2021 at 10:08:31PM +0200, Jernej Skrabec wrote:
> While there is no publicly available schematic of this board, it's not

> hard to determine voltage of GPIO port C, D and G (only ones which can

> be set).

> 

> Port C and G are used for MMC/SDIO communication, so they use 1.8 V

> power supply. It's not clear if port D is even used, but if it is, it's

> pretty safe to assume it uses 3.3 V power supply. Value read from PIO

> Group Withstand Voltage Mode Select register from within pre-installed

> Android agrees with that assesment.

> 

> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>

> ---

>  .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts      | 13 +++++++++++++

>  1 file changed, 13 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts

> index be81330db14f..a1dd8f472cc8 100644

> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts

> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts

> @@ -32,6 +32,13 @@ hdmi_con_in: endpoint {

>  		};

>  	};

>  

> +	reg_vcc1v8: vcc1v8 {

> +		compatible = "regulator-fixed";

> +		regulator-name = "vcc1v8";

> +		regulator-min-microvolt = <1800000>;

> +		regulator-max-microvolt = <1800000>;

> +	};

> +


I appreciate that the other 3.3V regulator has the same issue, but the
node name must reflect the class of the device. Maybe regulator-vcc1v8?

Maxime
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
index be81330db14f..a1dd8f472cc8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
@@ -32,6 +32,13 @@  hdmi_con_in: endpoint {
 		};
 	};
 
+	reg_vcc1v8: vcc1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	reg_vcc3v3: vcc3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc3v3";
@@ -99,6 +106,12 @@  &ohci3 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pc-supply = <&reg_vcc1v8>;
+	vcc-pd-supply = <&reg_vcc3v3>;
+	vcc-pg-supply = <&reg_vcc1v8>;
+};
+
 &r_ir {
 	linux,rc-map-name = "rc-tanix-tx5max";
 	status = "okay";