| Message ID | 20211006113950.10782-9-srinivas.kandagatla@linaro.org |
|---|---|
| State | Accepted |
| Commit | 96d0232564c3b16e9a4286f183e1e6d317521a5a |
| Headers | show |
| Series | ASoC: qcom: Add AudioReach support | expand |
On Wed, 06 Oct 2021 12:39:41 +0100, Srinivas Kandagatla wrote: > On AudioReach audio Framework, Audio Streams (PCM/Compressed) are managed by > Q6APM(Audio Process Manager) service. This patch adds bindings for this DAIs > exposed by the DSP. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/sound/qcom,q6apm-dai.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dts:19:18: fatal error: dt-bindings/soc/qcom,gpr.h: No such file or directory 19 | #include <dt-bindings/soc/qcom,gpr.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1441: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1537089 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 06/10/2021 20:08, Rob Herring wrote: > On Wed, 06 Oct 2021 12:39:41 +0100, Srinivas Kandagatla wrote: >> On AudioReach audio Framework, Audio Streams (PCM/Compressed) are managed by >> Q6APM(Audio Process Manager) service. This patch adds bindings for this DAIs >> exposed by the DSP. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> .../bindings/sound/qcom,q6apm-dai.yaml | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dts:19:18: fatal error: dt-bindings/soc/qcom,gpr.h: No such file or directory > 19 | #include <dt-bindings/soc/qcom,gpr.h> This is because QCOM SoC relevant non-audio patches in this series have been merged into the Qualcomm drivers-for-5.16 tree, as this series depends those patches an immutable tag is available at: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git tags/20210927135559.738-6-srinivas.kandagatla@linaro.org which is mentioned in cover-letter. --srni > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1441: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1537089 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
On Thu, Oct 7, 2021 at 3:23 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > > > On 06/10/2021 20:08, Rob Herring wrote: > > On Wed, 06 Oct 2021 12:39:41 +0100, Srinivas Kandagatla wrote: > >> On AudioReach audio Framework, Audio Streams (PCM/Compressed) are managed by > >> Q6APM(Audio Process Manager) service. This patch adds bindings for this DAIs > >> exposed by the DSP. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> --- > >> .../bindings/sound/qcom,q6apm-dai.yaml | 53 +++++++++++++++++++ > >> 1 file changed, 53 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dts:19:18: fatal error: dt-bindings/soc/qcom,gpr.h: No such file or directory > > 19 | #include <dt-bindings/soc/qcom,gpr.h> > > This is because QCOM SoC relevant non-audio patches in this series have > been merged into the Qualcomm drivers-for-5.16 tree, as this series > depends those patches an immutable tag is available at: > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git > tags/20210927135559.738-6-srinivas.kandagatla@linaro.org > > which is mentioned in cover-letter. My bot doesn't know how to read cover letters. I need a clue in the patch or you get this email to be sure the dependency is known. Rob
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml new file mode 100644 index 000000000000..5d972784321d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/sound/qcom,q6apm-dai.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm Audio Process Manager Digital Audio Interfaces binding + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + This binding describes the Qualcomm APM DAIs in DSP + +properties: + compatible: + const: qcom,q6apm-dais + + reg: + maxItems: 1 + + iommus: + maxItems: 1 + +required: + - compatible + - iommus + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/soc/qcom,gpr.h> + gpr { + compatible = "qcom,gpr"; + #address-cells = <1>; + #size-cells = <0>; + qcom,domain = <GPR_DOMAIN_ID_ADSP>; + service@1 { + compatible = "qcom,q6apm"; + reg = <1>; + + #address-cells = <1>; + #size-cells = <0>; + + apm-dai@1 { + compatible = "qcom,q6apm-dais"; + iommus = <&apps_smmu 0x1801 0x0>; + reg = <1>; + }; + }; + };