| Message ID | 20220907142124.2532620-3-luca.ceresoli@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for the internal RK3308 audio codec | expand |
Hello Krzysztof, thank you for reviewing my patches. On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > > From: Luca Ceresoli <luca.ceresoli@bootlin.com> [...] > > +properties: > > + compatible: > > + const: rockchip,rk3308-audio-graph-card > > Is "graph" part of device name or you just put it there because of other > schema? Indeed this comes from the "audio-graph-card" compatible string. > The compatible should reflect the device name, not some other > pieces in Linux or in bindings. Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)? Fixes for the other comments you made to this and the other patches are already queued for v2. Best regards, Luca
On 08/09/2022 17:20, Luca Ceresoli wrote: > Hello Krzysztof, > > thank you for reviewing my patches. > > On Thu, 8 Sep 2022 13:49:34 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: >>> From: Luca Ceresoli <luca.ceresoli@bootlin.com> > > [...] > >>> +properties: >>> + compatible: >>> + const: rockchip,rk3308-audio-graph-card >> >> Is "graph" part of device name or you just put it there because of other >> schema? > > Indeed this comes from the "audio-graph-card" compatible string. > >> The compatible should reflect the device name, not some other >> pieces in Linux or in bindings. > > Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop > the "graph-" infix)? > > Fixes for the other comments you made to this and the other patches are > already queued for v2. Yes, either rockchip,rk3308-audio-card or rockchip,rk3308-audio Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml new file mode 100644 index 000000000000..8445a69dcdbb --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/rockchip,rk3308-audio-graph-card.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip RK3308 Audio card based on internal I2S + +maintainers: + - Luca Ceresoli <luca.ceresoli@bootlin.com> + +allOf: + - $ref: /schemas/sound/audio-graph.yaml# + +properties: + compatible: + const: rockchip,rk3308-audio-graph-card + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + sound { + compatible = "rockchip,rk3308-audio-graph-card"; + dais = <&i2s_8ch_2_port>; + }; + + i2s_8ch_2 { + i2s_8ch_2_port: port { + i2s_8ch_2_endpoint: endpoint { + remote-endpoint = <&acodec_endpoint>; + dai-format = "i2s"; + + /* The RK3308 acodec has no clock dividers, use the CPU */ + bitclock-master = <&i2s_8ch_2_endpoint>; + frame-master = <&i2s_8ch_2_endpoint>; + }; + }; + }; + + acodec { + port { + acodec_endpoint: endpoint { + remote-endpoint = <&i2s_8ch_2_endpoint>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d53a8e74cb1e..079bdd95dc49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17594,6 +17594,11 @@ S: Maintained F: Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml F: include/dt-bindings/sound/rockchip,rk3308-codec.h +ROCKCHIP RK3308 SOUND CARD DRIVER +M: Luca Ceresoli <luca.ceresoli@bootlin.com> +S: Maintained +F: Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml + ROCKCHIP VIDEO DECODER DRIVER M: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> L: linux-media@vger.kernel.org