From patchwork Thu Mar 30 23:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 669194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7C7C7619A for ; Thu, 30 Mar 2023 23:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbjC3XUU (ORCPT ); Thu, 30 Mar 2023 19:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbjC3XUT (ORCPT ); Thu, 30 Mar 2023 19:20:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758AF10AA7 for ; Thu, 30 Mar 2023 16:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680218370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Lx021jiSXTc6pYyl7LmIv03tfyJDHewW1CEauW0rIQw=; b=HdP7ivvFtuavef/65yYWZ25hyRexJIqhdGxbBdwRl7PaKBjxK99tfxwEIeuSMKYim+SnCW 5V9wnkNnaTW8dKcRyGaLg+m8fdbTTXuegxowpvLh8f4LW06YfXA44EqYhiVegfIW0+dEt/ ezREHuK9+YQzcLkkum2KqaJm21RPi2I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-kfIWckYwN4Wu6JsdYAP5ww-1; Thu, 30 Mar 2023 19:19:29 -0400 X-MC-Unique: kfIWckYwN4Wu6JsdYAP5ww-1 Received: by mail-wm1-f72.google.com with SMTP id bi27-20020a05600c3d9b00b003ef6ee937b8so6961479wmb.2 for ; Thu, 30 Mar 2023 16:19:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680218367; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lx021jiSXTc6pYyl7LmIv03tfyJDHewW1CEauW0rIQw=; b=jtR17HqC0MT8GuHymq8pT4R7+cokwgQy5eQAMWo5g8EuqKAYUmg8kmdVLuKRjBYpgX jhXJjp5n7Y6hEQCTqPzJ4GsaWUoChXN2uwHs9Gf/3cB0gXB0RgvXXqoV6F/zaOjT0obh ZTjoK9sPcbizJwAH3ILhu+T0PDoCq65noF16iXTm6Fz1yStTWiwBZT8B8HnrrSmNrJYy 7VGbkOwFWEDW5eN6rlGUNZ0Ax4AQyqoHvbSrP5s1GCHRzu7mz1ifH17WmAV7OIlpaoJ/ dOljpnPSnDEGP/4EfCDrYqKoF75gKlRWcB5qhCx7EhRD0bYyuW+O5xagHqMbfz+n6dBc tLxQ== X-Gm-Message-State: AAQBX9eChOEC1cCqqVysjLD5odlvYyqx0OAbCeV+yQME+kNYk101SbuY JWE/cSs8LVGIWqcr0PsPmrLXfTdVOBF8qgx2nfbJKmxViHdFGwM1mOdwAfh8gEcSAaW+AbsPl/Z 0/GClPcfuN1zbcAbm4gusGQ== X-Received: by 2002:adf:d4cc:0:b0:2d0:2d4:958c with SMTP id w12-20020adfd4cc000000b002d002d4958cmr18784575wrk.60.1680218367402; Thu, 30 Mar 2023 16:19:27 -0700 (PDT) X-Google-Smtp-Source: AKy350YIJANJD5ndsOw5e6X1tNl3/XEP4RjGZCkemP4f0WMNIUtUXUh4J/Z7TRhR6CnBmTTGwrSw1g== X-Received: by 2002:adf:d4cc:0:b0:2d0:2d4:958c with SMTP id w12-20020adfd4cc000000b002d002d4958cmr18784568wrk.60.1680218367087; Thu, 30 Mar 2023 16:19:27 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id f9-20020adfe909000000b002c7163660a9sm536059wrm.105.2023.03.30.16.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 16:19:26 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Brian Norris , Daniel Lezcano , Douglas Anderson , Enric Balletbo i Serra , Heiko Stuebner , Judy Hsiao , Krzysztof Kozlowski , Lin Huang , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, zain wang Subject: [PATCH v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property Date: Fri, 31 Mar 2023 01:19:23 +0200 Message-Id: <20230330231924.2404747-1-javierm@redhat.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org There is neither a driver that parses this nor a DT binding schema that documents it, so let's remove from the DTS files that make use of this. The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms, defined in the pwm-backlight DT binding. If the delays are really needed then those properties should be used instead. Brian Norris mentioned though that looking at the first downstream usage of the pwm-delay-us property for RK3399 Gru systems in ChromiumOS tree, he couldn't find a spec reference that said that this was really needed. So perhaps it was unnecessary added and a simple removal would be enough. Signed-off-by: Javier Martinez Canillas Reviewed-by: Brian Norris --- Changes in v2: - Update commit message with the information provided by Brian Norries. - Add Reviewed-by tag from Brian Norries. arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 1 - 3 files changed, 3 deletions(-) base-commit: b2bc47e9b2011a183f9d3d3454a294a938082fb9 diff --git a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi index 083452c67711..e47d1398aeca 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi @@ -61,7 +61,6 @@ backlight: backlight { pinctrl-names = "default"; pinctrl-0 = <&bl_en>; pwms = <&pwm0 0 1000000 PWM_POLARITY_INVERTED>; - pwm-delay-us = <10000>; }; emmc_pwrseq: emmc-pwrseq { diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi index ee6095baba4d..5c1929d41cc0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi @@ -198,7 +198,6 @@ backlight: backlight { power-supply = <&pp3300_disp>; pinctrl-names = "default"; pinctrl-0 = <&bl_en>; - pwm-delay-us = <10000>; }; gpio_keys: gpio-keys { diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi index a47d9f758611..c5e7de60c121 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi @@ -167,7 +167,6 @@ backlight: backlight { pinctrl-names = "default"; pinctrl-0 = <&bl_en>; pwms = <&pwm1 0 1000000 0>; - pwm-delay-us = <10000>; }; dmic: dmic {