diff mbox series

[1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port

Message ID 20230723195416.7831-1-zajec5@gmail.com
State New
Headers show
Series [1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port | expand

Commit Message

Rafał Miłecki July 23, 2023, 7:54 p.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

Primary Ethernet interface is connected to the port 8 (not 5).

Fixes: 64612828628c ("ARM: dts: BCM53573: Add Tenda AC9 switch ports")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Florian Fainelli July 28, 2023, 5:21 p.m. UTC | #1 
From: Florian Fainelli <f.fainelli@gmail.com>

On Sun, 23 Jul 2023 21:54:14 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Primary Ethernet interface is connected to the port 8 (not 5).
> 
> Fixes: 64612828628c ("ARM: dts: BCM53573: Add Tenda AC9 switch ports")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/master, thanks!
--
Florian
Florian Fainelli July 28, 2023, 5:22 p.m. UTC | #2 
From: Florian Fainelli <f.fainelli@gmail.com>

On Sun, 23 Jul 2023 21:54:15 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> BCM53125 always has 5 ports with GPHYs (for LAN/WAN ports) and 2 IMP
> ports. It seems the best place to describe that in the main .dtsi.
> Device specific bits can go to device .dts files. This will help
> avoiding some code duplication.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/master, thanks!
--
Florian
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
index dab2e5f63a72..06b1a582809c 100644
--- a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
@@ -135,8 +135,8 @@  port@4 {
 			label = "lan4";
 		};
 
-		port@5 {
-			reg = <5>;
+		port@8 {
+			reg = <8>;
 			label = "cpu";
 			ethernet = <&gmac0>;
 		};