| Message ID | 20231007-rtc-7301-regwidth-v2-1-c913aa95f666@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support byte access in the RTC7301 driver | expand |
On Sat, Oct 07, 2023 at 02:30:49PM +0200, Linus Walleij wrote: > This rewrites the Epson RTC7301 bindings to use YAML schema, > and adds a property for "reg-io-width" as used in several > other bindings to account for different register strides. > > The USRobotics USR8200 uses the byte IO width. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../devicetree/bindings/rtc/epson,rtc7301.txt | 16 ------- > .../devicetree/bindings/rtc/epson,rtc7301.yaml | 50 ++++++++++++++++++++++ > 2 files changed, 50 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt b/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt > deleted file mode 100644 > index 5f9df3f1467c..000000000000 > --- a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt > +++ /dev/null > @@ -1,16 +0,0 @@ > -EPSON TOYOCOM RTC-7301SF/DG > - > -Required properties: > - > -- compatible: Should be "epson,rtc7301sf" or "epson,rtc7301dg" > -- reg: Specifies base physical address and size of the registers. > -- interrupts: A single interrupt specifier. > - > -Example: > - > -rtc: rtc@44a00000 { > - compatible = "epson,rtc7301dg"; > - reg = <0x44a00000 0x10000>; > - interrupt-parent = <&axi_intc_0>; > - interrupts = <3 2>; > -}; > diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml > new file mode 100644 > index 000000000000..0937b094821d > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/epson,rtc7301.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Epson Toyocom RTC-7301SF/DG > + > +description: > + The only difference between the two variants is the packaging. > + The DG variant is a DIL package, and the SF variant is a flat > + package. > + > +maintainers: > + - Akinobu Mita <akinobu.mita@gmail.com> > + > +properties: > + compatible: > + enum: > + - epson,rtc7301dg > + - epson,rtc7301sf > + > + reg: > + maxItems: 1 > + > + reg-io-width: > + description: > + The size (in bytes) of the IO accesses that should be performed > + on the device. If not specified, the default is 4. No prose for what can be a constraint: default: 4 With that, Reviewed-by: Rob Herring <robh@kernel.org> > + enum: [1, 4]
diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt b/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt deleted file mode 100644 index 5f9df3f1467c..000000000000 --- a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt +++ /dev/null @@ -1,16 +0,0 @@ -EPSON TOYOCOM RTC-7301SF/DG - -Required properties: - -- compatible: Should be "epson,rtc7301sf" or "epson,rtc7301dg" -- reg: Specifies base physical address and size of the registers. -- interrupts: A single interrupt specifier. - -Example: - -rtc: rtc@44a00000 { - compatible = "epson,rtc7301dg"; - reg = <0x44a00000 0x10000>; - interrupt-parent = <&axi_intc_0>; - interrupts = <3 2>; -}; diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml new file mode 100644 index 000000000000..0937b094821d --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/epson,rtc7301.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Epson Toyocom RTC-7301SF/DG + +description: + The only difference between the two variants is the packaging. + The DG variant is a DIL package, and the SF variant is a flat + package. + +maintainers: + - Akinobu Mita <akinobu.mita@gmail.com> + +properties: + compatible: + enum: + - epson,rtc7301dg + - epson,rtc7301sf + + reg: + maxItems: 1 + + reg-io-width: + description: + The size (in bytes) of the IO accesses that should be performed + on the device. If not specified, the default is 4. + enum: [1, 4] + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + rtc: rtc@44a00000 { + compatible = "epson,rtc7301dg"; + reg = <0x44a00000 0x10000>; + reg-io-width = <4>; + interrupt-parent = <&axi_intc_0>; + interrupts = <3 2>; + };
This rewrites the Epson RTC7301 bindings to use YAML schema, and adds a property for "reg-io-width" as used in several other bindings to account for different register strides. The USRobotics USR8200 uses the byte IO width. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../devicetree/bindings/rtc/epson,rtc7301.txt | 16 ------- .../devicetree/bindings/rtc/epson,rtc7301.yaml | 50 ++++++++++++++++++++++ 2 files changed, 50 insertions(+), 16 deletions(-)