| Message ID | 96519ac55be90a63fa44afe01480c30d08535465.1640881913.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 94a4950a4acff39b5847cc1fee4f65e160813493 |
| Headers | show |
| Series | [v2,1/2] of: base: Fix phandle argument length mismatch error message | expand |
diff --git a/drivers/of/base.c b/drivers/of/base.c index 61de453b885c..81b956ab2348 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1349,9 +1349,9 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it) * property data length */ if (it->cur + count > it->list_end) { - pr_err("%pOF: %s = %d found %d\n", + pr_err("%pOF: %s = %d found %td\n", it->parent, it->cells_name, - count, it->cell_count); + count, it->list_end - it->cur); goto err; } }
The cell_count field of of_phandle_iterator is the number of cells we expect in the phandle arguments list when cells_name is missing. The error message should show the number of cells we actually see. Fixes: af3be70a321 ("of: Improve of_phandle_iterator_next() error message") Cc: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- v2: Use correct length modifier for ptrdiff_t --- drivers/of/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)