From patchwork Thu Jul 5 05:09:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 141107 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1501802ljj; Wed, 4 Jul 2018 22:09:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcmIUfmSlw/4VUy+dtBCkBg5kEr+XOgP6P2MQQ/hNY1z6GfLekwkEAeP5oHs9S1dgYUGG9i X-Received: by 2002:a63:1e08:: with SMTP id e8-v6mr4127693pge.281.1530767380594; Wed, 04 Jul 2018 22:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530767380; cv=none; d=google.com; s=arc-20160816; b=iTp8w10l2fkXgQCKORuw15kd73/7DX7tb0eKbia0qdJGEUAWLM4URzyh8g2H6e/Fhc TbFfO7MGmbTTJ/s6E8coO5VQhRjzxgssG0iqUzKRTU18m//LYxCxBAIS8DonSxcEcdwD QeWr9zHNTv5lALMR6AEOBLIlX8EqB7xsu4+8wUpvfyDiNz8LNWncunc4U3U1JSHsbgaH mz2Je9mphYGwr9G1GP0cxpZDzsd/ZMf1AYfhAzF+9bBgzKYNbDFqiPxv69aD7KWJCW2z mPTCyITy8njbMemeiwXQws6RWmzFZCfZ5OsLn2NNcoNPGwNAhO8fbds18/7MnVLIvPZ1 PfLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=9g0G5YQv67wgje7eyBzdA8wm7yl8TOPEWmeFqfcMNs8=; b=oCK4CpzqJwKjYp0DQnrKnMRmB5CMFaDaydHmPNRu0REvo1EO6veG5dAPXhoqi11XeR nW5lvHvrwTfwrcBeko9qxITX1ZoSuNaAid4jfO8AZyIcoDPtT9/SDF2BddATXblB8c4c NPe0j+7H0brEz7JYwv67heWWUgxo+gQOOactAaZ8O2LH604RkAHzi4gHApaWEmNJDoVN mXSUove5JzmZ7QOKlXi1aQQ+pBu2IaI6MGbXAzwIAQ1gkRYa9ut/4Z1mfOp8Mgm5El32 sG1kDKMuyac4rW5mdraT6p+YQkM0gZvSSdqKrZEjctaINHfzTAlHDt/qRI3YIDhXVNLc 8wVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="C1B6R/Qi"; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si5119160plx.351.2018.07.04.22.09.40; Wed, 04 Jul 2018 22:09:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="C1B6R/Qi"; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbeGEFJh (ORCPT + 5 others); Thu, 5 Jul 2018 01:09:37 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38243 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbeGEFJf (ORCPT ); Thu, 5 Jul 2018 01:09:35 -0400 Received: by mail-pf0-f195.google.com with SMTP id j17-v6so4328898pfn.5 for ; Wed, 04 Jul 2018 22:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+5ItNYTYeiKz+mT0Uq7k5mUE+h7almHMaSv0njAJGPc=; b=C1B6R/QiTyttjB+gnxPIQfMOeSYwVVfnSeY4onNWi6WmZ4DTgRecmoX9QKinq8HODh sug3aU2uKP0C+2tj3WA+GE/aAPhkD0kQea79sOTWq0btUo8uDSgagQ4MHUz2dB6vg8lq p8RLTYovNwyyigN+Ku0KcHBXqVqtHRFVgNUxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+5ItNYTYeiKz+mT0Uq7k5mUE+h7almHMaSv0njAJGPc=; b=JNQAsm18hVjcBydPob3IQfacFbK3sQP8KdNpDLoYh1k8N3Wfod34VYCop85h2uJz8t g4g3l36+sFfcwWkBhHi7aHbOEXKTaMQYr6L1FvJo7yi4BdZRB8E9EtdyTkbRC0sF71Ll 8qpGYviqwLJEh0eWNM+xOKTti4jBdenkf9wpm0yahn3wihwsownAwv27GmkY93gpYBm1 vWfXSd0KLYUsSDdu6yXWTArNEoTucTPbAa48/8JRKuLhlZvX2C4R3vnLrXLbFG9uhx2K IpXBHn3Fku27sNWpVgQyXhO/peO6uF/GnsCQwyhoHOYIsQzuU7+ANaoHYu/r6DIxTqpn dUMA== X-Gm-Message-State: APt69E3unkMJMu7f7Bst9LRUpFcb9luYuI2awUGaT+ybT5NmCBJs4cQe mB9V5CeX8qjc3IrSci/sh1wXSg== X-Received: by 2002:a62:a05:: with SMTP id s5-v6mr4791283pfi.147.1530767374020; Wed, 04 Jul 2018 22:09:34 -0700 (PDT) Received: from localhost ([122.172.117.17]) by smtp.gmail.com with ESMTPSA id s22-v6sm8983090pgs.34.2018.07.04.22.09.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 22:09:33 -0700 (PDT) From: Viresh Kumar To: Zhang Rui , Eduardo Valentin , robh@kernel.org, Wei Xu Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Daniel Lezcano , devicetree@vger.kernel.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps Date: Thu, 5 Jul 2018 10:39:24 +0530 Message-Id: X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a2c In-Reply-To: References: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Each CPU can (and does) participate in cooling down the system but the DT only captures the CPU0 in the cooling maps. Things work by chance as under normal circumstances its the CPU0 which is used by the operating systems to probe the cooling devices. But as soon as that ordering changes and any other CPU is used to bring up the cooling device, we will start seeing errors. On the other hand, the hardware is partially defined in DT in these cases and we must do a better job by capturing all devices. Add all devices (CPUs here) in the cooling maps which are also affected by the trip point. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.18.0.rc1.242.g61856ae69a2c -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Daniel Lezcano diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index 247024df714f..919d36b91bf3 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -886,7 +886,14 @@ cooling-maps { map0 { trip = <&target>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };