| Message ID | 20250317-plat2faux_dev-v1-0-5fe67c085ad5@arm.com |
|---|---|
| Headers | show |
| Series | drivers: Transition to the faux device interface | expand |
On Mon, Mar 17, 2025 at 10:13:12AM +0000, Sudeep Holla wrote: > Recently when debugging why one of the scmi platform device was not > showing up under /sys/devices/platform/firmware:scmi instead was > appearing directly under /sys/devices/platform, I noticed the new > faux interface /sys/devices/faux. > > Looking through the discussion and the background, I got excited and > took the opportunity to clear all the platform devices under > /sys/devices/platform on the Arm Juno/FVP platforms that are really > faux devices. Only the platform devices created for the device nodes > from the DT remain under /sys/devices/platform after these changes. > > All the patches are independent of each other. That's great, but you need to send these all independently to each subsystem as needed. Having it all in one series doesn't work for any of the maintainers of any of the subsystems. And I'm glad to see this work happening, thanks for doing that! greg k-h
On Mon, Mar 17, 2025 at 10:13:17AM +0000, Sudeep Holla wrote: > MODULE_DESCRIPTION("Confidential computing EFI secret area access"); > MODULE_AUTHOR("IBM"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:efi_secret"); > +MODULE_ALIAS("faux:efi_secret"); Again, no need for a module alias anymore.
On Mon, Mar 17, 2025 at 10:13:12AM +0000, Sudeep Holla wrote:
> All the patches are independent of each other.
If that's the case don't send them in a series, it makes things more
complicated to apply and the CCs cause more mail. Split independent
things up by subsystem.
On Mon, Mar 17, 2025 at 02:01:55PM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 17, 2025 at 10:13:12AM +0000, Sudeep Holla wrote: > > Recently when debugging why one of the scmi platform device was not > > showing up under /sys/devices/platform/firmware:scmi instead was > > appearing directly under /sys/devices/platform, I noticed the new > > faux interface /sys/devices/faux. > > > > Looking through the discussion and the background, I got excited and > > took the opportunity to clear all the platform devices under > > /sys/devices/platform on the Arm Juno/FVP platforms that are really > > faux devices. Only the platform devices created for the device nodes > > from the DT remain under /sys/devices/platform after these changes. > > > > All the patches are independent of each other. > > That's great, but you need to send these all independently to each > subsystem as needed. Having it all in one series doesn't work for any > of the maintainers of any of the subsystems. > Sure I can do that. I initially had idea of creating a macro that made all of them depend on the macro but later dropped as I wanted to check if that is good or a bad idea. I just asked you in the thread 2/9. > And I'm glad to see this work happening, thanks for doing that! > Thanks for adding faux interface!
On Mon, 17 Mar 2025 at 11:13, Sudeep Holla <sudeep.holla@arm.com> wrote: > > The "efivars" platform device is created but never tracked or used, > as there is no driver associated with it. Since this device serves > no functional purpose, removing its creation without affecting any > functionality. > > Cc: Ard Biesheuvel <ardb@kernel.org> > Cc: linux-efi@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/efi/efi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index 7309394b8fc98cf7a3424af209b752f0251c8c89..eec173cb1f398d3b4f28b42c917e50e1728dc277 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -446,7 +446,6 @@ static int __init efisubsys_init(void) > error = efivar_ssdt_load(); > if (error) > pr_err("efi: failed to load SSDT, error %d.\n", error); > - platform_device_register_simple("efivars", 0, NULL, 0); > } > > BLOCKING_INIT_NOTIFIER_HEAD(&efivar_ops_nh); > IIRC the efi-pstore module autoloads based on this platform device
On Mon, Mar 17, 2025 at 06:06:24PM +0100, Ard Biesheuvel wrote: > On Mon, 17 Mar 2025 at 11:13, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > The "efivars" platform device is created but never tracked or used, > > as there is no driver associated with it. Since this device serves > > no functional purpose, removing its creation without affecting any > > functionality. > > > > Cc: Ard Biesheuvel <ardb@kernel.org> > > Cc: linux-efi@vger.kernel.org > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > drivers/firmware/efi/efi.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > index 7309394b8fc98cf7a3424af209b752f0251c8c89..eec173cb1f398d3b4f28b42c917e50e1728dc277 100644 > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -446,7 +446,6 @@ static int __init efisubsys_init(void) > > error = efivar_ssdt_load(); > > if (error) > > pr_err("efi: failed to load SSDT, error %d.\n", error); > > - platform_device_register_simple("efivars", 0, NULL, 0); > > } > > > > BLOCKING_INIT_NOTIFIER_HEAD(&efivar_ops_nh); > > > > IIRC the efi-pstore module autoloads based on this platform device Indeed I see now, thanks. My bad grep skills didn't work well to catch this. I will update accordingly.
On Mon, 17 Mar 2025 10:13:12 +0000, Sudeep Holla wrote: > Recently when debugging why one of the scmi platform device was not > showing up under /sys/devices/platform/firmware:scmi instead was > appearing directly under /sys/devices/platform, I noticed the new > faux interface /sys/devices/faux. > > Looking through the discussion and the background, I got excited and > took the opportunity to clear all the platform devices under > /sys/devices/platform on the Arm Juno/FVP platforms that are really > faux devices. Only the platform devices created for the device nodes > from the DT remain under /sys/devices/platform after these changes. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [6/9] ASoC: soc-utils: Transition to the faux device interface commit: 18abb3797f1ceca97a705aa1c14cbec5c6fcab79 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Recently when debugging why one of the scmi platform device was not showing up under /sys/devices/platform/firmware:scmi instead was appearing directly under /sys/devices/platform, I noticed the new faux interface /sys/devices/faux. Looking through the discussion and the background, I got excited and took the opportunity to clear all the platform devices under /sys/devices/platform on the Arm Juno/FVP platforms that are really faux devices. Only the platform devices created for the device nodes from the DT remain under /sys/devices/platform after these changes. All the patches are independent of each other. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- Greg Kroah-Hartman (1): regulator: dummy: convert to use the faux device interface Sudeep Holla (8): cpuidle: psci: Transition to the faux device interface hwrng: arm-smccc-trng - transition to the faux device interface efi: Remove redundant creation of the "efivars" platform device rtc: efi: Transition to the faux device interface virt: efi_secret: Transition to the faux device interface ASoC: soc-utils: Transition to the faux device interface net: phy: fixed_phy: transition to the faux device interface ACPI: APEI: EINJ: Transition to the faux device interface drivers/acpi/apei/einj-core.c | 32 +++++++++--------------- drivers/char/hw_random/arm_smccc_trng.c | 40 +++++++++++++++++++++--------- drivers/cpuidle/cpuidle-psci.c | 26 +++++++------------- drivers/firmware/efi/efi.c | 10 -------- drivers/firmware/smccc/smccc.c | 21 ---------------- drivers/net/phy/fixed_phy.c | 16 ++++++------ drivers/regulator/dummy.c | 37 +++++++--------------------- drivers/rtc/rtc-efi.c | 31 ++++++++++++++++------- drivers/virt/coco/efi_secret/efi_secret.c | 41 ++++++++++++++++++------------- sound/soc/soc-utils.c | 34 +++++++++---------------- 10 files changed, 124 insertions(+), 164 deletions(-) --- base-commit: 80e54e84911a923c40d7bee33a34c1b4be148d7a change-id: 20250315-plat2faux_dev-8c28b35be96a