| Message ID | 20220110095625.278836-1-javierm@redhat.com |
|---|---|
| Headers | show |
| Series | video: A couple of fixes for the vga16fb driver | expand |
Hi, On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote: > This patch series contains two fixes for the vga16fb driver. I looked at > the driver due a regression reported [0], caused by commit d391c5827107 > ("drivers/firmware: move x86 Generic System Framebuffers support"). > > The mentioned commit didn't change any logic but just moved the platform > device registration that matches the vesafb and efifb drivers to happen > later. And this caused the vga16fb driver to be probed even in machines > that don't have an EGA or VGA video adapter. > > This is a v2 of the patch series that addresses issues pointed out by > Geert Uytterhoeven. > > Patch #1 is fixing the wrong check to determine if either EGA or VGA is > used and patch #2 adds a check to the driver to only be loaded for EGA > and VGA 16 color graphic cards. For both patches, Acked-by: Maxime Ripard <maxime@cerno.tech> Maxime
Hi Javier, Geert, et al, Javier Martinez Canillas wrote: > Changes in v2: > - Make the change only for x86 (Geert Uytterhoeven) > - Only check the suppported video mode for x86 (Geert Uytterhoeven). I just updated Bug 215001 to reflect that I have tested this new, V2 patch against 4 systems, one more than last time - 2 BIOS/VGAC and 2 UEFI - and it works perfectly on all four. Thanks, Javier, for the excellent work! I didn't test with non-X86, but the code appears to bypass the patch on non-X86, so should work fine for Geert. Kris Tested-By: Kris Karas <bugs-a21@moonlit-rail.com>
Hi Kris, On Wed, Jan 12, 2022 at 3:19 AM Kris Karas (Bug reporting) <bugs-a21@moonlit-rail.com> wrote: > Javier Martinez Canillas wrote: > > Changes in v2: > > - Make the change only for x86 (Geert Uytterhoeven) > > - Only check the suppported video mode for x86 (Geert Uytterhoeven). > > I just updated Bug 215001 to reflect that I have tested this new, V2 > patch against 4 systems, one more than last time - 2 BIOS/VGAC and 2 > UEFI - and it works perfectly on all four. > > Thanks, Javier, for the excellent work! > I didn't test with non-X86, but the code appears to bypass the patch on > non-X86, so should work fine for Geert. Note that I can no longer test the PPC use case, as the hardware died a long time ago. > Tested-By: Kris Karas <bugs-a21@moonlit-rail.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Kris, On 1/12/22 03:19, Kris Karas (Bug reporting) wrote: > Hi Javier, Geert, et al, > > Javier Martinez Canillas wrote: >> Changes in v2: >> - Make the change only for x86 (Geert Uytterhoeven) >> - Only check the suppported video mode for x86 (Geert Uytterhoeven). > > I just updated Bug 215001 to reflect that I have tested this new, V2 > patch against 4 systems, one more than last time - 2 BIOS/VGAC and 2 > UEFI - and it works perfectly on all four. > > Thanks, Javier, for the excellent work! > I didn't test with non-X86, but the code appears to bypass the patch on > non-X86, so should work fine for Geert. > > Kris > > Tested-By: Kris Karas <bugs-a21@moonlit-rail.com> > Thanks a lot for testing again! I've applied patch #1 to drm-misc-next and #2 to drm-misc-fixes. Best regards,
This patch series contains two fixes for the vga16fb driver. I looked at the driver due a regression reported [0], caused by commit d391c5827107 ("drivers/firmware: move x86 Generic System Framebuffers support"). The mentioned commit didn't change any logic but just moved the platform device registration that matches the vesafb and efifb drivers to happen later. And this caused the vga16fb driver to be probed even in machines that don't have an EGA or VGA video adapter. This is a v2 of the patch series that addresses issues pointed out by Geert Uytterhoeven. Patch #1 is fixing the wrong check to determine if either EGA or VGA is used and patch #2 adds a check to the driver to only be loaded for EGA and VGA 16 color graphic cards. [0]: https://bugzilla.kernel.org/show_bug.cgi?id=215001 Best regards, Javier Changes in v2: - Make the change only for x86 (Geert Uytterhoeven) - Only check the suppported video mode for x86 (Geert Uytterhoeven). Javier Martinez Canillas (2): video: vga16fb: Fix logic that checks for the display standard video: vga16fb: Only probe for EGA and VGA 16 color graphic cards drivers/video/fbdev/vga16fb.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)