diff mbox series

[v2,070/101] fbdev/savagefb: Duplicate video-mode option string

Message ID 20230309160201.5163-71-tzimmermann@suse.de
State New
Headers show
Series fbdev: Fix memory leak in option parsing | expand

Commit Message

Thomas Zimmermann March 9, 2023, 4:01 p.m. UTC 
Assume that the driver does not own the option string or its substrings
and hence duplicate the option string for the video mode. Allocate the
copy's memory with kstrdup() and free it in the module's exit function.

Done in preparation of switching the driver to struct option_iter and
constifying the option string.

v2:
	* replace static memory with kstrdup()/kfree() (Geert)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/savage/savagefb_driver.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c
index 4a27b68798bf..0ca5894114c9 100644
--- a/drivers/video/fbdev/savage/savagefb_driver.c
+++ b/drivers/video/fbdev/savage/savagefb_driver.c
@@ -65,6 +65,7 @@ 
 /* --------------------------------------------------------------------- */
 
 
+static char *mode_option_buf;
 static char *mode_option = NULL;
 
 #ifdef MODULE
@@ -2530,6 +2531,7 @@  static void __exit savage_done(void)
 {
 	DBG("savage_done");
 	pci_unregister_driver(&savagefb_driver);
+	kfree(mode_option_buf);
 }
 
 
@@ -2544,7 +2546,9 @@  static int __init savagefb_setup(char *options)
 		return 0;
 
 	while ((this_opt = strsep(&options, ",")) != NULL) {
-		mode_option = this_opt;
+		kfree(mode_option_buf);
+		mode_option_buf = kstrdup(this_opt, GFP_KERNEL); // ignore errors
+		mode_option = mode_option_buf;
 	}
 #endif /* !MODULE */
 	return 0;