| Message ID | 20240219093941.3684-2-tzimmermann@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | fbdev: Clean up include dependencies in header | expand |
cc'ing backlight maintainers Am 19.02.24 um 10:37 schrieb Thomas Zimmermann: > Resolves the proxy include via <linux/fb.h>, which does not require the > backlight header. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/backlight/corgi_lcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c > index 0a57033ae31d1..dd765098ad989 100644 > --- a/drivers/video/backlight/corgi_lcd.c > +++ b/drivers/video/backlight/corgi_lcd.c > @@ -11,6 +11,7 @@ > * by Eric Miao <eric.miao@marvell.com> > */ > > +#include <linux/backlight.h> > #include <linux/module.h> > #include <linux/kernel.h> > #include <linux/init.h>
On Wed, 21 Feb 2024, Thomas Zimmermann wrote: > cc'ing backlight maintainers I cannot review/accept patches like this. Please submit a [RESEND]. > Am 19.02.24 um 10:37 schrieb Thomas Zimmermann: > > Resolves the proxy include via <linux/fb.h>, which does not require the > > backlight header. > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > --- > > drivers/video/backlight/corgi_lcd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c > > index 0a57033ae31d1..dd765098ad989 100644 > > --- a/drivers/video/backlight/corgi_lcd.c > > +++ b/drivers/video/backlight/corgi_lcd.c > > @@ -11,6 +11,7 @@ > > * by Eric Miao <eric.miao@marvell.com> > > */ > > +#include <linux/backlight.h> > > #include <linux/module.h> > > #include <linux/kernel.h> > > #include <linux/init.h> > > -- > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) >
On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote: > On Wed, 21 Feb 2024, Thomas Zimmermann wrote: > >> cc'ing backlight maintainers > > I cannot review/accept patches like this. > > Please submit a [RESEND]. I bounced the original [1] to you. Please consider acking to merge the one-line #include addition via fbdev so we don't have to respin the series for no good reason. BR, Jani. [1] https://lore.kernel.org/r/20240219093941.3684-2-tzimmermann@suse.de > >> Am 19.02.24 um 10:37 schrieb Thomas Zimmermann: >> > Resolves the proxy include via <linux/fb.h>, which does not require the >> > backlight header. >> > >> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> > --- >> > drivers/video/backlight/corgi_lcd.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c >> > index 0a57033ae31d1..dd765098ad989 100644 >> > --- a/drivers/video/backlight/corgi_lcd.c >> > +++ b/drivers/video/backlight/corgi_lcd.c >> > @@ -11,6 +11,7 @@ >> > * by Eric Miao <eric.miao@marvell.com> >> > */ >> > +#include <linux/backlight.h> >> > #include <linux/module.h> >> > #include <linux/kernel.h> >> > #include <linux/init.h> >> >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstrasse 146, 90461 Nuernberg, Germany >> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman >> HRB 36809 (AG Nuernberg) >>
On Mon, 26 Feb 2024, Jani Nikula wrote: > On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote: > > On Wed, 21 Feb 2024, Thomas Zimmermann wrote: > > > >> cc'ing backlight maintainers > > > > I cannot review/accept patches like this. > > > > Please submit a [RESEND]. > > I bounced the original [1] to you. Please consider acking to merge the > one-line #include addition via fbdev so we don't have to respin the > series for no good reason. The "good reason" would be that it was not sent properly in the first place. My kernel.org mail is filtered by the recipients headers. If the original wasn't sent to me, bouncing won't work either. I've since reviewed the patch and seen the set on LORE. This is non-optimal. Please use get_maintainer.pl next time. This time only, patch is: Acked-by: Lee Jones <lee@kernel.org>
Hi Am 26.02.24 um 13:33 schrieb Lee Jones: > On Mon, 26 Feb 2024, Jani Nikula wrote: > >> On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote: >>> On Wed, 21 Feb 2024, Thomas Zimmermann wrote: >>> >>>> cc'ing backlight maintainers >>> I cannot review/accept patches like this. >>> >>> Please submit a [RESEND]. >> I bounced the original [1] to you. Please consider acking to merge the >> one-line #include addition via fbdev so we don't have to respin the >> series for no good reason. > The "good reason" would be that it was not sent properly in the first > place. My kernel.org mail is filtered by the recipients headers. If > the original wasn't sent to me, bouncing won't work either. I've since > reviewed the patch and seen the set on LORE. This is non-optimal. > Please use get_maintainer.pl next time. > > This time only, patch is: > > Acked-by: Lee Jones <lee@kernel.org> No problem, I'll send out another series. I just didn't get to do it. Best regards Thomas >
On Mon, 26 Feb 2024, Thomas Zimmermann wrote: > Hi > > Am 26.02.24 um 13:33 schrieb Lee Jones: > > On Mon, 26 Feb 2024, Jani Nikula wrote: > > > > > On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote: > > > > On Wed, 21 Feb 2024, Thomas Zimmermann wrote: > > > > > > > > > cc'ing backlight maintainers > > > > I cannot review/accept patches like this. > > > > > > > > Please submit a [RESEND]. > > > I bounced the original [1] to you. Please consider acking to merge the > > > one-line #include addition via fbdev so we don't have to respin the > > > series for no good reason. > > The "good reason" would be that it was not sent properly in the first > > place. My kernel.org mail is filtered by the recipients headers. If > > the original wasn't sent to me, bouncing won't work either. I've since > > reviewed the patch and seen the set on LORE. This is non-optimal. > > Please use get_maintainer.pl next time. > > > > This time only, patch is: > > > > Acked-by: Lee Jones <lee@kernel.org> > > No problem, I'll send out another series. I just didn't get to do it. No need to do that now on my behalf. You have my Ack.
diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c index 0a57033ae31d1..dd765098ad989 100644 --- a/drivers/video/backlight/corgi_lcd.c +++ b/drivers/video/backlight/corgi_lcd.c @@ -11,6 +11,7 @@ * by Eric Miao <eric.miao@marvell.com> */ +#include <linux/backlight.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/init.h>
Resolves the proxy include via <linux/fb.h>, which does not require the backlight header. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/backlight/corgi_lcd.c | 1 + 1 file changed, 1 insertion(+)