| Message ID | 20210107025731.226017-1-warthog618@gmail.com |
|---|---|
| Headers | show |
| Series | selftests: gpio: rework and port to GPIO uAPI v2 | expand |
On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > GPIO selftests have changed to new gpio-mockup-cdev helper, so remove > old gpio-mockup-chardev helper. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > --- Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > GPIO Makefile has been greatly simplified so remove references to lines > which no longer exist. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > --- > tools/testing/selftests/kselftest_deps.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kselftest_deps.sh b/tools/testing/selftests/kselftest_deps.sh > index bbc04646346b..00e60d6eb16b 100755 > --- a/tools/testing/selftests/kselftest_deps.sh > +++ b/tools/testing/selftests/kselftest_deps.sh > @@ -129,13 +129,11 @@ l2_tests=$(grep -r --include=Makefile ": LDLIBS" | \ > grep -v "VAR_LDLIBS" | awk -F: '{print $1}') > > # Level 3 > -# gpio, memfd and others use pkg-config to find mount and fuse libs > +# memfd and others use pkg-config to find mount and fuse libs > # respectively and save it in VAR_LDLIBS. If pkg-config doesn't find > # any, VAR_LDLIBS set to default. > # Use the default value and filter out pkg-config for dependency check. > # e.g: > -# gpio/Makefile > -# VAR_LDLIBS := $(shell pkg-config --libs mount) 2>/dev/null) > # memfd/Makefile > # VAR_LDLIBS := $(shell pkg-config fuse --libs 2>/dev/null) > > -- > 2.30.0 > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > gpio-mockup-chardev helper has been obsoleted and removed, so also remove > the tools/gpio code that it, and nothing else, was using. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > --- Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Thu, Jan 7, 2021 at 3:59 AM Kent Gibson <warthog618@gmail.com> wrote: > > Add a port to the GPIO uAPI v2 interface and make it the default. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Mon, Jan 18, 2021 at 04:04:51PM +0100, Linus Walleij wrote: > On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > > selftests: gpio: rework and simplify test implementation > > selftests: gpio: remove obsolete gpio-mockup-chardev.c > > selftests: remove obsolete build restriction for gpio > > selftests: remove obsolete gpio references from kselftest_deps.sh > > tools: gpio: remove uAPI v1 code no longer used by selftests > > selftests: gpio: port to GPIO uAPI v2 > > selftests: gpio: add CONFIG_GPIO_CDEV to config > > Bartosz I think you can just merge these patches into the GPIO tree, at least > I think that is what I have done in the past. > Could you touch up that Fixes tag in patch 1 if you merge v2? Thanks, Kent.
On Tue, Jan 19, 2021 at 1:35 AM Kent Gibson <warthog618@gmail.com> wrote: > > On Mon, Jan 18, 2021 at 04:04:51PM +0100, Linus Walleij wrote: > > On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > selftests: gpio: rework and simplify test implementation > > > selftests: gpio: remove obsolete gpio-mockup-chardev.c > > > selftests: remove obsolete build restriction for gpio > > > selftests: remove obsolete gpio references from kselftest_deps.sh > > > tools: gpio: remove uAPI v1 code no longer used by selftests > > > selftests: gpio: port to GPIO uAPI v2 > > > selftests: gpio: add CONFIG_GPIO_CDEV to config > > > > Bartosz I think you can just merge these patches into the GPIO tree, at least > > I think that is what I have done in the past. > > > > Could you touch up that Fixes tag in patch 1 if you merge v2? > > Thanks, > Kent. Kent, This doesn't apply to my for-next branch - there's a conflict in tools/testing/selftests/gpio/Makefile, could you take a look? Bartosz
On Tue, Jan 19, 2021 at 11:37:46AM +0100, Bartosz Golaszewski wrote: > On Tue, Jan 19, 2021 at 1:35 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > On Mon, Jan 18, 2021 at 04:04:51PM +0100, Linus Walleij wrote: > > > On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > > > selftests: gpio: rework and simplify test implementation > > > > selftests: gpio: remove obsolete gpio-mockup-chardev.c > > > > selftests: remove obsolete build restriction for gpio > > > > selftests: remove obsolete gpio references from kselftest_deps.sh > > > > tools: gpio: remove uAPI v1 code no longer used by selftests > > > > selftests: gpio: port to GPIO uAPI v2 > > > > selftests: gpio: add CONFIG_GPIO_CDEV to config > > > > > > Bartosz I think you can just merge these patches into the GPIO tree, at least > > > I think that is what I have done in the past. > > > > > > > Could you touch up that Fixes tag in patch 1 if you merge v2? > > > > Thanks, > > Kent. > > Kent, > > This doesn't apply to my for-next branch - there's a conflict in > tools/testing/selftests/gpio/Makefile, could you take a look? > Which is your for-next branch? The patch set is based on and applies cleanly to gpio/for-next 7ac554888233, so I'm not sure which branch you are targetting. Cheers, Kent.
On Tue, Jan 19, 2021 at 11:59 AM Kent Gibson <warthog618@gmail.com> wrote: > > On Tue, Jan 19, 2021 at 11:37:46AM +0100, Bartosz Golaszewski wrote: > > On Tue, Jan 19, 2021 at 1:35 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > > On Mon, Jan 18, 2021 at 04:04:51PM +0100, Linus Walleij wrote: > > > > On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > > > > > selftests: gpio: rework and simplify test implementation > > > > > selftests: gpio: remove obsolete gpio-mockup-chardev.c > > > > > selftests: remove obsolete build restriction for gpio > > > > > selftests: remove obsolete gpio references from kselftest_deps.sh > > > > > tools: gpio: remove uAPI v1 code no longer used by selftests > > > > > selftests: gpio: port to GPIO uAPI v2 > > > > > selftests: gpio: add CONFIG_GPIO_CDEV to config > > > > > > > > Bartosz I think you can just merge these patches into the GPIO tree, at least > > > > I think that is what I have done in the past. > > > > > > > > > > Could you touch up that Fixes tag in patch 1 if you merge v2? > > > > > > Thanks, > > > Kent. > > > > Kent, > > > > This doesn't apply to my for-next branch - there's a conflict in > > tools/testing/selftests/gpio/Makefile, could you take a look? > > > > Which is your for-next branch? > > The patch set is based on and applies cleanly to gpio/for-next 7ac554888233, > so I'm not sure which branch you are targetting. > > Cheers, > Kent. Linus W is not picking up patches this release - everything goes through: git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next Sorry for the confusion. Bartosz
On Tue, Jan 19, 2021 at 12:02:13PM +0100, Bartosz Golaszewski wrote: > On Tue, Jan 19, 2021 at 11:59 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > On Tue, Jan 19, 2021 at 11:37:46AM +0100, Bartosz Golaszewski wrote: > > > On Tue, Jan 19, 2021 at 1:35 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > > > > On Mon, Jan 18, 2021 at 04:04:51PM +0100, Linus Walleij wrote: > > > > > On Thu, Jan 7, 2021 at 3:58 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > > > > > > > > selftests: gpio: rework and simplify test implementation > > > > > > selftests: gpio: remove obsolete gpio-mockup-chardev.c > > > > > > selftests: remove obsolete build restriction for gpio > > > > > > selftests: remove obsolete gpio references from kselftest_deps.sh > > > > > > tools: gpio: remove uAPI v1 code no longer used by selftests > > > > > > selftests: gpio: port to GPIO uAPI v2 > > > > > > selftests: gpio: add CONFIG_GPIO_CDEV to config > > > > > > > > > > Bartosz I think you can just merge these patches into the GPIO tree, at least > > > > > I think that is what I have done in the past. > > > > > > > > > > > > > Could you touch up that Fixes tag in patch 1 if you merge v2? > > > > > > > > Thanks, > > > > Kent. > > > > > > Kent, > > > > > > This doesn't apply to my for-next branch - there's a conflict in > > > tools/testing/selftests/gpio/Makefile, could you take a look? > > > > > > > Which is your for-next branch? > > > > The patch set is based on and applies cleanly to gpio/for-next 7ac554888233, > > so I'm not sure which branch you are targetting. > > > > Cheers, > > Kent. > > Linus W is not picking up patches this release - everything goes through: > > git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next > > Sorry for the confusion. > Ah, ok Michael Ellerman has been improving the Makefile toworkaround the build dependency issues for some cases. My changes supersede all that - a basic Makefile is now sufficient. I'll send out a v3 shortly. Cheers, Kent.