| Message ID | 20230616101749.2083974-1-quic_srichara@quicinc.com |
|---|---|
| Headers | show |
| Series | Add minimal boot support for IPQ5018 | expand |
On 16/06/2023 12:17, Sricharan Ramabadhran wrote: > Add initial device tree support for the Qualcomm IPQ5018 SoC and > rdp432-c2 board. > > Few things like 'reboot' does not work because, couple of more 'SCM' > APIS are needed to clear some TrustZone settings. Those will be > posted separately. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> > Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 +++++ > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 250 ++++++++++++++++++ > 3 files changed, 323 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi > NAK, please do not merge. It turns out there are some problems here (pointed out by Hariharan K). Best regards, Krzysztof
On 16/06/2023 12:17, Sricharan Ramabadhran wrote: > This patch adds support for the global clock controller found on > the IPQ5018 based devices. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
Hi, On 7/20/2023 2:14 PM, Krzysztof Kozlowski wrote: > On 16/06/2023 12:17, Sricharan Ramabadhran wrote: >> Add initial device tree support for the Qualcomm IPQ5018 SoC and >> rdp432-c2 board. >> >> Few things like 'reboot' does not work because, couple of more 'SCM' >> APIS are needed to clear some TrustZone settings. Those will be >> posted separately. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> >> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 +++++ >> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 250 ++++++++++++++++++ >> 3 files changed, 323 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi >> > > NAK, please do not merge. > > It turns out there are some problems here (pointed out by Hariharan K). The changes from Hariharan K to rename the dts compatibles is not correct. So the compatibles/names in this series should be used. Hariharan can fix his series and re-post. Regards, Sricharan
On 20/07/2023 12:51, Sricharan Ramabadhran wrote: >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 +++++ >>> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 250 ++++++++++++++++++ >>> 3 files changed, 323 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi >>> >> >> NAK, please do not merge. >> >> It turns out there are some problems here (pointed out by Hariharan K). > > The changes from Hariharan K to rename the dts compatibles is not > correct. So the compatibles/names in this series should be used. > Hariharan can fix his series and re-post. Thanks. Conflicting patches touching similar boards is however confusing me a bit... Best regards, Krzysztof
On 7/20/2023 5:03 PM, Krzysztof Kozlowski wrote: > On 20/07/2023 12:51, Sricharan Ramabadhran wrote: >>>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>>> .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 +++++ >>>> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 250 ++++++++++++++++++ >>>> 3 files changed, 323 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi >>>> >>> >>> NAK, please do not merge. >>> >>> It turns out there are some problems here (pointed out by Hariharan K). >> >> The changes from Hariharan K to rename the dts compatibles is not >> correct. So the compatibles/names in this series should be used. >> Hariharan can fix his series and re-post. > > Thanks. Conflicting patches touching similar boards is however confusing > me a bit... ok sure. Hariharan will fix his patches. I will anyways send V12 with your reviewed-tags just to avoid any confusion. Regards, Sricharan
The IPQ5018 is Qualcomm's 802.11ax SoC for Routers, Gateways and Access Points. This series adds minimal board boot support for ipq5018-rdp432-c2 board. [v11] Fixed patch 2/6 , just to move ftbl_apss_axi_clk_src to user Picked up 'Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>' [v10] Dropped patches 3,4 for pinctrl (was picked by Linus) Fixed hex number style in patch 2 as per Konrad's comments. [v9] Change only in patch 2/8 Sorted the headers and cleaned the unwanted ones Added trailing comma for .parent_hws member Removed the hunk touching ipq5332 kconfig (unintentionally) [v8] Changed only in patch 4/8 Fixed Kconfig to add COMPILE_TEST and removed header of.h. Instead using mod_devicetable.h. Added Linus reviewed-by [v7] Fixed tz reserved region size in patch 7/8 [v6] Fixed patch [4/8] pinctrl driver for rebase issue. [v5] Added Reviewed-by tags from Krzysztof Kozlowski. Changed patch [6/8] with [1] since its already Acked Rebased patch [4/8] on top of [2] and fixed other comments Fixed commit log for patch [7/8] Fixed comments for patch [2/8] [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1678164097-13247-4-git-send-email-quic_mmanikan@quicinc.com/ [2] https://lore.kernel.org/r/1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com [v4] Fixed all comments for clocks, schema, dts Added Reviewed-by tags. [v3] Fixed all comments for clocks, schema fixes Picked up Reviewed-by from Bjorn for pinctrl driver [v2] Fixed all comments and rebased for TOT. Manikanta Mylavarapu (1): dt-bindings: scm: Add compatible for IPQ5018 Sricharan Ramabadhran (5): dt-bindings: arm64: Add IPQ5018 clock and reset clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018 dt-bindings: qcom: Add ipq5018 bindings arm64: dts: Add ipq5018 SoC and rdp432-c2 board support arm64: defconfig: Enable IPQ5018 SoC base configs .../devicetree/bindings/arm/qcom.yaml | 7 + .../bindings/clock/qcom,ipq5018-gcc.yaml | 63 + .../bindings/firmware/qcom,scm.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 72 + arch/arm64/boot/dts/qcom/ipq5018.dtsi | 250 ++ arch/arm64/configs/defconfig | 3 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq5018.c | 3724 +++++++++++++++++ include/dt-bindings/clock/qcom,gcc-ipq5018.h | 183 + include/dt-bindings/reset/qcom,gcc-ipq5018.h | 122 + 12 files changed, 4435 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq5018-gcc.yaml create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi create mode 100644 drivers/clk/qcom/gcc-ipq5018.c create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq5018.h create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq5018.h