From patchwork Tue Sep 26 21:48:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 726812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F966E7F150 for ; Wed, 27 Sep 2023 00:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232262AbjI0AqB (ORCPT ); Tue, 26 Sep 2023 20:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbjI0AoB (ORCPT ); Tue, 26 Sep 2023 20:44:01 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5097EDF for ; Tue, 26 Sep 2023 14:48:16 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-502e7d66c1eso15868319e87.1 for ; Tue, 26 Sep 2023 14:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695764895; x=1696369695; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=XtIGAJAIn5DFyAAok8KJTgELmOKMBX9AjGhOfdYwP9U=; b=lsTrmsIPu0gmn8AcD60ok0KEm1Hg/8coLlGwBA4bCQN/ZCAzNgtj6zXpZUEN1Q0e/S ZmIt4HSagXgR59rsCtpRrbJIOECxGJ1WmYzU6z0XT9qiNjz2OUOX4viNs70806Tli21s vG6YBqXBP4KHzGhAwS7ioHianYwlD1guOZYi6/fr1SF1ZnBMDKyPmpzSMNNbsmSiBtvp ij75kfDitb3p/wRv6vm4sJgwROJoqir3uE+apqB3giHrQrCHw8bwgrfDudk6hS1AWua8 8GpUcai+VMu2P7kzIBfpQLB4MRyzMzpD7c3LoPTyxgnVMmF2Ey/uHpN/6bgEt0tsWqpQ qCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695764895; x=1696369695; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XtIGAJAIn5DFyAAok8KJTgELmOKMBX9AjGhOfdYwP9U=; b=ZsZwNBnVBW/SyTLgbXQXMtDsOMuI8DmCAX096w0UrIwoP+tHey9+CyuFfk2O7VdOZG LGcvnRPeMTpxzJDe8ohDBeE+0Lq8JuxKloLAnRcGkigR0yXCpiTkhFdhK2ZufiqGRadb N9rGBPaZbUPi9rfWe8yUpLnkhKG1/WCDNzRfb9CNT/vqKawaO5GXxdK8YYHRfZLcUM0I nz28dC7+PpAKuAIqvJaPmAMIfQyyukXsb9BMvHvW/l0y2rnvp8ZLCfdGmbsxuZqVi8LX yeIlAJIknzSucagpGRyiLj0MCJXTYh4XYuV4qlf4YuwU/dGaIaKKzvRdFayfE7noBUei W9vw== X-Gm-Message-State: AOJu0YxCf3EbbYku10btIEIaYCiys8nBYs/IzV2cx27xE/5u5UgB/fhP Sc2Xa7I3Ld6VvFW//oxA5IXFoQ== X-Google-Smtp-Source: AGHT+IGZJN6D1LppUajBIqaDv5vMWuxw8Tz7SHNssCZTCzblqzQErVamJzS0AJFKZ15Ta+fT3NcmDg== X-Received: by 2002:ac2:4c31:0:b0:500:d8d6:fc5a with SMTP id u17-20020ac24c31000000b00500d8d6fc5amr33695lfq.37.1695764894943; Tue, 26 Sep 2023 14:48:14 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id f10-20020a19ae0a000000b0050334e5f5a8sm2299982lfc.271.2023.09.26.14.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 14:48:14 -0700 (PDT) From: Linus Walleij Subject: [PATCH v2 0/3] Rewrite GPIO LED trigger to use trigger-sources Date: Tue, 26 Sep 2023 23:48:10 +0200 Message-Id: <20230926-gpio-led-trigger-dt-v2-0-e06e458b788e@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAJpRE2UC/22NQQqDMBBFryKz7pRkxBa76j2Ki9iMcUCMTIK0i HdvKnTX5Xvw398gsQonuFUbKK+SJM4F6FTBc3RzYBRfGMhQbVprMSwScWKPWSUEVvQZW6K+Z7K DI4KyXJQHeR3VR1d4lJSjvo+T1X7tr0d/e6tFg7ZvDNfX5uK9u08yO43nqAG6fd8/I9dZIbcAA AA= To: =?utf-8?q?Jan_Kundr=C3=A1t?= , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Conor Dooley X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This rewrites the platform-data GPIO LED trigger to instead use fwnode trigger-sources to describe the LED used. This will work out-of-the-box with e.g. device tree. Tested with real hardware by modifying a device tree adding trigger-sources to a LED and trigger-source-cells to a gpio chip, setting the trigger to a pushbutton. It works like a charm, once the trigger is set to "gpio". Adding trigger-sources to GPIO chips in a simple way requires this patch to be merged to the generic dtschema: https://lore.kernel.org/linux-devicetree/20230916-gpio-triggers-v1-1-6e5052bead9a@linaro.org/ Signed-off-by: Linus Walleij --- Changes in v2: - Add a quirk to gpiolib-of to allow to read out trigger-sources as any regular GPIO. - Fix a use-after-free bug found by Dan Carpenter. - Tested on hardware. - Link to v1: https://lore.kernel.org/r/20230912-gpio-led-trigger-dt-v1-0-1b50e3756dda@linaro.org --- Linus Walleij (3): gpiolib: of: Allow "trigger-sources" to reference a GPIO dt-bindings: leds: Mention GPIO triggers leds: triggers: gpio: Rewrite to use trigger-sources Documentation/devicetree/bindings/leds/common.yaml | 2 + drivers/gpio/gpiolib-of.c | 28 +++++ drivers/leds/trigger/Kconfig | 5 +- drivers/leds/trigger/ledtrig-gpio.c | 137 ++++++--------------- 4 files changed, 71 insertions(+), 101 deletions(-) --- base-commit: 8eb1c4d9b44873d30efc1846148944534f4a017d change-id: 20230911-gpio-led-trigger-dt-922bbe21fa22 Best regards,