mbox series

[libgpiod,0/3] thread-safety doc + Rust modeling

Message ID 20230928-rust-send-trait-v1-0-30b4f59d13cb@linaro.org
Headers show
Series thread-safety doc + Rust modeling | expand

Message

Erik Schilling Sept. 28, 2023, 2:37 p.m. UTC 
This updates the docs with what was discussed in the linked thread.
Then, the Rust bindings are adjusted to match in behaviour.

To: Linux-GPIO <linux-gpio@vger.kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Viresh Kumar <viresh.kumar@linaro.org>

Link: https://lore.kernel.org/r/CVHO091CC80Y.3KUOSLSOBVL0T@ablu-work
Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
---
Erik Schilling (3):
      doc: drop unneeded <p> tags
      doc: document thread safety guarantees
      bindings: rust: mark all owning types as `Send`

 bindings/rust/libgpiod/src/edge_event.rs     |  4 ++++
 bindings/rust/libgpiod/src/event_buffer.rs   |  8 ++++++++
 bindings/rust/libgpiod/src/info_event.rs     |  4 ++++
 bindings/rust/libgpiod/src/line_config.rs    |  4 ++++
 bindings/rust/libgpiod/src/line_request.rs   |  4 ++++
 bindings/rust/libgpiod/src/line_settings.rs  |  4 ++++
 bindings/rust/libgpiod/src/request_config.rs |  4 ++++
 include/gpiod.h                              | 26 +++++++++++++++++++++++---
 8 files changed, 55 insertions(+), 3 deletions(-)
---
base-commit: ced90e79217793957b11414f47f8aa8a77c7a2d5
change-id: 20230928-rust-send-trait-316a8f31bb97

Best regards,

Comments

Bartosz Golaszewski Oct. 2, 2023, 7:16 a.m. UTC | #1 
On Thu, Sep 28, 2023 at 4:37 PM Erik Schilling
<erik.schilling@linaro.org> wrote:
>
> This updates the docs with what was discussed in the linked thread.
> Then, the Rust bindings are adjusted to match in behaviour.
>
> To: Linux-GPIO <linux-gpio@vger.kernel.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>
> Link: https://lore.kernel.org/r/CVHO091CC80Y.3KUOSLSOBVL0T@ablu-work
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> Erik Schilling (3):
>       doc: drop unneeded <p> tags
>       doc: document thread safety guarantees
>       bindings: rust: mark all owning types as `Send`
>
>  bindings/rust/libgpiod/src/edge_event.rs     |  4 ++++
>  bindings/rust/libgpiod/src/event_buffer.rs   |  8 ++++++++
>  bindings/rust/libgpiod/src/info_event.rs     |  4 ++++
>  bindings/rust/libgpiod/src/line_config.rs    |  4 ++++
>  bindings/rust/libgpiod/src/line_request.rs   |  4 ++++
>  bindings/rust/libgpiod/src/line_settings.rs  |  4 ++++
>  bindings/rust/libgpiod/src/request_config.rs |  4 ++++
>  include/gpiod.h                              | 26 +++++++++++++++++++++++---
>  8 files changed, 55 insertions(+), 3 deletions(-)
> ---
> base-commit: ced90e79217793957b11414f47f8aa8a77c7a2d5
> change-id: 20230928-rust-send-trait-316a8f31bb97
>
> Best regards,
> --
> Erik Schilling <erik.schilling@linaro.org>
>

Series applied, thanks!

Bart
Erik Schilling Oct. 2, 2023, 7:22 a.m. UTC | #2 
On Mon Oct 2, 2023 at 9:16 AM CEST, Bartosz Golaszewski wrote:
> On Thu, Sep 28, 2023 at 4:37 PM Erik Schilling
> <erik.schilling@linaro.org> wrote:
> >
> > This updates the docs with what was discussed in the linked thread.
> > Then, the Rust bindings are adjusted to match in behaviour.
> >
> > To: Linux-GPIO <linux-gpio@vger.kernel.org>
> > Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Link: https://lore.kernel.org/r/CVHO091CC80Y.3KUOSLSOBVL0T@ablu-work
> > Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> > ---
> > Erik Schilling (3):
> >       doc: drop unneeded <p> tags
> >       doc: document thread safety guarantees
> >       bindings: rust: mark all owning types as `Send`
> >
> >  bindings/rust/libgpiod/src/edge_event.rs     |  4 ++++
> >  bindings/rust/libgpiod/src/event_buffer.rs   |  8 ++++++++
> >  bindings/rust/libgpiod/src/info_event.rs     |  4 ++++
> >  bindings/rust/libgpiod/src/line_config.rs    |  4 ++++
> >  bindings/rust/libgpiod/src/line_request.rs   |  4 ++++
> >  bindings/rust/libgpiod/src/line_settings.rs  |  4 ++++
> >  bindings/rust/libgpiod/src/request_config.rs |  4 ++++
> >  include/gpiod.h                              | 26 +++++++++++++++++++++++---
> >  8 files changed, 55 insertions(+), 3 deletions(-)
> > ---
> > base-commit: ced90e79217793957b11414f47f8aa8a77c7a2d5
> > change-id: 20230928-rust-send-trait-316a8f31bb97
> >
> > Best regards,
> > --
> > Erik Schilling <erik.schilling@linaro.org>
> >
>
> Series applied, thanks!

Thanks for merging and the clarifications!

- Erik