| Message ID | 20241018-gpio-notify-in-kernel-events-v5-0-c79135e58a1c@linaro.org |
|---|---|
| Headers | show |
| Series | gpio: notify user-space about config changes in the kernel | expand |
On Fri, Oct 18, 2024 at 11:10:08AM +0200, Bartosz Golaszewski wrote: > We currently only emit events on changed line config to user-space on > changes made from user-space. Users have no way of getting notified > about in-kernel changes. This series improves the situation and also > contains a couple other related improvements. > > This is a reworked approach which gets and stores as much info (all of > it actually, except for the pinctrl state) the moment the event occurrs > but moves the actual queueing of the event on the kfifo to a dedicated > high-priority, ordered workqueue. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Kent Gibson <warthog618@gmail.com> Cheers, Kent.
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Fri, 18 Oct 2024 11:10:08 +0200, Bartosz Golaszewski wrote: > We currently only emit events on changed line config to user-space on > changes made from user-space. Users have no way of getting notified > about in-kernel changes. This series improves the situation and also > contains a couple other related improvements. > > This is a reworked approach which gets and stores as much info (all of > it actually, except for the pinctrl state) the moment the event occurrs > but moves the actual queueing of the event on the kfifo to a dedicated > high-priority, ordered workqueue. > > [...] Applied, thanks! [1/8] gpiolib: notify user-space when a driver requests its own desc commit: 49182c87af377ec4ae0a5e116a9059e03b083574 [2/8] gpiolib: unduplicate chip guard in set_config path commit: dd26ffaa4d278d6e538c4ea68fb508a69f567827 [3/8] gpio: cdev: go back to storing debounce period in the GPIO descriptor commit: 81625f362497509526a2f9ac53843ae30b4709cc [4/8] gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic commit: 8c44447bd76109e33a69fccda89c84715fbd5658 [5/8] gpiolib: add a per-gpio_device line state notification workqueue commit: 7b9b77a8bba9c1fd7bad3310dbf2cf382e1f8c25 [6/8] gpio: cdev: put emitting the line state events on a workqueue commit: 40b7c49950bd56c984b1f6722f865b922879260e [7/8] gpiolib: switch the line state notifier to atomic commit: fcc8b637c542d1a0c19e5797ad72f9258e10464c [8/8] gpiolib: notify user-space about in-kernel line state changes commit: 07c61d4da43fa3b34c152b28010d20be115a96db Best regards,
We currently only emit events on changed line config to user-space on changes made from user-space. Users have no way of getting notified about in-kernel changes. This series improves the situation and also contains a couple other related improvements. This is a reworked approach which gets and stores as much info (all of it actually, except for the pinctrl state) the moment the event occurrs but moves the actual queueing of the event on the kfifo to a dedicated high-priority, ordered workqueue. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- Changes in v5: - only notify user-space about changed config AFTER the edge detector was updated (to that end keep the explicit notification and use the nonotify variants of direction setters) - for consistency do the same for v1 - Link to v4: https://lore.kernel.org/r/20241017-gpio-notify-in-kernel-events-v4-0-64bc05f3be0c@linaro.org Changes in v4: - don't emit additional events when emulating open-source or open-drain from gpiod_direction_output(), to that end use the nonotify variants of gpiod_direction_input() - store current debounce period in the GPIO line descriptor and remove the entire supinfo infrastructure from gpiolib-cdev.c - fix all (hopefully) corner-cases where two reconfigure or requested/reconfigured events could be emitted for a single logical event - emit the reconfigure event from gpio_set_debounce_timeout() - add a patch refactoring gpio_do_set_config() - Link to v3: https://lore.kernel.org/r/20241015-gpio-notify-in-kernel-events-v3-0-9edf05802271@linaro.org Changes in v3: - don't reach into pinctrl if the USED flag is already set - reword the comment from patch 5 and move it one patch back - don't abandon emitting the event if the GPIO chip is gone by the time the work is executed, just don't reach into pinctrl and return whatever data we already had - Link to v2: https://lore.kernel.org/r/20241010-gpio-notify-in-kernel-events-v2-0-b560411f7c59@linaro.org Changes in v2: - put all line-info events emitting on a workqueue to allow queueing them from atomic context - switch the notifier type used for emitting info events to atomic - add a patch notifying user-space about drivers requesting their own descs - drop patches that were picked up - Link to v1: https://lore.kernel.org/r/20241004-gpio-notify-in-kernel-events-v1-0-8ac29e1df4fe@linaro.org --- Bartosz Golaszewski (8): gpiolib: notify user-space when a driver requests its own desc gpiolib: unduplicate chip guard in set_config path gpio: cdev: go back to storing debounce period in the GPIO descriptor gpio: cdev: prepare gpio_desc_to_lineinfo() for being called from atomic gpiolib: add a per-gpio_device line state notification workqueue gpio: cdev: put emitting the line state events on a workqueue gpiolib: switch the line state notifier to atomic gpiolib: notify user-space about in-kernel line state changes drivers/gpio/gpiolib-cdev.c | 301 +++++++++++++++++++------------------------- drivers/gpio/gpiolib.c | 130 ++++++++++++++----- drivers/gpio/gpiolib.h | 14 ++- 3 files changed, 243 insertions(+), 202 deletions(-) --- base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3 change-id: 20240924-gpio-notify-in-kernel-events-07cd912153e8 Best regards,