| Message ID | 20250409-gpiochip-set-rv-iio-v2-0-4b36428f39cb@linaro.org |
|---|---|
| Headers | show |
| Series | iio: convert GPIO chips to using new value setters | expand |
On Wed, 2025-04-09 at 10:40 +0200, Bartosz Golaszewski wrote: > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. We're in the process of > converting all GPIO drivers to using the new API. This series converts > all the IIO GPIO controllers and also contains some additional > refactoring patches for ad5592r in preparation for the conversion. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- LGTM, Reviewed-by: Nuno Sá <nuno.sa@analog.com> > Changes in v2: > - move devm_mutex_init() earlier in probe() to avoid using a goto > - rework returning on error in ad5592r_set_channel_modes(): return > immediately instead of saving the return value and going to the bottom > of the function > - use scoped_guard() in one more place to fix a build warning reported > by the build bot > - Link to v1: > https://lore.kernel.org/r/20250407-gpiochip-set-rv-iio-v1-0-8431b003a145@linaro.org > > --- > Bartosz Golaszewski (7): > iio: dac: ad5592r: destroy mutexes in detach paths > iio: dac: ad5592r: use lock guards > iio: dac: ad5592r: use new GPIO line value setter callbacks > iio: adc: ti-ads7950: use new GPIO line value setter callbacks > iio: adc: ad4130: use new GPIO line value setter callbacks > iio: addac: ad74413r: use new GPIO line value setter callbacks > iio: addac: ad74115: use new GPIO line value setter callbacks > > drivers/iio/adc/ad4130.c | 10 +-- > drivers/iio/adc/ti-ads7950.c | 17 +++-- > drivers/iio/addac/ad74115.c | 18 +++-- > drivers/iio/addac/ad74413r.c | 28 ++++---- > drivers/iio/dac/ad5592r-base.c | 147 ++++++++++++++++++---------------------- > - > 5 files changed, 103 insertions(+), 117 deletions(-) > --- > base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 > change-id: 20250401-gpiochip-set-rv-iio-b064ce43791d > > Best regards,
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. We're in the process of converting all GPIO drivers to using the new API. This series converts all the IIO GPIO controllers and also contains some additional refactoring patches for ad5592r in preparation for the conversion. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- Changes in v2: - move devm_mutex_init() earlier in probe() to avoid using a goto - rework returning on error in ad5592r_set_channel_modes(): return immediately instead of saving the return value and going to the bottom of the function - use scoped_guard() in one more place to fix a build warning reported by the build bot - Link to v1: https://lore.kernel.org/r/20250407-gpiochip-set-rv-iio-v1-0-8431b003a145@linaro.org --- Bartosz Golaszewski (7): iio: dac: ad5592r: destroy mutexes in detach paths iio: dac: ad5592r: use lock guards iio: dac: ad5592r: use new GPIO line value setter callbacks iio: adc: ti-ads7950: use new GPIO line value setter callbacks iio: adc: ad4130: use new GPIO line value setter callbacks iio: addac: ad74413r: use new GPIO line value setter callbacks iio: addac: ad74115: use new GPIO line value setter callbacks drivers/iio/adc/ad4130.c | 10 +-- drivers/iio/adc/ti-ads7950.c | 17 +++-- drivers/iio/addac/ad74115.c | 18 +++-- drivers/iio/addac/ad74413r.c | 28 ++++---- drivers/iio/dac/ad5592r-base.c | 147 ++++++++++++++++++----------------------- 5 files changed, 103 insertions(+), 117 deletions(-) --- base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 change-id: 20250401-gpiochip-set-rv-iio-b064ce43791d Best regards,