| Message ID | 20250514081125.24475-1-darren.ye@mediatek.com |
|---|---|
| Headers | show |
| Series | ASoC: mediatek: Add support for MT8196 SoC | expand |
On Wed, May 14, 2025 at 04:11:06PM +0800, Darren.Ye wrote: > +#include <linux/regmap.h> > +#include <linux/delay.h> > +#include "mt8196-afe-clk.h" > +#include "mt8196-afe-common.h" > +#include "mt8196-interconnection.h" > + > +#define MTKAIF4 This define is there unconditionally, what's it for?
On Wed, 2025-05-14 at 12:54 +0200, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 14/05/2025 10:11, Darren.Ye wrote: > > From: Darren Ye <darren.ye@mediatek.com> > > > > Add mt8196 audio AFE document. > > A nit, subject: drop second/last, redundant "document". > See also: > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst*L18__;Iw!!CTRNKA9wMg0ARbw!iSQl6_WMX8Q6wsBj4pVe7Tdnbd2zpPwSmHMSm4hlhkD0lO7h5JSAr28-dUj_DwLrXhU_IByy_QWQGQ$ > > > > > Signed-off-by: Darren Ye <darren.ye@mediatek.com> > > > ... > > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - mediatek,vlpcksys > > + - power-domains > > + - memory-region > > + - clocks > > + - clock-names > > > Keep the same order as in properties:. > ok, thanks. Best regards, Darren > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > <form letter> > This is an automated instruction, just in case, because many review > tags > are being ignored. If you know the process, you can skip it (please > do > not feel offended by me posting it here - no bad intentions > intended). > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions > of patchset, under or above your Signed-off-by tag, unless patch > changed > significantly (e.g. new properties added to the DT bindings). Tag is > "received", when provided in a message replied to you on the mailing > list. Tools like b4 can help here. However, there's no need to repost > patches *only* to add the tags. The upstream maintainer will do that > for > tags received on the version they apply. > > Full context and explanation: > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst*L577__;Iw!!CTRNKA9wMg0ARbw!iSQl6_WMX8Q6wsBj4pVe7Tdnbd2zpPwSmHMSm4hlhkD0lO7h5JSAr28-dUj_DwLrXhU_IBzvkGpWKg$ > </form letter> > > > Best regards, > Krzysztof
From: Darren Ye <darren.ye@mediatek.com> This series of patches adds support for Mediatek AFE of MT8196 SoC. Patches are based on broonie tree "for-next" branch. Changes since v2: - remove the mtk_memif_set_channel interface modify. - remove duplicate definitions from the header file. - move the afe gate clk to the audio driver for management and registration and manage the afe clk gate in each dai driver. - delete the useless clk source. - the i2s driver adds i2s clk gate management, removes the additional dts configuration of i2s4. - the afe and i2s dai driver,memif and irq data structs are encapsulated using macros to reduce the amount of code. - the volatile reg is modified as suggested. - mt6681 codec is not supported, the mt6681 keyword is removed. - the name of the machine driver is changed from mt8196-mt6681.c to mt8196-nau8825.c - remove the i2s4 configuration from mt8196-afe.yaml and make the modifications as suggested. - change the mt8196-mt6681.yaml to mt8196-nau8825.yaml and make the modifications as suggested. Changes since v1: - modify mtk_memif_set_channel and mtk_afe_pcm_pointer interfaces are improved to support mt8196. - remove duplicate definitions in the mt8196 common header file. - cm logic is merge into the afe platform driver. - modify afe clk to return judgment logic and remove useless clk sources. - refactor the mt8196 adda dai driver. - remove the gpio module and use SND_SOC_DAPM_PINCTRL to manage it. - removes CONNSYS_I2S related functions that are not supported in i2s dai driver. - fixed mt8196-afe.yaml and mt8196-mt6681.yaml syntax issues. - modify log printing in all modules. - optimize the header file included for machine driver. Darren Ye (10): ASoC: mediatek: common: modify mtk afe platform driver for mt8196 ASoC: mediatek: mt8196: add common header ASoC: mediatek: mt8196: support audio clock control ASoC: mediatek: mt8196: support ADDA in platform driver ASoC: mediatek: mt8196: support I2S in platform driver ASoC: mediatek: mt8196: support TDM in platform driver ASoC: mediatek: mt8196: add platform driver ASoC: dt-bindings: mediatek,mt8196-afe: add audio AFE document ASoC: mediatek: mt8196: add machine driver with nau8825 ASoC: dt-bindings: mediatek,mt8196-nau8825: add mt8196-nau8825 document .../bindings/sound/mediatek,mt8196-afe.yaml | 155 + .../sound/mediatek,mt8196-nau8825.yaml | 115 + sound/soc/mediatek/Kconfig | 30 + sound/soc/mediatek/Makefile | 1 + .../mediatek/common/mtk-afe-platform-driver.c | 47 +- .../mediatek/common/mtk-afe-platform-driver.h | 2 + sound/soc/mediatek/mt8196/Makefile | 18 + sound/soc/mediatek/mt8196/mt8196-afe-clk.c | 723 + sound/soc/mediatek/mt8196/mt8196-afe-clk.h | 142 + sound/soc/mediatek/mt8196/mt8196-afe-common.h | 206 + sound/soc/mediatek/mt8196/mt8196-afe-pcm.c | 2642 ++++ sound/soc/mediatek/mt8196/mt8196-audsys-clk.c | 252 + sound/soc/mediatek/mt8196/mt8196-audsys-clk.h | 14 + .../soc/mediatek/mt8196/mt8196-audsys-clkid.h | 78 + sound/soc/mediatek/mt8196/mt8196-dai-adda.c | 918 ++ sound/soc/mediatek/mt8196/mt8196-dai-i2s.c | 4052 ++++++ sound/soc/mediatek/mt8196/mt8196-dai-tdm.c | 862 ++ .../mediatek/mt8196/mt8196-interconnection.h | 121 + sound/soc/mediatek/mt8196/mt8196-nau8825.c | 869 ++ sound/soc/mediatek/mt8196/mt8196-reg.h | 12068 ++++++++++++++++ 20 files changed, 23299 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-afe.yaml create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-nau8825.yaml create mode 100644 sound/soc/mediatek/mt8196/Makefile create mode 100644 sound/soc/mediatek/mt8196/mt8196-afe-clk.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-afe-clk.h create mode 100644 sound/soc/mediatek/mt8196/mt8196-afe-common.h create mode 100644 sound/soc/mediatek/mt8196/mt8196-afe-pcm.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-audsys-clk.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-audsys-clk.h create mode 100644 sound/soc/mediatek/mt8196/mt8196-audsys-clkid.h create mode 100644 sound/soc/mediatek/mt8196/mt8196-dai-adda.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-dai-i2s.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-dai-tdm.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-interconnection.h create mode 100644 sound/soc/mediatek/mt8196/mt8196-nau8825.c create mode 100644 sound/soc/mediatek/mt8196/mt8196-reg.h