| Message ID | 20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org |
|---|---|
| Headers | show |
| Series | qrb4210-rb2: add wsa audio playback and capture support | expand |
On 22/05/2025 19:40, Alexey Klimov wrote: > Rebased, updated, re-tested. This implements the playback support via the > following path: RX1 from DSP is connected to rxmacro which communicates > with wcd codec using soundwire. This goes into AUX input of wcd. Wcd codec > outputs analog audio into wsa8815 amplifier. Capturing works through vamacro > using one onboard DMIC which is directly connected to vamacro codec. > > Changes since v2: > -- dropped [PATCH v2 08/14] dt-bindings: arm: qcom-soc: extend pattern matching > to support qcom,wsa881x and replaced with new one; > -- dropped [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210 > -- reordered as suggested by Krzysztof; > -- updates to wsa881x-common.h registers descriptions and corresponding updates > to wsa881x-common.c (Konrad); > -- sorted subnodes in DT alphabetically as suggested by Konrad; > -- wsa881x bindings updates (as suggested by Krzysztof); What exactly changed? This is way too vague. > -- ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs > is still present; What does it mean "still present"? You never responded to my comment. I never asked to remove it, so I do not get why you mention it is still present. Best regards, Krzysztof
Rebased, updated, re-tested. This implements the playback support via the following path: RX1 from DSP is connected to rxmacro which communicates with wcd codec using soundwire. This goes into AUX input of wcd. Wcd codec outputs analog audio into wsa8815 amplifier. Capturing works through vamacro using one onboard DMIC which is directly connected to vamacro codec. Changes since v2: -- dropped [PATCH v2 08/14] dt-bindings: arm: qcom-soc: extend pattern matching to support qcom,wsa881x and replaced with new one; -- dropped [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210 -- reordered as suggested by Krzysztof; -- updates to wsa881x-common.h registers descriptions and corresponding updates to wsa881x-common.c (Konrad); -- sorted subnodes in DT alphabetically as suggested by Konrad; -- wsa881x bindings updates (as suggested by Krzysztof); -- ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs is still present; -- added "qcom,wsa8810" compatible to wsa881x-i2c.c; -- wsa881x is still present in wsa881x_probe_common(); Second version: https://lore.kernel.org/linux-arm-msm/20241212004727.2903846-1-alexey.klimov@linaro.org/ First version: https://lore.kernel.org/linux-sound/20241101053154.497550-1-alexey.klimov@linaro.org/ --- Alexey Klimov (12): ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs dt-bindings: arm: qcom-soc: ignore "wsa" from being selected as SoC component ASoC: dt-bindings: qcom,wsa881x: extend description to analog mode ASoC: codecs: lpass-rx-macro: add sm6115 compatible ASoC: codecs: wsa881x: split into common and soundwire drivers ASoC: codecs: add wsa881x-i2c amplifier codec driver arm64: dts: qcom: sm6115: add LPASS devices arm64: dts: qcom: sm4250: add description of soundwire and dmic pins arm64: dts: qcom: qrb4210-rb2: add wcd937x codec support arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier arm64: dts: qcom: qrb4210-rb2: add WSA audio playback support arm64: dts: qcom: qrb4210-rb2: add VA capture support .../devicetree/bindings/arm/qcom-soc.yaml | 2 +- .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 + .../bindings/sound/qcom,lpass-va-macro.yaml | 22 +- .../devicetree/bindings/sound/qcom,wsa881x.yaml | 66 +- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 113 ++ arch/arm64/boot/dts/qcom/sm4250.dtsi | 62 + arch/arm64/boot/dts/qcom/sm6115.dtsi | 132 ++ sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/lpass-rx-macro.c | 4 +- sound/soc/codecs/wsa881x-common.c | 193 +++ sound/soc/codecs/wsa881x-common.h | 478 +++++++ sound/soc/codecs/wsa881x-i2c.c | 1353 ++++++++++++++++++++ sound/soc/codecs/wsa881x.c | 493 +------ 14 files changed, 2459 insertions(+), 497 deletions(-) --- base-commit: 7bac2c97af4078d7a627500c9bcdd5b033f97718 change-id: 20250522-rb2_audio_v3-ffa12dcc6148 Best regards,