| Message ID | cover.1733739697.git.matthias.schiffer@ew.tq-group.com |
|---|---|
| Headers | show |
| Series | gpio-tqmx86: cleanup + changing directions | expand |
On Mon, Dec 9, 2024 at 11:36 AM Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > > This is the first of two series adding new features to the gpio-tqmx86 > driver. The first 3 patches are cleanup/preparation and the last patch > adds support for changing the directions of GPIOs. > > Once this is merged, the final series will add support for new TQMx86 > variants (SMARC and COM-HPC) that feature up to 14 GPIOs and full IRQ > support on all lines. > It's not like this series is very big, what stops you from posting the entire thing right away? It would probably add more context to this series. Bart > > Matthias Schiffer (4): > gpio: tqmx86: add macros for interrupt configuration > gpio: tqmx86: consistently refer to IRQs by hwirq numbers > gpio: tqmx86: introduce tqmx86_gpio_clrsetbits() helper > gpio: tqmx86: add support for changing GPIO directions > > drivers/gpio/gpio-tqmx86.c | 135 +++++++++++++++++++++++-------------- > 1 file changed, 84 insertions(+), 51 deletions(-) > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > https://www.tq-group.com/ >
On Wed, 2024-12-11 at 16:12 +0100, Bartosz Golaszewski wrote: > > On Mon, Dec 9, 2024 at 11:36 AM Matthias Schiffer > <matthias.schiffer@ew.tq-group.com> wrote: > > > > This is the first of two series adding new features to the gpio-tqmx86 > > driver. The first 3 patches are cleanup/preparation and the last patch > > adds support for changing the directions of GPIOs. > > > > Once this is merged, the final series will add support for new TQMx86 > > variants (SMARC and COM-HPC) that feature up to 14 GPIOs and full IRQ > > support on all lines. > > > > It's not like this series is very big, what stops you from posting the > entire thing right away? It would probably add more context to this > series. > > Bart The second series is bigger and involves both the GPIO and MFD drivers. I kinda expect a few rounds of reviews to be needed before it gets accepted, so my intention was to get these smaller, more obvious patches out of the way first. Best regards, Matthias > > > > > Matthias Schiffer (4): > > gpio: tqmx86: add macros for interrupt configuration > > gpio: tqmx86: consistently refer to IRQs by hwirq numbers > > gpio: tqmx86: introduce tqmx86_gpio_clrsetbits() helper > > gpio: tqmx86: add support for changing GPIO directions > > > > drivers/gpio/gpio-tqmx86.c | 135 +++++++++++++++++++++++-------------- > > 1 file changed, 84 insertions(+), 51 deletions(-) > > > > -- > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > > Amtsgericht München, HRB 105018 > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > > https://www.tq-group.com/ > >
On Wed, Dec 11, 2024 at 4:35 PM Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > > On Wed, 2024-12-11 at 16:12 +0100, Bartosz Golaszewski wrote: > > > > On Mon, Dec 9, 2024 at 11:36 AM Matthias Schiffer > > <matthias.schiffer@ew.tq-group.com> wrote: > > > > > > This is the first of two series adding new features to the gpio-tqmx86 > > > driver. The first 3 patches are cleanup/preparation and the last patch > > > adds support for changing the directions of GPIOs. > > > > > > Once this is merged, the final series will add support for new TQMx86 > > > variants (SMARC and COM-HPC) that feature up to 14 GPIOs and full IRQ > > > support on all lines. > > > > > > > It's not like this series is very big, what stops you from posting the > > entire thing right away? It would probably add more context to this > > series. > > > > Bart > > The second series is bigger and involves both the GPIO and MFD drivers. I kinda > expect a few rounds of reviews to be needed before it gets accepted, so my > intention was to get these smaller, more obvious patches out of the way first. > > Best regards, > Matthias Fair enough. Could you address the nits I pointed out? I'll queue these then. Bart