From patchwork Thu Aug 27 08:08:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 248431 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp211347ils; Thu, 27 Aug 2020 01:11:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoZboYU7z7LEdmx30Vn7p5n5HKTt6cpWWFsYSB65ONv5QByyybDNMoirJHBiWQF/xQ4XN3 X-Received: by 2002:a17:906:d181:: with SMTP id c1mr19206228ejz.181.1598515870860; Thu, 27 Aug 2020 01:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598515870; cv=none; d=google.com; s=arc-20160816; b=ShGyK1nn0a3kaEB4U6VkVSNyfS/UEJvQq+PE32y0m7+p0/QuqbFIeuDk7n0IDU5FKE 416BPatFf9H8r9FBYw3FY/vLPqd9d9Fet9ZVuLbsot+lf3zX+1KKoViNMXWy1kclqRkl mZJfK6nTZ21Bdv+gbd5A852xwcjsCtDqeqd3+LRXojcO3gGwxPhVlzmiMWr5lWZF1m6n GbGUZlyhlO7/zaJsbxWT1VvJbpOUUhHQt/KU4qCvW9JiFXGT4g2p5SxcZpOTIr2leguC 9d+b1fsYDoaujV7k6C7vsdbCt3R7oMz+TLIkcvCcEzNGnbBv2sQuJmwo4PsuIf/xc+04 SWbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R0qr0wEHYkyK/CJaNJ4Tz6g9aeydokX3kWn6WhBTMLA=; b=IbzlsOwq+b6KwjzQUwRfcTDtlGP50f+os5bf2L3nyGwSBWTdvVMxFSLjcszeQDCWlW HH+mDPKIS4t/DBc9Bp6h6VFU2aPPKGr+fNqBm0X9PtcMpiNM933Mzzg2RGl3PcDNH1Ws om08q7PA080wrDt6yiyIwpGptgzCW+tiic3iSY+VYCqw7hK7VboTiNwD5GXDqwXWGTZU EQ2vDY5sOydlxsDQ5NYzza0wdxrFAK6Py6avS3r9dz02Nkc2TuwyR0mwCgAj4Hsicv7v fMHdGz61E0HB3qncsQa7OuXm03Q06gvkUP6JGnPVINBgcZamtxX6KOdo9AeffbM2J50Q VnRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VA7jgQtK; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox14si1034456ejb.516.2020.08.27.01.11.10; Thu, 27 Aug 2020 01:11:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VA7jgQtK; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgH0ILJ (ORCPT + 6 others); Thu, 27 Aug 2020 04:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbgH0ILI (ORCPT ); Thu, 27 Aug 2020 04:11:08 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B22EC061264 for ; Thu, 27 Aug 2020 01:11:07 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id w14so5416813ljj.4 for ; Thu, 27 Aug 2020 01:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R0qr0wEHYkyK/CJaNJ4Tz6g9aeydokX3kWn6WhBTMLA=; b=VA7jgQtKWZJhZ2JFzhFdsiJNA4AKnPIqqpH9TU2P4Tz41Ev5s3DCcAsK5ZRxFo/w+L vHMHgpznokGU+52tjv9EXgfji7mUVxDeEmokG05GFmF3zpdwpXzplmtfLlgHa8NVj+N6 DRPbgsEnfpDNhRjby4uITLcoxivx1M9q//E9pJGqNYyuWm2ABu4laPaM3H/ZmJdF1AXy tt3o00I2vCgbEhmwe/biUKl6BmaqbtkXJ4sYKDfbzQsP2lVAou/9qtyDOlkOmKLX1EQx QZzQzEStzGZiFJueZNoCRoVRsvp109BnaRTGr5hcfpn9p4gP29gW0v1cKpnjB3Z9SHBH N9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R0qr0wEHYkyK/CJaNJ4Tz6g9aeydokX3kWn6WhBTMLA=; b=uSzuLhVBT9ZuS24j2glxj7vu18aIXnTTJkeq/E5mAbcuNNohVut2dooRcW1AJy3Tm+ IK69+NFZ5OJsL4Kg6tM6o+I/P938wy62vmH/4poSb1UZx9nBmMRpYE+tk1qhn5AdyL0D eALvsLIs/WrjvwpPMnJ/nw4rTEcs4qM/nO659jcDH37i8pQduzdoZqfAVTXcbyx5b3nC jhFqKhxfv3M5B6aQnGiVy63mdP5nUvO0d68GeBb0ucjq/ouGqrK5Z0nvqeAcWdv0w5QJ HjiUW8sK1JumqZtvtJIzp+pKz0LOKDYCHlVnXl1pcLXxxnQ2TOm51b6oNc3CUSmwiZOz FYPQ== X-Gm-Message-State: AOAM531FDlge+beIlKz6ExXcNRHcIdB8uc0eaAcNPg6c+OjXzohg2OZa UgaJE6tsWwTZFitmnzuy8WoyBztYweqQaA== X-Received: by 2002:a2e:b892:: with SMTP id r18mr8524065ljp.249.1598515866001; Thu, 27 Aug 2020 01:11:06 -0700 (PDT) Received: from localhost.localdomain (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id k9sm331399lfm.29.2020.08.27.01.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 01:11:05 -0700 (PDT) From: Linus Walleij To: Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, linux-geode@lists.infradead.org Subject: [PATCH 2/3 v2] x86/platform/geode: Convert geos LED to GPIO machine descriptor Date: Thu, 27 Aug 2020 10:08:25 +0200 Message-Id: <20200827080826.186024-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200827080826.186024-1-linus.walleij@linaro.org> References: <20200827080826.186024-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This makes the machine look up the LED from a GPIO machine descriptor table. The Geode LEDs should be on the CS5535 companion chip. Cc: linux-gpio@vger.kernel.org Cc: linux-geode@lists.infradead.org Cc: Darren Hart Cc: platform-driver-x86@vger.kernel.org Reviewed-by: Andy Shevchenko --- ChangeLog v1->v2: - Drop excess comma after terminator { } - Collect Andy's Reviewed-by --- arch/x86/platform/geode/geos.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) -- 2.26.2 diff --git a/arch/x86/platform/geode/geos.c b/arch/x86/platform/geode/geos.c index 73a3f49b4eb6..d263528c90bb 100644 --- a/arch/x86/platform/geode/geos.c +++ b/arch/x86/platform/geode/geos.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -53,21 +54,15 @@ static struct platform_device geos_buttons_dev = { static struct gpio_led geos_leds[] = { { .name = "geos:1", - .gpio = 6, .default_trigger = "default-on", - .active_low = 1, }, { .name = "geos:2", - .gpio = 25, .default_trigger = "default-off", - .active_low = 1, }, { .name = "geos:3", - .gpio = 27, .default_trigger = "default-off", - .active_low = 1, }, }; @@ -76,6 +71,17 @@ static struct gpio_led_platform_data geos_leds_data = { .leds = geos_leds, }; +static struct gpiod_lookup_table geos_leds_gpio_table = { + .dev_id = "leds-gpio", + .table = { + /* The Geode GPIOs should be on the CS5535 companion chip */ + GPIO_LOOKUP_IDX("cs5535-gpio", 6, NULL, 0, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("cs5535-gpio", 25, NULL, 1, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("cs5535-gpio", 27, NULL, 2, GPIO_ACTIVE_LOW), + { } + }, +}; + static struct platform_device geos_leds_dev = { .name = "leds-gpio", .id = -1, @@ -90,6 +96,7 @@ static struct platform_device *geos_devs[] __initdata = { static void __init register_geos(void) { /* Setup LED control through leds-gpio driver */ + gpiod_add_lookup_table(&geos_leds_gpio_table); platform_add_devices(geos_devs, ARRAY_SIZE(geos_devs)); }