From patchwork Tue Nov 24 08:53:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 331385 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp4194028ejb; Tue, 24 Nov 2020 00:53:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+E018X/tl4YuCEYBWd2oLSvHdzgc63H4JSNsM2NY5taJSbtpq9gGj4Dh+9BG1HxVKGh/D X-Received: by 2002:a50:a6c9:: with SMTP id f9mr3017060edc.158.1606208032741; Tue, 24 Nov 2020 00:53:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606208032; cv=none; d=google.com; s=arc-20160816; b=yV5KbZAFjGsuqKwgmtRYX9hot9WqHSnU+REhCIIetjOAQAx5eVA2ZLXlJTDUEySR6t I/fY98vOLwFpqvLlV123wmIRjGT8ekXf1sBboVoBbha4ExQykfux59FbqR2IxTbwUln1 hD2YD0gM51j5TAcelrNvvXSJtCL6sesF8HgtEio0WBntHeQJWzmmKzs6K7sj+fkTiHkW PIsUjOhi4sa1asnpAVIgPrxMkxskJC0pLDAdHnbLszF5vHLhAO/a9ve4G9NE3kIjgDFc rtU2shjPdrqwW9b7aQ/X+VejVYMpFohPbquYI923rqyhRP2ahCX/H/Jn0+qQPQrMNyBP xqfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DeDKS22xxFRIc+6wUo2VF8v+jvsdd+gENbNOUYHzsn4=; b=gJ0T0EMvsGaS5qxO+QzQHYwYRHQfYd1kpUeiLxpl0jlgQcVkOKM/BwgUL9+r4RdzFp EHJrfoij82chDX99P4cSx7Yq2cjzxB3CtbOQeeW8nm88l5CDmrh8Ge9WZDO4dHxyx92R hBmiLX3Dz7NWQj0KWf01n2ZeiPll5yEDkmEKFUvWO6fsJ1egWuEdZXwyKjMNhHyYuzRQ MISSJWuSPbaT/Vvn+5FtytY5KMeZ2CI3DnN53x9VisKZQfDTafrZj9vZljKIi4NH5zIM qbwo9ZejKIz8qUqmcd1O5bDzK5x9zFOVBZSegkXX3bwtpyjMQljkczepdu5Q4weBwg81 f9Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ML1KH1Nq; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi10si8834171edb.483.2020.11.24.00.53.52; Tue, 24 Nov 2020 00:53:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ML1KH1Nq; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730909AbgKXIxw (ORCPT + 3 others); Tue, 24 Nov 2020 03:53:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730822AbgKXIxv (ORCPT ); Tue, 24 Nov 2020 03:53:51 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591C6C0613D6 for ; Tue, 24 Nov 2020 00:53:51 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id u18so27733600lfd.9 for ; Tue, 24 Nov 2020 00:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DeDKS22xxFRIc+6wUo2VF8v+jvsdd+gENbNOUYHzsn4=; b=ML1KH1Nqxbw1laEF6QOiRvnmnv5UV6BFToUc5zCa27vKNcvtgkJGo2WdNfKp77dxMr eruq3rz7K0z28AxgnLp9goEw7T8DkwctJvqD71gWc/+TjheBUj7G4UxhCLPWAtsMNBLO JWbH+bETiUFo/4mlgVMGHokgwjLh6BeyJw1Eq6dnT26aovo2TBv0xtFSZDR2F77x02NB +PFp9fHufg/ckI19XCOySwxT6pV7hGbitk97+La1VghwjRLrqI88fm8uK/n9NWq8w5vt 7r6T5fiKz1OYQ7YvxNdnTc+YIFj6Q015tnayETqLVrsHeBPXH6muvu52Kpipk9z32NFB h6+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DeDKS22xxFRIc+6wUo2VF8v+jvsdd+gENbNOUYHzsn4=; b=tjg8ClHJ0TdEv3vBOb0js+Z9x2KVut4z4DVsD2W/QkDZJWdvIAkbykf2ovO8SZ1Grt 3yETWcoWJIwj3oNcYuQ2gtP89Qrc3Ntef1Qv4Dxxok9jmmA4/4yKX+x1b6jmi9k3efWc PuTSM/Siqw7XUnc+xzkmGPxP0WgBkzXWiYZDP0VtFxg26AyMJM80uY/oqTjPtvGZnJm+ zeuwI5b0MKXbLx1BolPM9DJiO59k2g6eMXGP1WuxiQHggN6d9Udl2+eah7i9yJMB5GH1 H3YZhl/MWQSUIcPpjL6ziSA6HeRlK7DdYXty1ckkwXmQcwBWi9EwwwVTLkxzb0Ci+N9B g+Vg== X-Gm-Message-State: AOAM531eMMrqCwoq8DFSK9KyZCn8dEh50hrsqJV7xqDjeh2g6P1osHog tVpd+HybDxr+9RgoP3gHaErkPQ== X-Received: by 2002:a19:bec6:: with SMTP id o189mr1588416lff.179.1606208029870; Tue, 24 Nov 2020 00:53:49 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id u18sm746602lfq.145.2020.11.24.00.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 00:53:49 -0800 (PST) From: Linus Walleij To: Hans de Goede , Mark Gross Cc: platform-driver-x86@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, linux-geode@lists.infradead.org, Darren Hart , x86@kernel.org, Andy Shevchenko Subject: [PATCH 2/3 v4] x86/platform/geode: Convert geode LED to GPIO machine descriptor Date: Tue, 24 Nov 2020 09:53:38 +0100 Message-Id: <20201124085339.6181-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201124085339.6181-1-linus.walleij@linaro.org> References: <20201124085339.6181-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This makes the machine look up the LED from a GPIO machine descriptor table. The Geode LEDs should be on the CS5535 companion chip. Cc: linux-gpio@vger.kernel.org Cc: linux-geode@lists.infradead.org Cc: Darren Hart Cc: platform-driver-x86@vger.kernel.org Cc: x86@kernel.org Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Cc x86@kernel.org - Collect Hans' Review tag. ChangeLog v2->v3: - Rebase on v5.10-rc1 - Resend ChangeLog v1->v2: - Drop excess comma after terminator { } - Collect Andy's Reviewed-by --- arch/x86/platform/geode/geos.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) -- 2.26.2 diff --git a/arch/x86/platform/geode/geos.c b/arch/x86/platform/geode/geos.c index 73a3f49b4eb6..d263528c90bb 100644 --- a/arch/x86/platform/geode/geos.c +++ b/arch/x86/platform/geode/geos.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -53,21 +54,15 @@ static struct platform_device geos_buttons_dev = { static struct gpio_led geos_leds[] = { { .name = "geos:1", - .gpio = 6, .default_trigger = "default-on", - .active_low = 1, }, { .name = "geos:2", - .gpio = 25, .default_trigger = "default-off", - .active_low = 1, }, { .name = "geos:3", - .gpio = 27, .default_trigger = "default-off", - .active_low = 1, }, }; @@ -76,6 +71,17 @@ static struct gpio_led_platform_data geos_leds_data = { .leds = geos_leds, }; +static struct gpiod_lookup_table geos_leds_gpio_table = { + .dev_id = "leds-gpio", + .table = { + /* The Geode GPIOs should be on the CS5535 companion chip */ + GPIO_LOOKUP_IDX("cs5535-gpio", 6, NULL, 0, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("cs5535-gpio", 25, NULL, 1, GPIO_ACTIVE_LOW), + GPIO_LOOKUP_IDX("cs5535-gpio", 27, NULL, 2, GPIO_ACTIVE_LOW), + { } + }, +}; + static struct platform_device geos_leds_dev = { .name = "leds-gpio", .id = -1, @@ -90,6 +96,7 @@ static struct platform_device *geos_devs[] __initdata = { static void __init register_geos(void) { /* Setup LED control through leds-gpio driver */ + gpiod_add_lookup_table(&geos_leds_gpio_table); platform_add_devices(geos_devs, ARRAY_SIZE(geos_devs)); }