diff mbox series

[v5,02/11] configfs: use (1UL << bit) for internal flags

Message ID 20210315091400.13772-3-brgl@bgdev.pl
State New
Headers show
Series gpio: implement the configfs testing module | expand

Commit Message

Bartosz Golaszewski March 15, 2021, 9:13 a.m. UTC 
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

For better readability and maintenance: use the (1UL << bit) for flag
definitions.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
 fs/configfs/configfs_internal.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

David Laight March 15, 2021, 3:31 p.m. UTC | #1 
From: Bartosz Golaszewski
> Sent: 15 March 2021 09:14
> 
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> For better readability and maintenance: use the (1UL << bit) for flag
> definitions.

If the values ever get printed in hex the hex definitions are
actually more useful.

	David

...
> -#define CONFIGFS_ROOT		0x0001
> -#define CONFIGFS_DIR		0x0002
> -#define CONFIGFS_ITEM_ATTR	0x0004
> -#define CONFIGFS_ITEM_BIN_ATTR	0x0008
> -#define CONFIGFS_ITEM_LINK	0x0020
> -#define CONFIGFS_USET_DIR	0x0040
> -#define CONFIGFS_USET_DEFAULT	0x0080
> -#define CONFIGFS_USET_DROPPING	0x0100
> -#define CONFIGFS_USET_IN_MKDIR	0x0200
> -#define CONFIGFS_USET_CREATING	0x0400
> +#define CONFIGFS_ROOT			(1UL << 0)
> +#define CONFIGFS_DIR			(1UL << 1)
> +#define CONFIGFS_ITEM_ATTR		(1UL << 2)
> +#define CONFIGFS_ITEM_BIN_ATTR		(1UL << 3)
> +#define CONFIGFS_ITEM_LINK		(1UL << 5)
> +#define CONFIGFS_USET_DIR		(1UL << 6)
> +#define CONFIGFS_USET_DEFAULT		(1UL << 7)
> +#define CONFIGFS_USET_DROPPING		(1UL << 8)
> +#define CONFIGFS_USET_IN_MKDIR		(1UL << 9)
> +#define CONFIGFS_USET_CREATING		(1UL << 10)
>  #define CONFIGFS_NOT_PINNED	(CONFIGFS_ITEM_ATTR | CONFIGFS_ITEM_BIN_ATTR)
> 
>  extern struct mutex configfs_symlink_mutex;
> --
> 2.30.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Andy Shevchenko March 15, 2021, 4:36 p.m. UTC | #2 
On Mon, Mar 15, 2021 at 5:33 PM David Laight <David.Laight@aculab.com> wrote:
> From: Bartosz Golaszewski
> > Sent: 15 March 2021 09:14
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > For better readability and maintenance: use the (1UL << bit) for flag
> > definitions.
>
> If the values ever get printed in hex the hex definitions are
> actually more useful.

Huh?!
diff mbox series

Patch

diff --git a/fs/configfs/configfs_internal.h b/fs/configfs/configfs_internal.h
index 9a3aed249692..b495c9f043d4 100644
--- a/fs/configfs/configfs_internal.h
+++ b/fs/configfs/configfs_internal.h
@@ -46,16 +46,16 @@  struct configfs_dirent {
 	struct configfs_fragment *s_frag;
 };
 
-#define CONFIGFS_ROOT		0x0001
-#define CONFIGFS_DIR		0x0002
-#define CONFIGFS_ITEM_ATTR	0x0004
-#define CONFIGFS_ITEM_BIN_ATTR	0x0008
-#define CONFIGFS_ITEM_LINK	0x0020
-#define CONFIGFS_USET_DIR	0x0040
-#define CONFIGFS_USET_DEFAULT	0x0080
-#define CONFIGFS_USET_DROPPING	0x0100
-#define CONFIGFS_USET_IN_MKDIR	0x0200
-#define CONFIGFS_USET_CREATING	0x0400
+#define CONFIGFS_ROOT			(1UL << 0)
+#define CONFIGFS_DIR			(1UL << 1)
+#define CONFIGFS_ITEM_ATTR		(1UL << 2)
+#define CONFIGFS_ITEM_BIN_ATTR		(1UL << 3)
+#define CONFIGFS_ITEM_LINK		(1UL << 5)
+#define CONFIGFS_USET_DIR		(1UL << 6)
+#define CONFIGFS_USET_DEFAULT		(1UL << 7)
+#define CONFIGFS_USET_DROPPING		(1UL << 8)
+#define CONFIGFS_USET_IN_MKDIR		(1UL << 9)
+#define CONFIGFS_USET_CREATING		(1UL << 10)
 #define CONFIGFS_NOT_PINNED	(CONFIGFS_ITEM_ATTR | CONFIGFS_ITEM_BIN_ATTR)
 
 extern struct mutex configfs_symlink_mutex;