| Message ID | 20220811124135.95299-2-shenwei.wang@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add IMX8 SCU GPIO support | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, August 11, 2022 9:36 AM > To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev > Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver > bindings > > diff --git > > a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > > b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > > new file mode 100644 > > index 000000000000..a1b024cddc97 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > > +description: | > > + This module provides the standard interface to control the > > + resource pins in SCU domain on i.MX8 platforms. > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8qxp-sc-gpio > > Now the filename does not match compatible. Use the same compatible as > filename. The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is "fsl,scu-wdt.yaml". Is the filename required to match its compatible? Regards, Shenwei > > Best regards, > Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, August 11, 2022 10:11 AM > To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev > Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver > bindings > > Caution: EXT Email > > On 11/08/2022 17:52, Shenwei Wang wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Thursday, August 11, 2022 9:36 AM > >> To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; > >> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; > >> brgl@bgdev.pl; shawnguo@kernel.org; s.hauer@pengutronix.de; > >> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > >> <linux-imx@nxp.com> > >> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > >> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> imx@lists.linux.dev > >> Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio > >> driver bindings > >>> diff --git > >>> a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > >>> b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > >>> new file mode 100644 > >>> index 000000000000..a1b024cddc97 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml > >>> +description: | > >>> + This module provides the standard interface to control the > >>> + resource pins in SCU domain on i.MX8 platforms. > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - fsl,imx8qxp-sc-gpio > >> > >> Now the filename does not match compatible. Use the same compatible > >> as filename. > > > > The subnodes under fsl,scu.yaml have their own naming rule. For > > example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is > "fsl,scu-wdt.yaml". > > The other files have for example fsl,imx-sc-wdt, so they match compatible. I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory. $ ls fsl* fsl-imx7ulp-wdt.yaml fsl-imx-wdt.yaml fsl,scu-wdt.yaml Regards, Shenwei > > > Is the filename required > > to match its compatible? > > Yes, that's the convention. Otherwise people tend to name the files in whatever > way they like... > > Best regards, > Krzysztof
On 11/08/2022 18:30, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Thursday, August 11, 2022 10:11 AM >> To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; >> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com> >> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev >> Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver >> bindings >> >> Caution: EXT Email >> >> On 11/08/2022 17:52, Shenwei Wang wrote: >>> >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: Thursday, August 11, 2022 9:36 AM >>>> To: Shenwei Wang <shenwei.wang@nxp.com>; robh+dt@kernel.org; >>>> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; >>>> brgl@bgdev.pl; shawnguo@kernel.org; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx >>>> <linux-imx@nxp.com> >>>> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >>>> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >>>> imx@lists.linux.dev >>>> Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio >>>> driver bindings >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> new file mode 100644 >>>>> index 000000000000..a1b024cddc97 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> +description: | >>>>> + This module provides the standard interface to control the >>>>> + resource pins in SCU domain on i.MX8 platforms. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - fsl,imx8qxp-sc-gpio >>>> >>>> Now the filename does not match compatible. Use the same compatible >>>> as filename. >>> >>> The subnodes under fsl,scu.yaml have their own naming rule. For >>> example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is >> "fsl,scu-wdt.yaml". >> >> The other files have for example fsl,imx-sc-wdt, so they match compatible. > > I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory. > > $ ls fsl* > fsl-imx7ulp-wdt.yaml fsl-imx-wdt.yaml fsl,scu-wdt.yaml Eh, they looked similar enough that I did not spot it during review. fsl,scu-wdt.yaml should be named fsl,imx-sc-wdt.yaml, of course. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file mode 100644 index 000000000000..a1b024cddc97 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/fsl,imx-sc-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO driver over IMX SCU firmware API + +maintainers: + - Shenwei Wang <shenwei.wang@nxp.com> + +description: | + This module provides the standard interface to control the + resource pins in SCU domain on i.MX8 platforms. + +properties: + compatible: + enum: + - fsl,imx8qxp-sc-gpio + + "#gpio-cells": + const: 2 + + gpio-controller: true + +required: + - compatible + - "#gpio-cells" + - gpio-controller + +additionalProperties: false + +examples: + - | + gpio0: gpio { + compatible = "fsl,imx8qxp-sc-gpio"; + gpio-controller; + #gpio-cells = <2>; + };
Add binding document for the imx scu gpio driver. Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> --- .../bindings/gpio/fsl,imx-sc-gpio.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml