| Message ID | 20221005-mdm9615-pinctrl-yaml-v1-3-0cbc006e2a30@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: qcom: mdm9615: second round of bindings and DT fixes | expand |
On 6.10.2022 11:58, Neil Armstrong wrote: > Fix the sx150xq node names to pinctrl and use the right probe-reset property. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Could you please also fix up the property order (may be in a separate patchset ofc)? Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > index 30a110984597..a8304769b509 100644 > --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > @@ -116,7 +116,7 @@ i2c@4 { > #size-cells = <0>; > reg = <4>; > > - gpioext0: gpio@3e { > + gpioext0: pinctrl@3e { > /* GPIO Expander 0 Mapping : > * - 0: ARDUINO_RESET_Level shift > * - 1: BattChrgr_PG_N > @@ -142,7 +142,7 @@ gpioext0: gpio@3e { > interrupt-parent = <&gpioext1>; > interrupts = <0 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; > @@ -154,7 +154,7 @@ i2c@5 { > #size-cells = <0>; > reg = <5>; > > - gpioext1: gpio@3f { > + gpioext1: pinctrl@3f { > /* GPIO Expander 1 Mapping : > * - 0: GPIOEXP_INT1 > * - 1: Battery detect > @@ -183,7 +183,7 @@ gpioext1: gpio@3f { > interrupt-parent = <&msmgpio>; > interrupts = <0 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; > @@ -195,7 +195,7 @@ i2c@6 { > #size-cells = <0>; > reg = <6>; > > - gpioext2: gpio@70 { > + gpioext2: pinctrl@70 { > /* GPIO Expander 2 Mapping : > * - 0: USB_HUB_INTn > * - 1: HUB_CONNECT > @@ -221,7 +221,7 @@ gpioext2: gpio@70 { > interrupt-parent = <&gpioext1>; > interrupts = <14 IRQ_TYPE_EDGE_FALLING>; > > - probe-reset; > + semtech,probe-reset; > > gpio-controller; > interrupt-controller; >
On 07/10/2022 21:38, Konrad Dybcio wrote: > > > On 6.10.2022 11:58, Neil Armstrong wrote: >> Fix the sx150xq node names to pinctrl and use the right probe-reset property. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- > Could you please also fix up the property order (may be in a separate patchset ofc)? Yup, sure > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > Konrad Thanks Neil <snip>
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts index 30a110984597..a8304769b509 100644 --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts @@ -116,7 +116,7 @@ i2c@4 { #size-cells = <0>; reg = <4>; - gpioext0: gpio@3e { + gpioext0: pinctrl@3e { /* GPIO Expander 0 Mapping : * - 0: ARDUINO_RESET_Level shift * - 1: BattChrgr_PG_N @@ -142,7 +142,7 @@ gpioext0: gpio@3e { interrupt-parent = <&gpioext1>; interrupts = <0 IRQ_TYPE_EDGE_FALLING>; - probe-reset; + semtech,probe-reset; gpio-controller; interrupt-controller; @@ -154,7 +154,7 @@ i2c@5 { #size-cells = <0>; reg = <5>; - gpioext1: gpio@3f { + gpioext1: pinctrl@3f { /* GPIO Expander 1 Mapping : * - 0: GPIOEXP_INT1 * - 1: Battery detect @@ -183,7 +183,7 @@ gpioext1: gpio@3f { interrupt-parent = <&msmgpio>; interrupts = <0 IRQ_TYPE_EDGE_FALLING>; - probe-reset; + semtech,probe-reset; gpio-controller; interrupt-controller; @@ -195,7 +195,7 @@ i2c@6 { #size-cells = <0>; reg = <6>; - gpioext2: gpio@70 { + gpioext2: pinctrl@70 { /* GPIO Expander 2 Mapping : * - 0: USB_HUB_INTn * - 1: HUB_CONNECT @@ -221,7 +221,7 @@ gpioext2: gpio@70 { interrupt-parent = <&gpioext1>; interrupts = <14 IRQ_TYPE_EDGE_FALLING>; - probe-reset; + semtech,probe-reset; gpio-controller; interrupt-controller;
Fix the sx150xq node names to pinctrl and use the right probe-reset property. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)