| Message ID | 20221028153505.23741-9-y.oudjana@protonmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support | expand |
On 28/10/2022 11:35, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Change "subnodes" to "subnode" in subnode description for better grammatical > accuracy, capitalize pinmux description, wrap all descriptions at 80 characters, > and remove literal style indicators from descriptions that don't need their new > lines preserved. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- I propose to squash it with the one changing description here. Best regards, Krzysztof
On Fri, Oct 28 2022 at 15:58:30 -04:00:00, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 28/10/2022 11:35, Yassine Oudjana wrote: >> From: Yassine Oudjana <y.oudjana@protonmail.com> >> >> Change "subnodes" to "subnode" in subnode description for better >> grammatical >> accuracy, capitalize pinmux description, wrap all descriptions at >> 80 characters, >> and remove literal style indicators from descriptions that don't >> need their new >> lines preserved. >> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> --- > > I propose to squash it with the one changing description here. You mean patch 6 "dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Improve interrupts description"? If yes, would that mean improving descriptions in mediatek,pinctrl-mt6795.yaml then pulling them into mt6779?
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml index 23b1f7867afb..70e4ffa2d897 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml @@ -118,11 +118,12 @@ patternProperties: patternProperties: '^pins': type: object - description: | - A pinctrl node should contain at least one subnodes representing the + description: + A pinctrl node should contain at least one subnode representing the pinctrl groups available on the machine. Each subnode will list the - pins it needs, and how they should be configured, with regard to muxer - configuration, pullups, drive strength, input enable/disable and input schmitt. + pins it needs, and how they should be configured, with regard to + muxer configuration, pullups, drive strength, input enable/disable + and input schmitt. allOf: - $ref: pinmux-node.yaml - $ref: pincfg-node.yaml @@ -130,9 +131,9 @@ patternProperties: properties: pinmux: description: - integer array, represents gpio pin number and mux setting. - Supported pin number and mux varies for different SoCs, and are defined - as macros in boot/dts/<soc>-pinfunc.h directly. + Integer array, represents gpio pin number and mux setting. + Supported pin number and mux varies for different SoCs, and are + defined as macros in boot/dts/<soc>-pinfunc.h directly. bias-disable: true @@ -141,7 +142,7 @@ patternProperties: - type: boolean - enum: [100, 101, 102, 103] description: Pull up PUPD/R0/R1 type define value. - description: | + description: For normal pull up type, it is not necessary to specify R1R0 values; When pull up type is PUPD/R0/R1, adding R1R0 defines will set different resistance values. @@ -151,7 +152,7 @@ patternProperties: - type: boolean - enum: [100, 101, 102, 103] description: Pull down PUPD/R0/R1 type define value. - description: | + description: For normal pull down type, it is not necessary to specify R1R0 values; When pull down type is PUPD/R0/R1, adding R1R0 defines will set different resistance values.