| Message ID | 20230214115553.10416-7-dipenp@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Tegra234 HTE support | expand |
On 14/02/2023 12:55, Dipen Patel wrote: > Add GTE nodes for the tegra234. Also modify AON GTE nodes for the > tegra194 to remove nvidia,slice property and add nvidia,gpio-controller > propertyto specify AON GPIO controller node so that GTE driver can > do namespace conversion between GPIO lines provided by the gpiolib > framework and hardware timestamping engine subsystem. > > Signed-off-by: Dipen Patel <dipenp@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra194.dtsi | 3 +-- > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi > index 4afcbd60e144..4c92850b1ec4 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi > @@ -1363,7 +1363,6 @@ > reg = <0x3aa0000 0x10000>; > interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > nvidia,int-threshold = <1>; > - nvidia,slices = <11>; > #timestamp-cells = <1>; > status = "okay"; > }; > @@ -1586,7 +1585,7 @@ > reg = <0xc1e0000 0x10000>; > interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; > nvidia,int-threshold = <1>; > - nvidia,slices = <3>; > + nvidia,gpio-controller = <&gpio_aon>; > #timestamp-cells = <1>; > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > index eaf05ee9acd1..4a87490c5fd4 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > @@ -1086,6 +1086,15 @@ > clock-names = "fuse"; > }; > > + hte_lic: hardware-timestamp@3aa0000 { > + compatible = "nvidia,tegra234-gte-lic"; > + reg = <0x3aa0000 0x10000>; > + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; > + nvidia,int-threshold = <1>; > + #timestamp-cells = <1>; > + status = "okay"; Why do you need status? It's okay by default. > + }; > + > hsp_top0: hsp@3c00000 { > compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp"; > reg = <0x03c00000 0xa0000>; > @@ -1603,6 +1612,16 @@ > #mbox-cells = <2>; > }; > > + hte_aon: hardware-timestamp@c1e0000 { > + compatible = "nvidia,tegra234-gte-aon"; > + reg = <0xc1e0000 0x10000>; > + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; > + nvidia,int-threshold = <1>; > + nvidia,gpio-controller = <&gpio_aon>; > + #timestamp-cells = <1>; > + status = "okay"; Also here Best regards, Krzysztof
On 08/03/2023 21:13, Dipen Patel wrote: > On 2/16/23 6:18 AM, Krzysztof Kozlowski wrote: >> On 14/02/2023 12:55, Dipen Patel wrote: >>> Add GTE nodes for the tegra234. Also modify AON GTE nodes for the >>> tegra194 to remove nvidia,slice property and add nvidia,gpio-controller >>> propertyto specify AON GPIO controller node so that GTE driver can >>> do namespace conversion between GPIO lines provided by the gpiolib >>> framework and hardware timestamping engine subsystem. >>> >>> Signed-off-by: Dipen Patel <dipenp@nvidia.com> >>> --- >>> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 3 +-- >>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +++++++++++++++++++ >>> 2 files changed, 20 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi >>> index 4afcbd60e144..4c92850b1ec4 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi >>> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi >>> @@ -1363,7 +1363,6 @@ >>> reg = <0x3aa0000 0x10000>; >>> interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; >>> nvidia,int-threshold = <1>; >>> - nvidia,slices = <11>; >>> #timestamp-cells = <1>; >>> status = "okay"; >>> }; >>> @@ -1586,7 +1585,7 @@ >>> reg = <0xc1e0000 0x10000>; >>> interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; >>> nvidia,int-threshold = <1>; >>> - nvidia,slices = <3>; >>> + nvidia,gpio-controller = <&gpio_aon>; >>> #timestamp-cells = <1>; >>> status = "okay"; >>> }; >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi >>> index eaf05ee9acd1..4a87490c5fd4 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi >>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi >>> @@ -1086,6 +1086,15 @@ >>> clock-names = "fuse"; >>> }; >>> >>> + hte_lic: hardware-timestamp@3aa0000 { >>> + compatible = "nvidia,tegra234-gte-lic"; >>> + reg = <0x3aa0000 0x10000>; >>> + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; >>> + nvidia,int-threshold = <1>; >>> + #timestamp-cells = <1>; >>> + status = "okay"; >> >> Why do you need status? It's okay by default. > what's harm of having to explicitly mentioned? Because useless code is not helping any review. We do not add other useless properties, or shall we add them? >I can see status = okay in this dtsi file > for other nodes as well and was just following that. So if you see a bug somewhere, you also duplicate it in your code? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi index 4afcbd60e144..4c92850b1ec4 100644 --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi @@ -1363,7 +1363,6 @@ reg = <0x3aa0000 0x10000>; interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; nvidia,int-threshold = <1>; - nvidia,slices = <11>; #timestamp-cells = <1>; status = "okay"; }; @@ -1586,7 +1585,7 @@ reg = <0xc1e0000 0x10000>; interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; nvidia,int-threshold = <1>; - nvidia,slices = <3>; + nvidia,gpio-controller = <&gpio_aon>; #timestamp-cells = <1>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi index eaf05ee9acd1..4a87490c5fd4 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi @@ -1086,6 +1086,15 @@ clock-names = "fuse"; }; + hte_lic: hardware-timestamp@3aa0000 { + compatible = "nvidia,tegra234-gte-lic"; + reg = <0x3aa0000 0x10000>; + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; + nvidia,int-threshold = <1>; + #timestamp-cells = <1>; + status = "okay"; + }; + hsp_top0: hsp@3c00000 { compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp"; reg = <0x03c00000 0xa0000>; @@ -1603,6 +1612,16 @@ #mbox-cells = <2>; }; + hte_aon: hardware-timestamp@c1e0000 { + compatible = "nvidia,tegra234-gte-aon"; + reg = <0xc1e0000 0x10000>; + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; + nvidia,int-threshold = <1>; + nvidia,gpio-controller = <&gpio_aon>; + #timestamp-cells = <1>; + status = "okay"; + }; + gen2_i2c: i2c@c240000 { compatible = "nvidia,tegra194-i2c"; reg = <0xc240000 0x100>;
Add GTE nodes for the tegra234. Also modify AON GTE nodes for the tegra194 to remove nvidia,slice property and add nvidia,gpio-controller propertyto specify AON GPIO controller node so that GTE driver can do namespace conversion between GPIO lines provided by the gpiolib framework and hardware timestamping engine subsystem. Signed-off-by: Dipen Patel <dipenp@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 3 +-- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-)